Return-Path: Delivered-To: apmail-db-jdo-dev-archive@www.apache.org Received: (qmail 35762 invoked from network); 4 Oct 2006 02:51:32 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 4 Oct 2006 02:51:32 -0000 Received: (qmail 31249 invoked by uid 500); 4 Oct 2006 02:51:32 -0000 Mailing-List: contact jdo-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jdo-dev@db.apache.org Delivered-To: mailing list jdo-dev@db.apache.org Received: (qmail 31238 invoked by uid 99); 4 Oct 2006 02:51:32 -0000 Received: from idunn.apache.osuosl.org (HELO idunn.apache.osuosl.org) (140.211.166.84) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Oct 2006 19:51:32 -0700 X-ASF-Spam-Status: No, hits=0.0 required=5.0 tests= Received: from [209.237.227.198] ([209.237.227.198:36820] helo=brutus.apache.org) by idunn.apache.osuosl.org (ecelerity 2.1.1.8 r(12930)) with ESMTP id 91/F8-00170-3B123254 for ; Tue, 03 Oct 2006 19:51:31 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id BD9AB7142D6 for ; Tue, 3 Oct 2006 19:51:21 -0700 (PDT) Message-ID: <13806908.1159930281774.JavaMail.root@brutus> Date: Tue, 3 Oct 2006 19:51:21 -0700 (PDT) From: "Craig Russell (JIRA)" To: jdo-dev@db.apache.org Subject: [jira] Commented: (JDO-427) StateTransitionsReturnedObjects incorrectly expects detachCopy() to allow passing a detached instance In-Reply-To: <33081274.1158371002268.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N [ http://issues.apache.org/jira/browse/JDO-427?page=comments#action_12439710 ] Craig Russell commented on JDO-427: ----------------------------------- This is a spec bug. The sentence "If the parameter instance is detached, then JDOUserException is thrown." should be read as part of the previous paragraph that describes the behavior if a transaction is not active. In this case, detached and transient instances cannot be made persistent before detach because makePersistent requires an active transaction. The operative behavior is "If a detachCopy method is called with an active transaction, the parameter Collection of instances is first made persistent, and the reachability algorithm is run on the instances. " I'd like to resolve this issue as invalid, since the intent is to only throw an exception if detached and transient instances in the reachability graph cannot be made persistent (if there is no active transaction). The maintenance release will clarify the intent. > StateTransitionsReturnedObjects incorrectly expects detachCopy() to allow passing a detached instance > ----------------------------------------------------------------------------------------------------- > > Key: JDO-427 > URL: http://issues.apache.org/jira/browse/JDO-427 > Project: JDO > Issue Type: Bug > Components: tck20 > Reporter: Marc Prud'hommeaux > Assigned To: Craig Russell > Priority: Minor > > Element 11 (0-based) of the "detachCopy with active tx" array in org/apache/jdo/tck/lifecycle/StateTransitionsReturnedObjects.java asserts that a detached instance passed to detachCopy() should result in its state being unchanged. However, section 12.6.8 of the JDO 2 spec explicitly states: "If the parameter instance is detached, then JDOUserException is thrown." > To fix it to check for the correct behavior, element 11 should be changed from "UNCHANGED" to "ERROR". -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira