db-jdo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michelle Caisse <Michelle.Cai...@Sun.COM>
Subject Re: setUp() not final in org.apache.jdo.tck.JDO_Test
Date Thu, 12 Oct 2006 13:04:28 GMT
Thanks, Michael.  I will add that information to the JIRA issue.

-- Michelle

Michael Watzek wrote:

> Hi Michelle,
>
> I agree with Craig. It's a bug. The same holds true for method 
> JDO_Test.runBare(). I should be declared final as well.
>
> Regards,
> Michael
>
> Craig L Russell schrieb:
>
>> Hi Michelle,
>>
>> I think it's a bug. It might lead to some non-trivial issues if setUp 
>> is overridden instead of using localSetUp. Could you try making it 
>> final and see if there are some tests that override it?
>>
>> Craig
>>
>> On Oct 11, 2006, at 10:57 AM, Michelle Caisse wrote:
>>
>>> Hi,
>>>
>>> I noticed that in JDO_Test, while tearDown() is declared final, 
>>> setUp() is not.  The javadoc says subclasses may override 
>>> localSetUp() and localTearDown().  Is it a bug that setUp() is not 
>>> declared final?
>>>
>>> -- Michelle
>>
>>
>> Craig Russell
>> Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
>> 408 276-5638 mailto:Craig.Russell@sun.com
>> P.S. A good JDO? O, Gasp!
>>
>
>


Mime
View raw message