db-jdo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Watzek <mwa.t...@spree.de>
Subject Re: setUp() not final in org.apache.jdo.tck.JDO_Test
Date Thu, 12 Oct 2006 10:16:02 GMT
Hi Michelle,

I agree with Craig. It's a bug. The same holds true for method 
JDO_Test.runBare(). I should be declared final as well.

Regards,
Michael

Craig L Russell schrieb:
> Hi Michelle,
> 
> I think it's a bug. It might lead to some non-trivial issues if setUp is 
> overridden instead of using localSetUp. Could you try making it final 
> and see if there are some tests that override it?
> 
> Craig
> 
> On Oct 11, 2006, at 10:57 AM, Michelle Caisse wrote:
> 
>> Hi,
>>
>> I noticed that in JDO_Test, while tearDown() is declared final, 
>> setUp() is not.  The javadoc says subclasses may override localSetUp() 
>> and localTearDown().  Is it a bug that setUp() is not declared final?
>>
>> -- Michelle
> 
> Craig Russell
> Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
> 408 276-5638 mailto:Craig.Russell@sun.com
> P.S. A good JDO? O, Gasp!
> 


-- 
-------------------------------------------------------------------
Michael Watzek                  Tech@Spree Engineering GmbH
mailto:mwa.tech@spree.de        Buelowstr. 66
Tel.:  ++49/30/235 520 36       10783 Berlin - Germany
Fax.:  ++49/30/217 520 12       http://www.spree.de/
-------------------------------------------------------------------

Mime
View raw message