db-jdo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michelle Caisse <Michelle.Cai...@Sun.COM>
Subject Re: setUp() not final in org.apache.jdo.tck.JDO_Test
Date Wed, 11 Oct 2006 19:45:56 GMT
A number of tests do override it.  Should I file a JIRA to fix all of this?

java:compile:
    [echo] Compiling to c:\svn0\jdo\trunk\tck20/target/classes
    [javac] Compiling 660 source files to 
C:\svn0\jdo\trunk\tck20\target\classes
C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\GetPersistenceManager.java:54:

setUp() in 
org.apache.jdo.tck.api.persistencemanagerfactory.GetPersistenceManager 
cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden 
method is final
    protected void setUp() throws Exception {
                   ^
C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\GetPersistenceManagerFactoryByPropertiesInstance.java:60:

setUp() in 
org.apache.jdo.tck.api.persistencemanagerfactory.GetPersistenceManagerFactoryByPropertiesInstance

cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden 
method is final
    protected void setUp() throws Exception {
                   ^
C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\GetPersistenceManagerForUser.java:63:

setUp() in 
org.apache.jdo.tck.api.persistencemanagerfactory.GetPersistenceManagerForUser 
cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden 
method is final
    protected void setUp() throws Exception {
                   ^
C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\SetConnectionPassword.java:54:

setUp() in 
org.apache.jdo.tck.api.persistencemanagerfactory.SetConnectionPassword 
cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden 
method is final
    protected void setUp() throws Exception {
                   ^
C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\SetConnectionURL.java:58:

setUp() in 
org.apache.jdo.tck.api.persistencemanagerfactory.SetConnectionURL cannot 
override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is final
    protected void setUp() throws Exception {
                   ^
C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\SetConnectionUserName.java:57:

setUp() in 
org.apache.jdo.tck.api.persistencemanagerfactory.SetConnectionUserName 
cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden 
method is final
    protected void setUp() throws Exception {
                   ^
C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\SetIgnoreCache.java:53:

setUp() in 
org.apache.jdo.tck.api.persistencemanagerfactory.SetIgnoreCache cannot 
override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is final
    protected void setUp() throws Exception {
                   ^
C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\SetMultithreaded.java:57:

setUp() in 
org.apache.jdo.tck.api.persistencemanagerfactory.SetMultithreaded cannot 
override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is final
    protected void setUp() throws Exception {
                   ^
C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\SetNonTransactionalRead.java:54:

setUp() in 
org.apache.jdo.tck.api.persistencemanagerfactory.SetNonTransactionalRead 
cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden 
method is final
    protected void setUp() throws Exception {
                   ^
C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\SetNonTransactionalWrite.java:54:

setUp() in 
org.apache.jdo.tck.api.persistencemanagerfactory.SetNonTransactionalWrite  
cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden 
method is final
    protected void setUp() throws Exception {
                   ^
C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\SetOptimistic.java:53:

setUp() in 
org.apache.jdo.tck.api.persistencemanagerfactory.SetOptimistic cannot 
override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is final
    protected void setUp() throws Exception {
                   ^
C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\SetRetainValues.java:55:

setUp() in 
org.apache.jdo.tck.api.persistencemanagerfactory.SetRetainValues cannot 
override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is final
    protected void setUp() throws Exception {
                   ^
-- Michelle

Craig L Russell wrote:

> Hi Michelle,
>
> I think it's a bug. It might lead to some non-trivial issues if setUp  
> is overridden instead of using localSetUp. Could you try making it  
> final and see if there are some tests that override it?
>
> Craig
>
> On Oct 11, 2006, at 10:57 AM, Michelle Caisse wrote:
>
>> Hi,
>>
>> I noticed that in JDO_Test, while tearDown() is declared final,  
>> setUp() is not.  The javadoc says subclasses may override localSetUp 
>> () and localTearDown().  Is it a bug that setUp() is not declared  
>> final?
>>
>> -- Michelle
>
>
> Craig Russell
> Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
> 408 276-5638 mailto:Craig.Russell@sun.com
> P.S. A good JDO? O, Gasp!
>


Mime
View raw message