Mailing-List: contact jdo-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jdo-dev@db.apache.org
Message-ID: <20465486.1157912242752.JavaMail.jira@brutus>
Date: Sun, 10 Sep 2006 11:17:22 -0700 (PDT)
From: "Michael Bouschen (JIRA)" <jira@apache.org>
To: jdo-dev@db.apache.org
Subject: [jira] Commented: (JDO-423) Missing addTearDownClass in
 org.apache.jdo.tck.query.jdoql.variables.VariablesWithoutExtent
In-Reply-To: <14563396.1157851342270.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

    [ http://issues.apache.org/jira/browse/JDO-423?page=comments#action_12433718 ] 
            
Michael Bouschen commented on JDO-423:
--------------------------------------

Hi Ilan,

you input is highly appreciated.

What kind of issue are you running into with cleaning up the NoExtent instances? I'm not sure whether moving addTearDownInstance to the beginning of the method would make any difference. Method addTearDownInstance retrieves the oid of the parameter instance and stores it in a local set. At cleanup time method tearDown iterates the list of registered oids, retrieves the pc instances using getObjectById and calls pm.deletePersistent to remove the instance. But if the pm.deletePersistent fails, the TCK is in trouble, because it cannot cleanup the database to prepare the next run. Do you have an idea what to do?

Regards Michael

> Missing addTearDownClass in org.apache.jdo.tck.query.jdoql.variables.VariablesWithoutExtent
> -------------------------------------------------------------------------------------------
>
>                 Key: JDO-423
>                 URL: http://issues.apache.org/jira/browse/JDO-423
>             Project: JDO
>          Issue Type: Bug
>          Components: tck20
>    Affects Versions: JDO 2 final
>            Reporter: Ilan Kirsh
>            Priority: Minor
>
> Lines 101- 108, instead of:
>     protected void localSetUp() {
>         addTearDownClass(CompanyModelReader.getTearDownClasses());
>         loadAndPersistCompanyModel(getPM());
>         NoExtent noExtent = new NoExtent(1);
>         makePersistent(noExtent);
>         addTearDownInstance(noExtent);
>     }
> should be:
>     protected void localSetUp() {
>         addTearDownClass(CompanyModelReader.getTearDownClasses());
>         addTearDownClass(NoExtent.class); // Added missing addTearDownClass
>         loadAndPersistCompanyModel(getPM());
>         NoExtent noExtent = new NoExtent(1);
>         makePersistent(noExtent);
>         addTearDownInstance(noExtent);
>     }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira