db-jdo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ilan Kirsh (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JDO-423) Missing addTearDownClass in org.apache.jdo.tck.query.jdoql.variables.VariablesWithoutExtent
Date Sun, 10 Sep 2006 15:14:22 GMT
    [ http://issues.apache.org/jira/browse/JDO-423?page=comments#action_12433708 ] 
            
Ilan Kirsh commented on JDO-423:
--------------------------------

This issue still reflects a real (minor) problem, even though it is clear to me now that the
solution that I suggested  is invalid. I noticed that after a failure to delete the NoExtent
instance once this test fails for all the next runs. Therefore, an alternative solution is
still required.

Please forgive my ignorance, my familiarly with the TCK architecture is very limited. However,
I will try another suggestion - maybe moving the addTearDownInstance to the beginning of the
method is the solution? Maybe putting it in a finally block?


> Missing addTearDownClass in org.apache.jdo.tck.query.jdoql.variables.VariablesWithoutExtent
> -------------------------------------------------------------------------------------------
>
>                 Key: JDO-423
>                 URL: http://issues.apache.org/jira/browse/JDO-423
>             Project: JDO
>          Issue Type: Bug
>          Components: tck20
>    Affects Versions: JDO 2 final
>            Reporter: Ilan Kirsh
>            Priority: Minor
>
> Lines 101- 108, instead of:
>     protected void localSetUp() {
>         addTearDownClass(CompanyModelReader.getTearDownClasses());
>         loadAndPersistCompanyModel(getPM());
>         NoExtent noExtent = new NoExtent(1);
>         makePersistent(noExtent);
>         addTearDownInstance(noExtent);
>     }
> should be:
>     protected void localSetUp() {
>         addTearDownClass(CompanyModelReader.getTearDownClasses());
>         addTearDownClass(NoExtent.class); // Added missing addTearDownClass
>         loadAndPersistCompanyModel(getPM());
>         NoExtent noExtent = new NoExtent(1);
>         makePersistent(noExtent);
>         addTearDownInstance(noExtent);
>     }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message