db-jdo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ilan Kirsh (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JDO-423) Missing addTearDownClass in org.apache.jdo.tck.query.jdoql.variables.VariablesWithoutExtent
Date Mon, 11 Sep 2006 18:40:24 GMT
    [ http://issues.apache.org/jira/browse/JDO-423?page=comments#action_12433928 ] 
            
Ilan Kirsh commented on JDO-423:
--------------------------------

I agree that the test is valid. Probably my expectations for automatic recovery after a delete
failure in the implementation were too excessive. I just saw that all the other tests know
to recover in the next run and this test is different. Maybe implementation of addTearDownInstance
that deletes object by ID can solve this. However, I understand that this is not a job of
the TCK and deletion of the database file solves the problem anyway, so I have no objection
to close this issue as invalid.

> Missing addTearDownClass in org.apache.jdo.tck.query.jdoql.variables.VariablesWithoutExtent
> -------------------------------------------------------------------------------------------
>
>                 Key: JDO-423
>                 URL: http://issues.apache.org/jira/browse/JDO-423
>             Project: JDO
>          Issue Type: Bug
>          Components: tck20
>    Affects Versions: JDO 2 final
>            Reporter: Ilan Kirsh
>            Priority: Minor
>
> Lines 101- 108, instead of:
>     protected void localSetUp() {
>         addTearDownClass(CompanyModelReader.getTearDownClasses());
>         loadAndPersistCompanyModel(getPM());
>         NoExtent noExtent = new NoExtent(1);
>         makePersistent(noExtent);
>         addTearDownInstance(noExtent);
>     }
> should be:
>     protected void localSetUp() {
>         addTearDownClass(CompanyModelReader.getTearDownClasses());
>         addTearDownClass(NoExtent.class); // Added missing addTearDownClass
>         loadAndPersistCompanyModel(getPM());
>         NoExtent noExtent = new NoExtent(1);
>         makePersistent(noExtent);
>         addTearDownInstance(noExtent);
>     }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message