Return-Path: Delivered-To: apmail-db-jdo-dev-archive@www.apache.org Received: (qmail 63244 invoked from network); 9 Aug 2006 09:10:02 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 9 Aug 2006 09:10:02 -0000 Received: (qmail 52012 invoked by uid 500); 9 Aug 2006 09:10:01 -0000 Mailing-List: contact jdo-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jdo-dev@db.apache.org Delivered-To: mailing list jdo-dev@db.apache.org Received: (qmail 52001 invoked by uid 99); 9 Aug 2006 09:10:01 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Aug 2006 02:10:01 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [209.237.227.198] (HELO brutus.apache.org) (209.237.227.198) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Aug 2006 02:09:59 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 3C0D671421B for ; Wed, 9 Aug 2006 09:07:16 +0000 (GMT) Message-ID: <6208162.1155114436243.JavaMail.jira@brutus> Date: Wed, 9 Aug 2006 02:07:16 -0700 (PDT) From: "Andy Jefferson (JIRA)" To: jdo-dev@db.apache.org Subject: [jira] Commented: (JDO-405) recursion-depth - fetching the whole graph with 0 or -1? In-Reply-To: <18361633.1155112993825.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N [ http://issues.apache.org/jira/browse/JDO-405?page=comments#action_12426877 ] Andy Jefferson commented on JDO-405: ------------------------------------ AFAIK the p127 comment is erroneous and is a cut-paste. Only one value is needed for representing "no limit" and this was -1 with "fetch-depth" (before the renaming) and is what 12.7.4 has (and would be consistent with what values maxFetchDepth takes). I would add that page 129 has an example that uses "fetch-depth" which was removed/renamed, so this needs fixing. I don't see a reason to change the default we agreed some time back. Default of maxFetchDepth of 1 and recursion-depth of 1 are both consistent with fetching just the immediate objects. > recursion-depth - fetching the whole graph with 0 or -1? > -------------------------------------------------------- > > Key: JDO-405 > URL: http://issues.apache.org/jira/browse/JDO-405 > Project: JDO > Issue Type: Bug > Affects Versions: JDO 2 final > Reporter: Ilan Kirsh > > In page 124: "A value of -1 means that the recursion-depth is not limited by traversing this field." > In page 127: "A recursion-depth of 0 will fetch the whole graph of instances reachable from this field" > Is there a difference between these two? > In addition, I think that -1 / 0 as a default might be better than 1 it terms of performance, because tracking such cycles has some overhead, which we might not want to pay for most fields in which this feature is not needed (and MaxFetchDepth is sufficient). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira