db-jdo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Bouschen (JIRA)" <j...@apache.org>
Subject [jira] Updated: (JDO-394) org.apache.jdo.tck.api.persistencemanagerfactory.GetPersistenceManager.test() and org.apache.jdo.tck.api.persistencemanagerfactory.GetPersistenceManagerForUser.test() don't close PMF correctly
Date Sun, 06 Aug 2006 11:45:14 GMT
     [ http://issues.apache.org/jira/browse/JDO-394?page=all ]

Michael Bouschen updated JDO-394:
---------------------------------

    Attachment: JDO-394-2.patch

Attached you find a new patch (JDO-394-2.patch) for review.

The new patch fixes a problem I overlooked before: the old code creates a new PMF as part
of the test method, but the setUp method 
already created a PMF. This patch fixes this problem. It also makes sure that an existing
PMF is closed, that might have been left open from a previous test. The test cases testing
PMF setter method cannot use the getPMF method as implemented in the test super class JDO_Test,
because this returns a non-configurable PMF.

> org.apache.jdo.tck.api.persistencemanagerfactory.GetPersistenceManager.test() and org.apache.jdo.tck.api.persistencemanagerfactory.GetPersistenceManagerForUser.test()
don't close PMF correctly
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: JDO-394
>                 URL: http://issues.apache.org/jira/browse/JDO-394
>             Project: JDO
>          Issue Type: Bug
>          Components: tck20
>    Affects Versions: JDO 2 final
>            Reporter: Christian Ernst
>         Assigned To: Michael Bouschen
>            Priority: Minor
>             Fix For: JDO 2 maintenance release 1
>
>         Attachments: JDO-394-2.patch, JDO-394.patch
>
>
> org.apache.jdo.tck.api.persistencemanagerfactory.GetPersistenceManager.test() and 
> org.apache.jdo.tck.api.persistencemanagerfactory.GetPersistenceManagerForUser.test()

> don't close PMF correctly and this can cause other Testcases to fail 
> Following should be added to the finally block of each test()  Method
> if (pmf != null) pmf.close(); 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message