db-jdo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erik Bengtson (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JDO-402) checkRemoveGroup - removeGroup should be before getGroups
Date Sun, 06 Aug 2006 09:45:14 GMT
    [ http://issues.apache.org/jira/browse/JDO-402?page=comments#action_12426048 ] 
            
Erik Bengtson commented on JDO-402:
-----------------------------------

It was implicitly understood that the returned Set is immutable because the underlying Set
is a reference. If the underlying set is a copy, it does not make sense to be immutable.

Anyway, I dont have any problem if it's changed to copy. In this case, making the returned
set mutable is better for usability.

> checkRemoveGroup - removeGroup should be before getGroups
> ---------------------------------------------------------
>
>                 Key: JDO-402
>                 URL: http://issues.apache.org/jira/browse/JDO-402
>             Project: JDO
>          Issue Type: Bug
>          Components: tck20
>    Affects Versions: JDO 2 final
>            Reporter: Ilan Kirsh
>         Assigned To: Craig Russell
>             Fix For: JDO 2 maintenance release 1
>
>         Attachments: JDO-402.patch
>
>
> In org.apache.jdo.tck.api.persistencemanager.fetchplan.FetchPlanInterface, lines 281-282,
> it probably has to be:
>         fp.removeGroup("default");
>         Collection groups = fp.getGroups();
> Instead of:
>         Collection groups = fp.getGroups();
>         fp.removeGroup("default");

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message