db-jdo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Bouschen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JDO-382) Add test for selecting and updating an embedded field
Date Fri, 23 Jun 2006 19:10:30 GMT
    [ http://issues.apache.org/jira/browse/JDO-382?page=comments#action_12417549 ] 

Michael Bouschen commented on JDO-382:
--------------------------------------

Looks good. A few comments:

- Please break the long line in the class javadoc comment.
- Would it make sense to make method getPersistentNewInstance private?
- The following comment might be confusing because the modification is not stored in teh database.
  // Select address/date, modify, and persist 
- Both test methods testEmbeddedField and testDateField execute the same query twice. There
is no need to call pm.newQuery again and specify exactly the same query. You can just call
query.execute after staring the third transaction.

> Add test for selecting and updating an embedded field
> -----------------------------------------------------
>
>          Key: JDO-382
>          URL: http://issues.apache.org/jira/browse/JDO-382
>      Project: JDO
>         Type: Test

>   Components: tck20
>     Versions: JDO 2 final
>     Reporter: Craig Russell
>     Assignee: Michelle Caisse
>      Fix For: JDO 2 maintenance release 1
>  Attachments: JDO-382.patch, ProjectedSCODoesNotTrackChanges.java
>
> If you select an embedded field and change it, we need to verify that the object has
changed. 
> Currently no test exists for this case.
> Select Address from Employee where name.startsWith('Michael')
> address.zip = "94040";
> tx.commit();
> verify that address.zip has been changed in the database.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message