db-jdo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Craig Russell (JIRA)" <j...@apache.org>
Subject [jira] Updated: (JDO-377) Company model factory improvements to test persistent interfaces
Date Mon, 01 May 2006 18:04:47 GMT
     [ http://issues.apache.org/jira/browse/JDO-377?page=all ]

Craig Russell updated JDO-377:
------------------------------

    Fix Version: JDO 2 maintenance release 1
                     (was: JDO 2 final)

Thanks for continuing to improve the test.

I think that the new test is valuable but needs a bit more work to make sure the comments
are clean and the structure is correct. In particular, the list of allInstances only includes
instances that have a managed extent (excludes Address). This inappropriately ties the factory
to the usage in the configurations (e.g. another configuration might have the Address require
an extent, or might instantiate a Person). 

The LifecycleCompleteness has an awkward name and there is only one JUnit-visible test method
with several sub-tests. The sub-test pattern is useful but we need to rationalize the naming
convention for sub-tests. This was done to avoid setup and teardown of the persistent instances
but the ramification is that the individual tests cannot be excluded if there is some issue.
Perhaps we can modify the exclude list to include not only class name but test name as well.

So I think we should continue to work on this after the release of JDO 2.


> Company model factory improvements to test persistent interfaces
> ----------------------------------------------------------------
>
>          Key: JDO-377
>          URL: http://issues.apache.org/jira/browse/JDO-377
>      Project: JDO
>         Type: Improvement

>   Components: tck20
>     Versions: JDO 2 rc1
>     Reporter: Craig Russell
>     Priority: Minor
>      Fix For: JDO 2 maintenance release 1
>  Attachments: JDO-377-mbo.patch, JDO-377.patch, LifecycleCompleteness.java, lifecyclecompleteness.conf
>
> Please review this patch.
> In order to test persistent interfaces better, a method was added to the CompanyFactory
interface to allow the test program to get the persistent instances. 
> List getAllInstances();
> To implement this new API, changes were made to the factory implementation classes to
keep track of instances as they were created.
> Additionally, only classes (or interfaces) actually instantiated were put into the tearDown
class array. So Person.class and Employee.class were removed from the array.
> Finally, a bug was fixed in CompanyFactoryPMClass where the interface IMedicalInsurance.class
was incorrectly added to the tearDown class array.
> A new test class was used for testing. This class might be added to the TCK if suitable.
> And a new configuration was used for testing. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message