Return-Path: Delivered-To: apmail-db-jdo-dev-archive@www.apache.org Received: (qmail 76379 invoked from network); 22 Apr 2006 19:49:37 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 22 Apr 2006 19:49:37 -0000 Received: (qmail 8054 invoked by uid 500); 22 Apr 2006 19:49:37 -0000 Mailing-List: contact jdo-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jdo-dev@db.apache.org Delivered-To: mailing list jdo-dev@db.apache.org Received: (qmail 7994 invoked by uid 99); 22 Apr 2006 19:49:37 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 22 Apr 2006 12:49:37 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [209.237.227.198] (HELO brutus.apache.org) (209.237.227.198) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 22 Apr 2006 12:49:36 -0700 Received: from brutus (localhost.localdomain [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 18A5741000E for ; Sat, 22 Apr 2006 19:48:21 +0000 (GMT) Message-ID: <7276356.1145735301092.JavaMail.jira@brutus> Date: Sat, 22 Apr 2006 19:48:21 +0000 (GMT+00:00) From: "Michael Bouschen (JIRA)" To: jdo-dev@db.apache.org Subject: [jira] Closed: (JDO-109) Need better information about why two object graphs did not compare equal MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N [ http://issues.apache.org/jira/browse/JDO-109?page=all ] Michael Bouschen closed JDO-109: -------------------------------- Fix Version: JDO 2 beta Resolution: Fixed > Need better information about why two object graphs did not compare equal > ------------------------------------------------------------------------- > > Key: JDO-109 > URL: http://issues.apache.org/jira/browse/JDO-109 > Project: JDO > Type: Improvement > Components: tck20 > Environment: TCK > Reporter: Craig Russell > Assignee: Craig Russell > Priority: Minor > Fix For: JDO 2 beta > > Need better reporting of deep equality failures. > During completeness testing, if two object graphs are compared and the result is that they are different, there needs to be more information about exactly what is different between the object graphs. > The methods in each class deepCompareFields need to be changed to call into the EqualityHelper to do the comparisons and the EqualityHelper can report inequalities if the fields don't compare. During the comparison process, all fields need to be compared, and the results of compare need to be recorded by EqualityHelper. After the comparison of the graph, the collected information can be dumped if the results are "not equal". > New methods in EqualityHelper that take a String tell which fields of which class are being compared. Each of the equals(o1, o2) and closeEnough(o1, o2) methods need to be expanded to include a third parameter which tells which field is being compared. If the result is unequal, then the field information is saved in a StringBuffer to be returned if the result of the entire comparison is "not equal". -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira