Return-Path: Delivered-To: apmail-db-jdo-dev-archive@www.apache.org Received: (qmail 49945 invoked from network); 18 Apr 2006 16:23:22 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 18 Apr 2006 16:23:22 -0000 Received: (qmail 71823 invoked by uid 500); 18 Apr 2006 16:23:22 -0000 Mailing-List: contact jdo-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jdo-dev@db.apache.org Delivered-To: mailing list jdo-dev@db.apache.org Received: (qmail 71812 invoked by uid 99); 18 Apr 2006 16:23:21 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Apr 2006 09:23:21 -0700 X-ASF-Spam-Status: No, hits=0.9 required=10.0 tests=HTML_10_20,HTML_MESSAGE,SPF_HELO_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [80.67.18.15] (HELO smtprelay03.ispgateway.de) (80.67.18.15) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Apr 2006 09:23:19 -0700 Received: (qmail 28784 invoked from network); 18 Apr 2006 16:22:56 -0000 Received: from unknown (HELO [192.168.100.11]) (383542@[195.143.217.178]) (envelope-sender ) by smtprelay03.ispgateway.de (qmail-ldap-1.03) with SMTP for ; 18 Apr 2006 16:22:56 -0000 Message-ID: <44451262.9030709@artnology.com> Date: Tue, 18 Apr 2006 18:22:58 +0200 From: =?ISO-8859-1?Q?J=F6rg_von_Frantzius?= Organization: artnology GmbH, Berlin User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8) Gecko/20051201 Thunderbird/1.5 Mnenhy/0.7.3.0 MIME-Version: 1.0 To: jdo-dev@db.apache.org Subject: Re: [Fwd: last issue with completeness test] References: <4441B314.5050201@sun.com> In-Reply-To: Content-Type: multipart/mixed; boundary="------------050404040009090908060301" X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N --------------050404040009090908060301 Content-Type: multipart/alternative; boundary="------------020605090107000204070708" --------------020605090107000204070708 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Craig Russell schrieb: > Hi Erik, > > It's probably not related to the problem, but why do you declare an > index defined on the discriminator columns in the metadata? > Yes I'm not Erik but still: in our production system we do that to increase performance of queries. We'd even like to have that by default. > The only other odd thing is the change to projects: name="projects" mapped-by="members"/> > > There's nothing else that I can see that would cause a problem > deleting instances. Where does the error show up? > > Craig > > P.S. until Monday, please reply to papajdo@gmail.com in addition to jdo-dev. > > On 4/15/06, Michelle Caisse wrote: > >> -------- Original Message -------- >> Subject: last issue with completeness test >> Date: Sat, 15 Apr 2006 18:51:11 -0700 >> From: Erik Bengtson >> Reply-To: jdo-dev@db.apache.org >> To: jdo-dev@db.apache.org >> >> Hi, >> >> JPOX now passes completeness interface test in my local workspace, but >> apparently the tables are not cleaned out completely on tear down. It passes >> if >> it is the only configuration enabled. Can someone take a look on that? >> >> Here my changes to the schema and metadata files adding discriminator column >> to >> tables. >> >> Index: >> D:/jdo/trunk/tck20/src/sql/derby/datastoreidentity/schema.sql >> =================================================================== >> --- >> D:/jdo/trunk/tck20/src/sql/derby/datastoreidentity/schema.sql >> (revision >> 391636) >> +++ >> D:/jdo/trunk/tck20/src/sql/derby/datastoreidentity/schema.sql >> (working copy) >> @@ -130,6 +130,7 @@ >> STATE CHAR(2), >> ZIPCODE CHAR(5), >> COUNTRY VARCHAR(64), >> + DISCRIMINATOR VARCHAR(255), >> CONSTRAINT COMPS_PK PRIMARY KEY (DATASTORE_IDENTITY) >> ); >> >> @@ -139,6 +140,7 @@ >> NAME VARCHAR(32) NOT NULL, >> EMP_OF_THE_MONTH INTEGER, >> COMPANYID INTEGER REFERENCES companies, >> + DISCRIMINATOR VARCHAR(255), >> CONSTRAINT DEPTS_PK PRIMARY KEY (DATASTORE_IDENTITY) >> ); >> >> @@ -185,6 +187,7 @@ >> PROJID INTEGER NOT NULL, >> NAME VARCHAR(32) NOT NULL, >> BUDGET DECIMAL(11,2) NOT NULL, >> + DISCRIMINATOR VARCHAR(255), >> CONSTRAINT PROJS_UK UNIQUE (PROJID), >> CONSTRAINT PROJS_PK PRIMARY KEY (DATASTORE_IDENTITY) >> ); >> Index: >> D:/jdo/trunk/tck20/src/sql/derby/applicationidentity/schema.sql >> =================================================================== >> --- >> D:/jdo/trunk/tck20/src/sql/derby/applicationidentity/schema.sql >> (revision >> 391636) >> +++ >> D:/jdo/trunk/tck20/src/sql/derby/applicationidentity/schema.sql >> (working >> copy) >> @@ -182,6 +182,7 @@ >> STATE CHAR(2), >> ZIPCODE CHAR(5), >> COUNTRY VARCHAR(64), >> + DISCRIMINATOR VARCHAR(255), >> CONSTRAINT COMPS_PK PRIMARY KEY (ID) >> ); >> >> @@ -190,6 +191,7 @@ >> NAME VARCHAR(32) NOT NULL, >> EMP_OF_THE_MONTH INTEGER, >> COMPANYID INTEGER REFERENCES companies, >> + DISCRIMINATOR VARCHAR(255), >> CONSTRAINT DEPTS_PK PRIMARY KEY (ID) >> ); >> >> @@ -232,6 +234,7 @@ >> PROJID INTEGER NOT NULL, >> NAME VARCHAR(32) NOT NULL, >> BUDGET DECIMAL(11,2) NOT NULL, >> + DISCRIMINATOR VARCHAR(255), >> CONSTRAINT PROJS_PK PRIMARY KEY (PROJID) >> ); >> >> Index: >> D:/jdo/trunk/tck20/src/orm/datastoreidentity/org/apache/jdo/tck/pc/company/package-standard.orm >> =================================================================== >> --- >> D:/jdo/trunk/tck20/src/orm/datastoreidentity/org/apache/jdo/tck/pc/company/package-standard.orm >> (revision >> 388908) >> +++ >> D:/jdo/trunk/tck20/src/orm/datastoreidentity/org/apache/jdo/tck/pc/company/package-standard.orm >> (working >> copy) >> @@ -11,6 +11,11 @@ >> >> >> > column="DATASTORE_IDENTITY"/> >> + >> + >> + >> + >> + >> >> >> >> @@ -43,6 +48,11 @@ >> >> >> > column="DATASTORE_IDENTITY"/> >> + >> + >> + >> + >> + >> >> >> >> @@ -149,6 +159,11 @@ >> >> >> > column="DATASTORE_IDENTITY"/> >> + >> + >> + >> + >> + >> >> >> >> @@ -168,6 +183,11 @@ >> >> >> > column="DATASTORE_IDENTITY"/> >> + >> + >> + >> + >> + >> >> >> >> @@ -188,6 +208,11 @@ >> >> >> > column="DATASTORE_IDENTITY"/> >> + >> + >> + >> + >> + >> >> >> >> @@ -306,6 +331,11 @@ >> >> >> > column="DATASTORE_IDENTITY"/> >> + >> + >> + >> + >> + >> >> >> >> Index: >> D:/jdo/trunk/tck20/src/orm/applicationidentity/org/apache/jdo/tck/pc/company/package-standard.orm >> =================================================================== >> --- >> D:/jdo/trunk/tck20/src/orm/applicationidentity/org/apache/jdo/tck/pc/company/package-standard.orm >> (revision >> 388908) >> +++ >> D:/jdo/trunk/tck20/src/orm/applicationidentity/org/apache/jdo/tck/pc/company/package-standard.orm >> (working >> copy) >> @@ -10,6 +10,11 @@ >> >> >> >> + >> + >> + >> + >> + >> >> >> >> @@ -29,6 +34,11 @@ >> >> >> >> + >> + >> + >> + >> + >> >> >> >> @@ -144,6 +154,11 @@ >> >> >> >> + >> + >> + >> + >> + >> >> >> >> @@ -164,6 +179,11 @@ >> >> >> >> + >> + >> + >> + >> + >> >> >> >> @@ -183,6 +203,11 @@ >> >> >> >> + >> + >> + >> + >> + >> >> >> >> @@ -224,8 +249,7 @@ >> >> >> >> - >> - >> + > mapped-by="members"/> >> >> >> >> @@ -298,6 +322,11 @@ >> >> >> >> + >> + >> + >> + >> + >> >> >> >> >> >> >> > > > --------------020605090107000204070708 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Craig Russell schrieb:

Hi Erik,

It's probably not related to the problem, but why do you declare an
index defined on the discriminator columns in the metadata?

Yes I'm not Erik but still: in our production system we do that to increase performance of queries. We'd even like to have that by default.

The only other odd thing is the change to projects: <property
name="projects" mapped-by="members"/>

There's nothing else that I can see that would cause a problem
deleting instances. Where does the error show up?

Craig

P.S. until Monday, please reply to papajdo@gmail.com in addition to jdo-dev.

On 4/15/06, Michelle Caisse <Michelle.Caisse@sun.com> wrote:

 -------- Original Message --------
Subject: last issue with completeness test
Date: Sat, 15 Apr 2006 18:51:11 -0700
From: Erik Bengtson <erik@jpox.org>
Reply-To: jdo-dev@db.apache.org
To: jdo-dev@db.apache.org

 Hi,

JPOX now passes completeness interface test in my local workspace, but
apparently the tables are not cleaned out completely on tear down. It passes
if
it is the only configuration enabled. Can someone take a look on that?

Here my changes to the schema and metadata files adding discriminator column
to
tables.

Index:
D:/jdo/trunk/tck20/src/sql/derby/datastoreidentity/schema.sql
===================================================================
---
D:/jdo/trunk/tck20/src/sql/derby/datastoreidentity/schema.sql
(revision
391636)
+++
D:/jdo/trunk/tck20/src/sql/derby/datastoreidentity/schema.sql
(working copy)
@@ -130,6 +130,7 @@
 STATE CHAR(2),
 ZIPCODE CHAR(5),
 COUNTRY VARCHAR(64),
+ DISCRIMINATOR VARCHAR(255),
 CONSTRAINT COMPS_PK PRIMARY KEY (DATASTORE_IDENTITY)
 );

@@ -139,6 +140,7 @@
 NAME VARCHAR(32) NOT NULL,
 EMP_OF_THE_MONTH INTEGER,
 COMPANYID INTEGER REFERENCES companies,
+ DISCRIMINATOR VARCHAR(255),
 CONSTRAINT DEPTS_PK PRIMARY KEY (DATASTORE_IDENTITY)
 );

@@ -185,6 +187,7 @@
 PROJID INTEGER NOT NULL,
 NAME VARCHAR(32) NOT NULL,
 BUDGET DECIMAL(11,2) NOT NULL,
+ DISCRIMINATOR VARCHAR(255),
 CONSTRAINT PROJS_UK UNIQUE (PROJID),
 CONSTRAINT PROJS_PK PRIMARY KEY (DATASTORE_IDENTITY)
 );
Index:
D:/jdo/trunk/tck20/src/sql/derby/applicationidentity/schema.sql
===================================================================
---
D:/jdo/trunk/tck20/src/sql/derby/applicationidentity/schema.sql
(revision
391636)
+++
D:/jdo/trunk/tck20/src/sql/derby/applicationidentity/schema.sql
(working
copy)
@@ -182,6 +182,7 @@
 STATE CHAR(2),
 ZIPCODE CHAR(5),
 COUNTRY VARCHAR(64),
+ DISCRIMINATOR VARCHAR(255),
 CONSTRAINT COMPS_PK PRIMARY KEY (ID)
 );

@@ -190,6 +191,7 @@
 NAME VARCHAR(32) NOT NULL,
 EMP_OF_THE_MONTH INTEGER,
 COMPANYID INTEGER REFERENCES companies,
+ DISCRIMINATOR VARCHAR(255),
 CONSTRAINT DEPTS_PK PRIMARY KEY (ID)
 );

@@ -232,6 +234,7 @@
 PROJID INTEGER NOT NULL,
 NAME VARCHAR(32) NOT NULL,
 BUDGET DECIMAL(11,2) NOT NULL,
+ DISCRIMINATOR VARCHAR(255),
 CONSTRAINT PROJS_PK PRIMARY KEY (PROJID)
 );

Index:
D:/jdo/trunk/tck20/src/orm/datastoreidentity/org/apache/jdo/tck/pc/company/package-standard.orm
===================================================================
---
D:/jdo/trunk/tck20/src/orm/datastoreidentity/org/apache/jdo/tck/pc/company/package-standard.orm
(revision
388908)
+++
D:/jdo/trunk/tck20/src/orm/datastoreidentity/org/apache/jdo/tck/pc/company/package-standard.orm
(working
copy)
@@ -11,6 +11,11 @@

 <class name="Company" table="companies">
 <datastore-identity strategy="identity"
column="DATASTORE_IDENTITY"/>
+ <inheritance strategy="new-table">
+ <discriminator strategy="class-name" column="DISCRIMINATOR">
+ <index name="COM_DISCRIMINATOR_INDEX" unique="false"/>
+ </discriminator>
+ </inheritance>
 <field name="companyid" column="ID"/>
 <field name="name" column="NAME">
 <column name="NAME" sql-type="VARCHAR"/>
@@ -43,6 +48,11 @@

 <class name="Department" table="departments">
 <datastore-identity strategy="identity"
column="DATASTORE_IDENTITY"/>
+ <inheritance strategy="new-table">
+ <discriminator strategy="class-name" column="DISCRIMINATOR">
+ <index name="DPT_DISCRIMINATOR_INDEX" unique="false"/>
+ </discriminator>
+ </inheritance>
 <field name="deptid" column="ID"/>
 <field name="name" column="NAME"/>
 <field name="company" column="COMPANYID"/>
@@ -149,6 +159,11 @@

 <class name="Project" table="projects">
 <datastore-identity strategy="identity"
column="DATASTORE_IDENTITY"/>
+ <inheritance strategy="new-table">
+ <discriminator strategy="class-name" column="DISCRIMINATOR">
+ <index name="PRJ_DISCRIMINATOR_INDEX" unique="false"/>
+ </discriminator>
+ </inheritance>
 <field name="projid" column="PROJID"/>
 <field name="name" column="NAME"/>
 <field name="budget">
@@ -168,6 +183,11 @@

 <interface name="ICompany" table="companies">
 <datastore-identity strategy="identity"
column="DATASTORE_IDENTITY"/>
+ <inheritance strategy="new-table">
+ <discriminator strategy="class-name" column="DISCRIMINATOR">
+ <index name="COM_DISCRIMINATOR_INDEX" unique="false"/>
+ </discriminator>
+ </inheritance>
 <property name="companyid" column="ID"/>
 <property name="name" column="NAME">
 <column name="NAME" sql-type="VARCHAR"/>
@@ -188,6 +208,11 @@

 <interface name="IDepartment" table="departments">
 <datastore-identity strategy="identity"
column="DATASTORE_IDENTITY"/>
+ <inheritance strategy="new-table">
+ <discriminator strategy="class-name" column="DISCRIMINATOR">
+ <index name="DPT_DISCRIMINATOR_INDEX" unique="false"/>
+ </discriminator>
+ </inheritance>
 <property name="deptid" column="ID"/>
 <property name="name" column="NAME"/>
 <property name="company" column="COMPANYID"/>
@@ -306,6 +331,11 @@

 <interface name="IProject" table="projects">
 <datastore-identity strategy="identity"
column="DATASTORE_IDENTITY"/>
+ <inheritance strategy="new-table">
+ <discriminator strategy="class-name" column="DISCRIMINATOR">
+ <index name="PRJ_DISCRIMINATOR_INDEX" unique="false"/>
+ </discriminator>
+ </inheritance>
 <property name="projid" column="PROJID"/>
 <property name="name" column="NAME"/>
 <property name="budget">
Index:
D:/jdo/trunk/tck20/src/orm/applicationidentity/org/apache/jdo/tck/pc/company/package-standard.orm
===================================================================
---
D:/jdo/trunk/tck20/src/orm/applicationidentity/org/apache/jdo/tck/pc/company/package-standard.orm
(revision
388908)
+++
D:/jdo/trunk/tck20/src/orm/applicationidentity/org/apache/jdo/tck/pc/company/package-standard.orm
(working
copy)
@@ -10,6 +10,11 @@
 <package name="org.apache.jdo.tck.pc.company">

 <class name="Company" table="companies">
+ <inheritance strategy="new-table">
+ <discriminator strategy="class-name" column="DISCRIMINATOR">
+ <index name="COM_DISCRIMINATOR_INDEX" unique="false"/>
+ </discriminator>
+ </inheritance>
 <field name="companyid" column="ID"/>
 <field name="name" column="NAME">
 <column name="NAME" sql-type="VARCHAR"/>
@@ -29,6 +34,11 @@
 </class>

 <class name="Department" table="departments">
+ <inheritance strategy="new-table">
+ <discriminator strategy="class-name" column="DISCRIMINATOR">
+ <index name="DPT_DISCRIMINATOR_INDEX" unique="false"/>
+ </discriminator>
+ </inheritance>
 <field name="deptid" column="ID"/>
 <field name="name" column="NAME"/>
 <field name="company" column="COMPANYID"/>
@@ -144,6 +154,11 @@
 </class>

 <class name="Project" table="projects">
+ <inheritance strategy="new-table">
+ <discriminator strategy="class-name" column="DISCRIMINATOR">
+ <index name="PRJ_DISCRIMINATOR_INDEX" unique="false"/>
+ </discriminator>
+ </inheritance>
 <field name="projid" column="PROJID"/>
 <field name="name" column="NAME"/>
 <field name="budget">
@@ -164,6 +179,11 @@
 </class>

 <interface name="ICompany" table="companies">
+ <inheritance strategy="new-table">
+ <discriminator strategy="class-name" column="DISCRIMINATOR">
+ <index name="COM_DISCRIMINATOR_INDEX" unique="false"/>
+ </discriminator>
+ </inheritance>
 <property name="companyid" column="ID"/>
 <property name="name" column="NAME">
 <column name="NAME" sql-type="VARCHAR"/>
@@ -183,6 +203,11 @@
 </interface>

 <interface name="IDepartment" table="departments">
+ <inheritance strategy="new-table">
+ <discriminator strategy="class-name" column="DISCRIMINATOR">
+ <index name="DPT_DISCRIMINATOR_INDEX" unique="false"/>
+ </discriminator>
+ </inheritance>
 <property name="deptid" column="ID"/>
 <property name="name" column="NAME"/>
 <property name="company" column="COMPANYID"/>
@@ -224,8 +249,7 @@
 <foreign-key/>
 </property>
 <property name="reviewedProjects" mapped-by="reviewers">
- </property>
- <property name="projects" mapped-by="members"/>
+ </property> <property name="projects"
mapped-by="members"/>
 <property name="team" mapped-by="manager"/>
 <property name="hradvisees" mapped-by="hradvisor"/>
 </interface>
@@ -298,6 +322,11 @@
 </interface>

 <interface name="IProject" table="projects">
+ <inheritance strategy="new-table">
+ <discriminator strategy="class-name" column="DISCRIMINATOR">
+ <index name="PRJ_DISCRIMINATOR_INDEX" unique="false"/>
+ </discriminator>
+ </inheritance>
 <property name="projid" column="PROJID"/>
 <property name="name" column="NAME"/>
 <property name="budget">

--------------020605090107000204070708-- --------------050404040009090908060301--