Return-Path: Delivered-To: apmail-db-jdo-dev-archive@www.apache.org Received: (qmail 41187 invoked from network); 12 Mar 2006 16:33:11 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 12 Mar 2006 16:33:11 -0000 Received: (qmail 51405 invoked by uid 500); 12 Mar 2006 16:33:10 -0000 Mailing-List: contact jdo-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jdo-dev@db.apache.org Delivered-To: mailing list jdo-dev@db.apache.org Received: (qmail 51394 invoked by uid 99); 12 Mar 2006 16:33:10 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 12 Mar 2006 08:33:10 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=UNPARSEABLE_RELAY X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [192.18.98.31] (HELO brmea-mail-1.sun.com) (192.18.98.31) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 12 Mar 2006 08:33:10 -0800 Received: from fe-amer-05.sun.com ([192.18.108.179]) by brmea-mail-1.sun.com (8.12.10/8.12.9) with ESMTP id k2CGWnSD024146 for ; Sun, 12 Mar 2006 09:32:49 -0700 (MST) Received: from conversion-daemon.mail-amer.sun.com by mail-amer.sun.com (Sun Java System Messaging Server 6.2-4.02 (built Sep 9 2005)) id <0IW000A01VV6J300@mail-amer.sun.com> (original mail from Craig.Russell@Sun.COM) for jdo-dev@db.apache.org; Sun, 12 Mar 2006 09:32:48 -0700 (MST) Received: from [192.168.0.10] (c-24-6-172-77.hsd1.ca.comcast.net [24.6.172.77]) by mail-amer.sun.com (Sun Java System Messaging Server 6.2-4.02 (built Sep 9 2005)) with ESMTPSA id <0IW000HCWWMO2V00@mail-amer.sun.com> for jdo-dev@db.apache.org; Sun, 12 Mar 2006 09:32:48 -0700 (MST) Date: Sun, 12 Mar 2006 08:32:46 -0800 From: Craig L Russell Subject: Re: [jira] Commented: (JDO-191) Add test for PersistenceManager.getDataStoreConnection() In-reply-to: <383861126.1142127176771.JavaMail.jira@ajax> Sender: Craig.Russell@Sun.COM To: jdo-dev@db.apache.org Message-id: MIME-version: 1.0 X-Mailer: Apple Mail (2.746.2) Content-type: multipart/signed; protocol="application/pkcs7-signature"; boundary=Apple-Mail-122-665210255; micalg=sha1 References: <383861126.1142127176771.JavaMail.jira@ajax> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N --Apple-Mail-122-665210255 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Hi Andy, I looked at this and you are right. The JPOX implementation behaves correctly. I'll fix this today. Craig On Mar 11, 2006, at 5:32 PM, Andy Jefferson (JIRA) wrote: > [ http://issues.apache.org/jira/browse/JDO-191? > page=comments#action_12370040 ] > > Andy Jefferson commented on JDO-191: > ------------------------------------ > > You say that JPOX fails DataStoreConnectionThrows because it passes > a Connection directly instead of wrapping it. Can you please define > what you mean here ? JPOX returns a org.jpox.JDOConnectionImpl from > PM.getDataStoreConnection(). JDOConnectionImpl implements > java.sql.Connection, and javax.jdo.datastore.JDOConnection. This > does indeed wrap a (java.sql.)Connection. The test then proceeds to > call commit not on the JDOConnection but on the native connection > that it wraps. Are we saying that getNativeConnection() has to > return the wrapped connection ? The spec says nothing about the > returned object from getNativeConnection() wrapping a connection. > Can we have a clarification on what this test is actually checking. > >> Add test for PersistenceManager.getDataStoreConnection() >> -------------------------------------------------------- >> >> Key: JDO-191 >> URL: http://issues.apache.org/jira/browse/JDO-191 >> Project: JDO >> Type: Test >> Components: tck20 >> Versions: JDO 2 beta >> Environment: TCK >> Reporter: Craig Russell >> Fix For: JDO 2 final >> Attachments: DataStoreConnection.java, DataStoreConnection.java, >> DataStoreConnectionThrows.java >> >> A12.16-1 [JDOConnection getDataStoreConnection(); If this method >> is called while a datastore transaction is active, the object >> returned will be enlisted in the current transaction. If called in >> an optimistic transaction before flush has been called, or outside >> an active transaction, the object returned will not be enlisted in >> any transaction.]] >> The tests use the jdbc Connection. >> The test needs to work with the jdbc library from the standard JDK >> 1.3 (JDBC 2.0). > > -- > This message is automatically generated by JIRA. > - > If you think it was sent incorrectly contact one of the > administrators: > http://issues.apache.org/jira/secure/Administrators.jspa > - > For more information on JIRA, see: > http://www.atlassian.com/software/jira > Craig Russell Architect, Sun Java Enterprise System http://java.sun.com/products/jdo 408 276-5638 mailto:Craig.Russell@sun.com P.S. A good JDO? O, Gasp! --Apple-Mail-122-665210255 Content-Transfer-Encoding: base64 Content-Type: application/pkcs7-signature; name=smime.p7s Content-Disposition: attachment; filename=smime.p7s MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIGUDCCAwkw ggJyoAMCAQICEB7Y7fLHmKoeHTUdbtYrvpAwDQYJKoZIhvcNAQEEBQAwYjELMAkGA1UEBhMCWkEx JTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQ ZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBMB4XDTA1MTIxNTIxNDc0NFoXDTA2MTIxNTIxNDc0 NFowbDEQMA4GA1UEBBMHUnVzc2VsbDEUMBIGA1UEKhMLQ3JhaWcgTGFpcmQxHDAaBgNVBAMTE0Ny YWlnIExhaXJkIFJ1c3NlbGwxJDAiBgkqhkiG9w0BCQEWFUNyYWlnLlJ1c3NlbGxAU3VuLkNPTTCC ASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAMXXgEAm88nu8cFbxXSWqTq+GaYpCx/0QSom 8kBbVxpJIURuO4ErLDupeXu6y9+5e7ZKLbeSQE5xbfYPcQR/IhqmYKy5YqRcuzPXREBj2zKEkZph pNXWpHgMdx9W8dq0Cu2i9Ux/S6c2MuEHrP6gfGGll+b/mzLoO280QHTuE4pcpKntRnwZdGxQ/5l8 IL+eLP+jpJAbYW9C+KNKofZtS6V6R0uzlqTOsEdZvwxZQ4mmPgHoz1+Gjwme/PC5sKvF09MaJDiI pj9SvZ4CTCgcDZV78J086YwlVbMC0VQotjhu1p42lr8CS33IXLz3OWNrDETCAepah/Dgw2ZZApQ9 9L0CAwEAAaMyMDAwIAYDVR0RBBkwF4EVQ3JhaWcuUnVzc2VsbEBTdW4uQ09NMAwGA1UdEwEB/wQC MAAwDQYJKoZIhvcNAQEEBQADgYEAKdIkgAWCg2Bi7ocnstfJA4iymTRI2/L4oQx9zvllM9bNJ2cR cecJIx3HuoHbhPvemh1GExEPgHU+dXSxDmD0BEmPnhSReKCURyslnbMphPZ5kR6USzQFrRa+v0ii J+SBO9VQYTQWT+xEjmRLM76MfkBFw3IOC9CUkRoYZ88pOoUwggM/MIICqKADAgECAgENMA0GCSqG SIb3DQEBBQUAMIHRMQswCQYDVQQGEwJaQTEVMBMGA1UECBMMV2VzdGVybiBDYXBlMRIwEAYDVQQH EwlDYXBlIFRvd24xGjAYBgNVBAoTEVRoYXd0ZSBDb25zdWx0aW5nMSgwJgYDVQQLEx9DZXJ0aWZp Y2F0aW9uIFNlcnZpY2VzIERpdmlzaW9uMSQwIgYDVQQDExtUaGF3dGUgUGVyc29uYWwgRnJlZW1h aWwgQ0ExKzApBgkqhkiG9w0BCQEWHHBlcnNvbmFsLWZyZWVtYWlsQHRoYXd0ZS5jb20wHhcNMDMw NzE3MDAwMDAwWhcNMTMwNzE2MjM1OTU5WjBiMQswCQYDVQQGEwJaQTElMCMGA1UEChMcVGhhd3Rl IENvbnN1bHRpbmcgKFB0eSkgTHRkLjEsMCoGA1UEAxMjVGhhd3RlIFBlcnNvbmFsIEZyZWVtYWls IElzc3VpbmcgQ0EwgZ8wDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBAMSmPFVzVftOucqZWh5owHUE cJ3f6f+jHuy9zfVb8hp2vX8MOmHyv1HOAdTlUAow1wJjWiyJFXCO3cnwK4Vaqj9xVsuvPAsH5/Ef kTYkKhPPK9Xzgnc9A74r/rsYPge/QIACZNenprufZdHFKlSFD0gEf6e20TxhBEAeZBlyYLf7AgMB AAGjgZQwgZEwEgYDVR0TAQH/BAgwBgEB/wIBADBDBgNVHR8EPDA6MDigNqA0hjJodHRwOi8vY3Js LnRoYXd0ZS5jb20vVGhhd3RlUGVyc29uYWxGcmVlbWFpbENBLmNybDALBgNVHQ8EBAMCAQYwKQYD VR0RBCIwIKQeMBwxGjAYBgNVBAMTEVByaXZhdGVMYWJlbDItMTM4MA0GCSqGSIb3DQEBBQUAA4GB AEiM0VCD6gsuzA2jZqxnD3+vrL7CF6FDlpSdf0whuPg2H6otnzYvwPQcUCCTcDz9reFhYsPZOhl+ hLGZGwDFGguCdJ4lUJRix9sncVcljd2pnDmOjCBPZV+V2vf3h9bGCE6u9uo05RAaWzVNd+NWIXiC 3CEZNd4ksdMdRv9dX2VPMYIDEDCCAwwCAQEwdjBiMQswCQYDVQQGEwJaQTElMCMGA1UEChMcVGhh d3RlIENvbnN1bHRpbmcgKFB0eSkgTHRkLjEsMCoGA1UEAxMjVGhhd3RlIFBlcnNvbmFsIEZyZWVt YWlsIElzc3VpbmcgQ0ECEB7Y7fLHmKoeHTUdbtYrvpAwCQYFKw4DAhoFAKCCAW8wGAYJKoZIhvcN AQkDMQsGCSqGSIb3DQEHATAcBgkqhkiG9w0BCQUxDxcNMDYwMzEyMTYzMjQ3WjAjBgkqhkiG9w0B CQQxFgQU4qEJiZv37Tz3CdYayPauoTOdjxAwgYUGCSsGAQQBgjcQBDF4MHYwYjELMAkGA1UEBhMC WkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0 ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBAhAe2O3yx5iqHh01HW7WK76QMIGHBgsqhkiG 9w0BCRACCzF4oHYwYjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQ dHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBAhAe 2O3yx5iqHh01HW7WK76QMA0GCSqGSIb3DQEBAQUABIIBAHr2f8DyX9+WqQWEAFObrgAHNQwrw0IV vHXWJi7s5pKutea1AA+z3mLqAE+c9bdgohTyaDykaiOtWNbgEvT/zycMpmvDo//LeuUQ1414UPrK DEU9KKs5rpve1nUDlwYWljcJF/hCEiWKSdDIU36Zcz+DMPfr+7fS2CKGhrO71cypBlBFZeSHHP6g azUZUICniY1WIqcZzVB04a/PSWLwhXSIsw+ir4NUHDkcJKJb3B7xu6QindTZGWTkW0zqzSXX/F/w XYEclcSul1kaq8eYOXuGoSFsnV6mxk6tqIk3wEvisEJksEiVTCFxgv+2OpoyQ3GGc7ZxqA4iH+xK VmkGidAAAAAAAAA= --Apple-Mail-122-665210255--