Mailing-List: contact jdo-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jdo-dev@db.apache.org
Message-ID: <20708355.1142304521567.JavaMail.jira@ajax>
Date: Tue, 14 Mar 2006 02:48:41 +0000 (GMT)
From: "Martin Zaun (JIRA)" <jira@apache.org>
To: jdo-dev@db.apache.org
Subject: [jira] Updated: (JDO-299) Signature test needed checking compliance
 of implementations with JDO2.0 API
In-Reply-To: <1134851442.1139583836028.JavaMail.jira@ajax.apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

     [ http://issues.apache.org/jira/browse/JDO-299?page=all ]

Martin Zaun updated JDO-299:
----------------------------

    Attachment: api20_defs.txt

attached is an updated version of the API signature descriptor file.

> FetchPlan should verify the values of the static fields.

I updated the descriptor file for these constant field values:

public interface javax.jdo.FetchPlan:
    public static final String DEFAULT = "default";
    public static final String ALL = "all";
    public static final int DETACH_UNLOAD_FIELDS = 2;
    public static final int DETACH_LOAD_FIELDS = 1;
    public static final int FETCH_SIZE_GREEDY = -1;
    public static final int FETCH_SIZE_OPTIMAL = 0;

public class javax.jdo.listener.InstanceLifecycleEvent:
    public static final int CREATE = 0;
    public static final int LOAD = 1;
    public static final int STORE = 2;
    public static final int CLEAR = 3;
    public static final int DELETE = 4;
    public static final int DIRTY = 5;
    public static final int DETACH = 6;
    public static final int ATTACH = 7;

public interface javax.jdo.Query:
    public static final String JDOQL = "javax.jdo.query.JDOQL";
    public static final String SQL = "javax.jdo.query.SQL";

public interface javax.jdo.spi.PersistenceCapable:
    public static final byte READ_WRITE_OK = 0;
    public static final byte LOAD_REQUIRED = 1;
    public static final byte READ_OK = -1;
    public static final byte CHECK_READ = 1;
    public static final byte MEDIATE_READ = 2;
    public static final byte CHECK_WRITE = 4;
    public static final byte MEDIATE_WRITE = 8;
    public static final byte SERIALIZABLE = 16;

There are 4 public static fields in JDOPermission for which I cannot (easily)
add constant definitions (not literals).  But perhaps they don't belong into
the descriptor file anyway (they're not mentioned in the spec):

public final class javax.jdo.spi.JDOPermission:
    public static final javax.jdo.spi.JDOPermission GET_METADATA;
    public static final javax.jdo.spi.JDOPermission MANAGE_METADATA;
    public static final javax.jdo.spi.JDOPermission SET_STATE_MANAGER;
    public static final javax.jdo.spi.JDOPermission CLOSE_PERSISTENCE_MANAGER_FACTORY;

> Do you intend to test the "implements" clause of the interfaces?

I'm testing the 'extends' clause for interfaces (they cannot have 'implements',
which is also tested).

> In general, I think we should not verify protected or private methods.

I've removed all protected declarations from the descriptor file.

> Reviewed up to but not including InstanceCallbacks.

Thx, so far.

> Signature test needed checking compliance of implementations with JDO2.0 API
> ----------------------------------------------------------------------------
>
>          Key: JDO-299
>          URL: http://issues.apache.org/jira/browse/JDO-299
>      Project: JDO
>         Type: Task
>   Components: tck20
>     Reporter: Martin Zaun
>     Assignee: Martin Zaun
>     Priority: Minor
>      Fix For: JDO 2 final
>  Attachments: api20_defs.txt
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira