Mailing-List: contact jdo-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jdo-dev@db.apache.org
Message-ID: <1016129720.1142482680615.JavaMail.jira@ajax>
Date: Thu, 16 Mar 2006 04:18:00 +0000 (GMT)
From: "Craig Russell (JIRA)" <jira@apache.org>
To: jdo-dev@db.apache.org
Subject: [jira] Commented: (JDO-299) Signature test needed checking
 compliance of implementations with JDO2.0 API
In-Reply-To: <1134851442.1139583836028.JavaMail.jira@ajax.apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

    [ http://issues.apache.org/jira/browse/JDO-299?page=comments#action_12370637 ] 

Craig Russell commented on JDO-299:
-----------------------------------

The patch contains the maven.xml patch twice. I assume that the project.properties actually sets the value of the signaturetest file?

The signature.conf has the wrong description.

Is there a way to only run the signature test once, since it's no value to run with both app identity and ds identitiy.

SignatureTest comment need not refer to JDO 2.0, as it's generic. When we update the spec to e.g. 2.0.1 or 2.1, we won't need to change this class, but just update the reference signature file.

You might define an additional SignatureTest constructor that has an explicit classloader argument. If not specified, the default is the classloader that you define here: classLoader = this.getClass().getClassLoader(). Then the comment "Tests the signature of classes (in the classpath) " would change to "Tests the signature of classes (in the specified classloader) ".

After you check this in, please file a JIRA on the three exceptions.

> Signature test needed checking compliance of implementations with JDO2.0 API
> ----------------------------------------------------------------------------
>
>          Key: JDO-299
>          URL: http://issues.apache.org/jira/browse/JDO-299
>      Project: JDO
>         Type: Task
>   Components: tck20
>     Reporter: Martin Zaun
>     Assignee: Martin Zaun
>     Priority: Minor
>      Fix For: JDO 2 final
>  Attachments: JUnitSignatureTest.java, SignatureTest.java, api20_defs.txt, signature_test_final_review.zip, sigtest.patch
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira