Hi Andy,
I looked at this and you are right. The JPOX implementation behaves
correctly. I'll fix this today.
Craig
On Mar 11, 2006, at 5:32 PM, Andy Jefferson (JIRA) wrote:
> [ http://issues.apache.org/jira/browse/JDO-191?
> page=comments#action_12370040 ]
>
> Andy Jefferson commented on JDO-191:
> ------------------------------------
>
> You say that JPOX fails DataStoreConnectionThrows because it passes
> a Connection directly instead of wrapping it. Can you please define
> what you mean here ? JPOX returns a org.jpox.JDOConnectionImpl from
> PM.getDataStoreConnection(). JDOConnectionImpl implements
> java.sql.Connection, and javax.jdo.datastore.JDOConnection. This
> does indeed wrap a (java.sql.)Connection. The test then proceeds to
> call commit not on the JDOConnection but on the native connection
> that it wraps. Are we saying that getNativeConnection() has to
> return the wrapped connection ? The spec says nothing about the
> returned object from getNativeConnection() wrapping a connection.
> Can we have a clarification on what this test is actually checking.
>
>> Add test for PersistenceManager.getDataStoreConnection()
>> --------------------------------------------------------
>>
>> Key: JDO-191
>> URL: http://issues.apache.org/jira/browse/JDO-191
>> Project: JDO
>> Type: Test
>> Components: tck20
>> Versions: JDO 2 beta
>> Environment: TCK
>> Reporter: Craig Russell
>> Fix For: JDO 2 final
>> Attachments: DataStoreConnection.java, DataStoreConnection.java,
>> DataStoreConnectionThrows.java
>>
>> A12.16-1 [JDOConnection getDataStoreConnection(); If this method
>> is called while a datastore transaction is active, the object
>> returned will be enlisted in the current transaction. If called in
>> an optimistic transaction before flush has been called, or outside
>> an active transaction, the object returned will not be enlisted in
>> any transaction.]]
>> The tests use the jdbc Connection.
>> The test needs to work with the jdbc library from the standard JDK
>> 1.3 (JDBC 2.0).
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the
> administrators:
> http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see:
> http://www.atlassian.com/software/jira
>
Craig Russell
Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
408 276-5638 mailto:Craig.Russell@sun.com
P.S. A good JDO? O, Gasp!
|