db-jdo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Bouschen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JDO-335) Close PMF after running each configuration
Date Mon, 13 Mar 2006 19:32:41 GMT
    [ http://issues.apache.org/jira/browse/JDO-335?page=comments#action_12370225 ] 

Michael Bouschen commented on JDO-335:
--------------------------------------

Well, JDO_Test calls closePMF during tearDown if the property closePMFAfterEachTest is set
to true.

I agree with Michael W's comment and propose to change the implementation to:

    /** Runs the specified test or test suite and closes the pmf. */
    public TestResult doRun(Test test) {
        TestResult result = null;
        try {
            result = doRun(test, false);
            JDO_Test.dumpSupportedOptions(LOG_DIRECTORY + "configuration");
        } finally {
            JDO_Test.closePMF();
        }
        return result;
    }


> Close PMF after running each configuration
> ------------------------------------------
>
>          Key: JDO-335
>          URL: http://issues.apache.org/jira/browse/JDO-335
>      Project: JDO
>         Type: Improvement
>   Components: tck20
>     Versions: JDO 2 rc1
>     Reporter: Michael Bouschen
>     Assignee: Michael Bouschen
>     Priority: Minor
>      Fix For: JDO 2 final
>  Attachments: JDO-335-2.patch, JDO-335.patch
>
> Today method tearDown (that is run at the end of each test method) closes the pmf. 
> The proposal is to keep the pmf open for the next test method and close it at the end
of running a configuration. That would allow to reuse resources bound to the pmf in multiple
test cases.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message