db-jdo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Craig Russell (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JDO-311) Inheritance3 : should check if the JDO implementation supports "javax.jdo.option.mapping.RelationSubclassTable"
Date Fri, 03 Mar 2006 02:58:44 GMT
    [ http://issues.apache.org/jira/browse/JDO-311?page=comments#action_12368638 ] 

Craig Russell commented on JDO-311:

Looks great! I like that you promoted isTestToBePerformed to JDO_Test.

Just two comments.

1. Please use xxx.patch as the attachment name. Using patch2 as the file type means that my
browser downloads the file (unknown type) and I have to find it and open it using a text editor.
The second patch can be named e.g. JDO-311-2.patch.

2. Lines often exceed 80 characters. No need to shorten existing lines but new/changed lines
should be cut at 80.

> Inheritance3 : should check if the JDO implementation supports "javax.jdo.option.mapping.RelationSubclassTable"
> ---------------------------------------------------------------------------------------------------------------
>          Key: JDO-311
>          URL: http://issues.apache.org/jira/browse/JDO-311
>      Project: JDO
>         Type: Bug
>   Components: tck20
>     Versions: JDO 2 beta
>     Reporter: Andy Jefferson
>     Assignee: Michael Watzek
>      Fix For: JDO 2 final
>  Attachments: JDO-311.patch, JDO-311.patch2
> The inheritance3 test should check whether PMF.supportedOptions contains "javax.jdo.option.mapping.RelationSubclassTable"
before running the test. JPOX doesn't support this option yet the test still runs (and fails)

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
For more information on JIRA, see:

View raw message