db-jdo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Bouschen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JDO-309) minor extensions to tck20's JDO_Test and ThreadExceptionHandler
Date Tue, 07 Mar 2006 22:41:39 GMT
    [ http://issues.apache.org/jira/browse/JDO-309?page=comments#action_12369322 ] 

Michael Bouschen commented on JDO-309:
--------------------------------------

Hi Martin,

the ThreadExceptionHandler changes look good.

I looked at the RougueBarriere class. It's small, but still takes some time to understand
(at least for me :-)). Maybe you can add some comments motivating why we need a holder for
the boolean tripped. I think this allows other threads to see that the barrier is tripped,
but the current thread can prepare the value for the next run. Maybe you can also rearrange
the code in the await method executed when the barrier is reset. I think 
    tripped[0] = true;
    lock.notifyAll();
is needed to wake up the other threads, where
    missing = parties;
    tripped = new boolean[1]; // new generation
is used to initialized the next run. 

Am I right?

Michael

> minor extensions to tck20's JDO_Test and ThreadExceptionHandler
> ---------------------------------------------------------------
>
>          Key: JDO-309
>          URL: http://issues.apache.org/jira/browse/JDO-309
>      Project: JDO
>         Type: New Feature
>   Components: tck20
>     Reporter: Martin Zaun
>     Assignee: Martin Zaun
>     Priority: Trivial
>  Attachments: RogueBarrier.java
>
> JDO_Test should be extended for methods collection error messages.
> ThreadExceptionHandler should be extended for clearing stored exceptions.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message