Return-Path: Delivered-To: apmail-db-jdo-dev-archive@www.apache.org Received: (qmail 10582 invoked from network); 21 Feb 2006 21:49:29 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 21 Feb 2006 21:49:29 -0000 Received: (qmail 8262 invoked by uid 500); 21 Feb 2006 21:49:28 -0000 Mailing-List: contact jdo-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jdo-dev@db.apache.org Delivered-To: mailing list jdo-dev@db.apache.org Received: (qmail 8251 invoked by uid 99); 21 Feb 2006 21:49:28 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Feb 2006 13:49:28 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=UNPARSEABLE_RELAY X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [192.18.98.34] (HELO brmea-mail-3.sun.com) (192.18.98.34) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Feb 2006 13:49:27 -0800 Received: from fe-amer-06.sun.com ([192.18.108.180]) by brmea-mail-3.sun.com (8.12.10/8.12.9) with ESMTP id k1LLn7Qj004843 for ; Tue, 21 Feb 2006 14:49:07 -0700 (MST) Received: from conversion-daemon.mail-amer.sun.com by mail-amer.sun.com (Sun Java System Messaging Server 6.2-4.02 (built Sep 9 2005)) id <0IV200M014I0JU00@mail-amer.sun.com> (original mail from Craig.Russell@Sun.COM) for jdo-dev@db.apache.org; Tue, 21 Feb 2006 14:49:07 -0700 (MST) Received: from [10.81.12.101] ([216.76.76.143]) by mail-amer.sun.com (Sun Java System Messaging Server 6.2-4.02 (built Sep 9 2005)) with ESMTPSA id <0IV200EA94LUQ850@mail-amer.sun.com> for jdo-dev@db.apache.org; Tue, 21 Feb 2006 14:49:07 -0700 (MST) Date: Tue, 21 Feb 2006 13:49:07 -0800 From: Craig L Russell Subject: Re: jdo.dtd changes In-reply-to: <43FB8756.6040004@spree.de> Sender: Craig.Russell@Sun.COM To: jdo-dev@db.apache.org Message-id: <60CD965B-DF37-4536-ADE2-13B3EE07E403@Sun.COM> MIME-version: 1.0 X-Mailer: Apple Mail (2.746.2) Content-type: multipart/signed; protocol="application/pkcs7-signature"; boundary=Apple-Mail-130--957409745; micalg=sha1 References: <6BAD7096-9AB5-4673-8CE2-CD58ECBA72F4@Sun.COM> <43F8B892.6000705@spree.de> <43F8D5AE.9040206@spree.de> <44A4E5ED-57C7-4C82-B687-988D512B96C2@Sun.COM> <43FA16BF.9040900@spree.de> <6FB78918-19AA-408D-9488-12271F0EEFE7@Sun.COM> <43FAE518.80202@spree.de> <984C015F-A658-4FE7-A329-E45933E80CE5@Sun.COM> <43FB4FD8.6010002@spree.de> <32625FCB-E11B-4289-B1D0-31158574D9AB@Sun.COM> <43FB8756.6040004@spree.de> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N --Apple-Mail-130--957409745 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Hi Michael, Looks good. Craig On Feb 21, 2006, at 1:34 PM, Michael Bouschen wrote: > Hi Craig, > > I rearranged the elements in orm.dtd to use the same order as in > jdo.dtd and found a couple of inconsistencies between orm.dtd and > jdo.dtd. The attached patch changes the orm.dtd to match the > elements as defined in jdo.dtd: > - Added subelement 'property' to element 'class'. > - Changed attribute 'strategy' in the element 'version' from > REQUIRED to IMPLIED. > - Fixed 'implement' subelements. > - Fixed order of subelements in elements 'inheritance'. > - Restricted the values of attribute 'primary-key' in element 'field'. > > Please have a look at the patch. If there are no objections I would > check in the patch and change orm.xsd accordingly. > > Regards Michael > >> Hi Michael, >> >> On Feb 21, 2006, at 9:37 AM, Michael Bouschen wrote: >> >>> Hi Craig, >>> >>> [...] >>> >>>>>> Just one comment. There is no meaning to the order of >>>>>> attributes, just order of elements. But there's no issue >>>>>> with fixing the order of the attributes either. >>>>> >>>>> >>>>> >>>>> I know the order of attributes is not important, but it helps >>>>> when comparing the jdo.dtd and the orm.dtd to make sure the >>>>> orm dtd accepts a subset of the jdo metatdata :-). Try 'diff >>>>> jdo.dtd orm.dtd', I was surprised to see how many differences >>>>> there are. >>>> >>>> Good grief. Some of these are line ending differences. :-( >>> >>> >>> I could not find any ^M problems in the files. I think the diffs >>> are because the orm.dtd lists the elements in a different order, >>> e.g. jdo.dtd lists the element property between interface and >>> class, where orm.dtd lists it between column and field. This >>> does not affect the accepted XML, it just makes a comparison >>> between the two dtds harder. >> >> >> Not ^M differences, but spaces (I think). I just looked at it >> again and I can't account for some of the diffs at all. >> >> But the main point is: good. Thanks for changing the files so >> they are as similar as possible. It will make it easier for us. >> >>> >>>>> >>>>> Other question: do we want to rename api20/src/dtd to api20/ >>>>> src/ schema? >>>> >>>> +1 We need to make sure that the corresponding changes are made >>>> to the maven definitions, but I think it's time. >>> >>> >>> OK, I can work on this, but I would like to check in a first >>> version of the schema validation test before doing this rename. >>> I attached a new patch to JDO-202. >> >> >> Cool. I just looked at your 0220 patch and I think it's time to >> check these files in. >> >> Craig >> >>> >>> Regards Michael >>> >>> [...] >>> -- >>> Michael Bouschen Tech@Spree Engineering GmbH >>> mailto:mbo.tech@spree.de http://www.tech.spree.de/ >>> Tel.:++49/30/235 520-33 Buelowstr. 66 Fax.:+ >>> +49/30/2175 2012 D-10783 Berlin >> >> >> Craig Russell >> Architect, Sun Java Enterprise System http://java.sun.com/products/ >> jdo >> 408 276-5638 mailto:Craig.Russell@sun.com >> P.S. A good JDO? O, Gasp! >> > > > -- > Michael Bouschen Tech@Spree Engineering GmbH > mailto:mbo.tech@spree.de http://www.tech.spree.de/ > Tel.:++49/30/235 520-33 Buelowstr. 66 > Fax.:++49/30/2175 2012 D-10783 Berlin > > Index: src/dtd/javax/jdo/orm.dtd > =================================================================== > --- src/dtd/javax/jdo/orm.dtd (Revision 379573) > +++ src/dtd/javax/jdo/orm.dtd (Arbeitskopie) > @@ -19,7 +19,19 @@ > > > > - inheritance?, version?, join*, foreign-key*, index*, unique*, > column*, field*, query*, extension*)> > + value?, order?, column*, foreign-key?, index?, unique?, extension*)> > + > + > + > + > + > + > + none) #IMPLIED> > + > + > + > + > + inheritance?, version?, join*, foreign-key*, index*, unique*, > column*, field*, property*, query*, extension*)> > > > > @@ -37,20 +49,20 @@ > > > > + > + > + > + > + > > > > > > - > - > - > - > - > - > + > > > - extension*)> > + extension*)> > > > > @@ -71,23 +83,11 @@ > > > > - value?, order?, column*, foreign-key?, index?, unique?, extension*)> > - > - > - > - > - > - > - none) #IMPLIED> > - > - > - > - > value?, order?, column*, foreign-key?, index?, unique?, extension*)> > > > > - > + > > #IMPLIED> > > @@ -149,11 +149,6 @@ > > > > - extension*)> > - > - > - > - > > > > @@ -161,7 +156,13 @@ > > > > + extension*)> > + > + > + > + > > > > > + Craig Russell Architect, Sun Java Enterprise System http://java.sun.com/products/jdo 408 276-5638 mailto:Craig.Russell@sun.com P.S. A good JDO? O, Gasp! --Apple-Mail-130--957409745 Content-Transfer-Encoding: base64 Content-Type: application/pkcs7-signature; name=smime.p7s Content-Disposition: attachment; filename=smime.p7s MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIGUDCCAwkw ggJyoAMCAQICEB7Y7fLHmKoeHTUdbtYrvpAwDQYJKoZIhvcNAQEEBQAwYjELMAkGA1UEBhMCWkEx JTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQ ZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBMB4XDTA1MTIxNTIxNDc0NFoXDTA2MTIxNTIxNDc0 NFowbDEQMA4GA1UEBBMHUnVzc2VsbDEUMBIGA1UEKhMLQ3JhaWcgTGFpcmQxHDAaBgNVBAMTE0Ny YWlnIExhaXJkIFJ1c3NlbGwxJDAiBgkqhkiG9w0BCQEWFUNyYWlnLlJ1c3NlbGxAU3VuLkNPTTCC ASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAMXXgEAm88nu8cFbxXSWqTq+GaYpCx/0QSom 8kBbVxpJIURuO4ErLDupeXu6y9+5e7ZKLbeSQE5xbfYPcQR/IhqmYKy5YqRcuzPXREBj2zKEkZph pNXWpHgMdx9W8dq0Cu2i9Ux/S6c2MuEHrP6gfGGll+b/mzLoO280QHTuE4pcpKntRnwZdGxQ/5l8 IL+eLP+jpJAbYW9C+KNKofZtS6V6R0uzlqTOsEdZvwxZQ4mmPgHoz1+Gjwme/PC5sKvF09MaJDiI pj9SvZ4CTCgcDZV78J086YwlVbMC0VQotjhu1p42lr8CS33IXLz3OWNrDETCAepah/Dgw2ZZApQ9 9L0CAwEAAaMyMDAwIAYDVR0RBBkwF4EVQ3JhaWcuUnVzc2VsbEBTdW4uQ09NMAwGA1UdEwEB/wQC MAAwDQYJKoZIhvcNAQEEBQADgYEAKdIkgAWCg2Bi7ocnstfJA4iymTRI2/L4oQx9zvllM9bNJ2cR cecJIx3HuoHbhPvemh1GExEPgHU+dXSxDmD0BEmPnhSReKCURyslnbMphPZ5kR6USzQFrRa+v0ii J+SBO9VQYTQWT+xEjmRLM76MfkBFw3IOC9CUkRoYZ88pOoUwggM/MIICqKADAgECAgENMA0GCSqG SIb3DQEBBQUAMIHRMQswCQYDVQQGEwJaQTEVMBMGA1UECBMMV2VzdGVybiBDYXBlMRIwEAYDVQQH EwlDYXBlIFRvd24xGjAYBgNVBAoTEVRoYXd0ZSBDb25zdWx0aW5nMSgwJgYDVQQLEx9DZXJ0aWZp Y2F0aW9uIFNlcnZpY2VzIERpdmlzaW9uMSQwIgYDVQQDExtUaGF3dGUgUGVyc29uYWwgRnJlZW1h aWwgQ0ExKzApBgkqhkiG9w0BCQEWHHBlcnNvbmFsLWZyZWVtYWlsQHRoYXd0ZS5jb20wHhcNMDMw NzE3MDAwMDAwWhcNMTMwNzE2MjM1OTU5WjBiMQswCQYDVQQGEwJaQTElMCMGA1UEChMcVGhhd3Rl IENvbnN1bHRpbmcgKFB0eSkgTHRkLjEsMCoGA1UEAxMjVGhhd3RlIFBlcnNvbmFsIEZyZWVtYWls IElzc3VpbmcgQ0EwgZ8wDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBAMSmPFVzVftOucqZWh5owHUE cJ3f6f+jHuy9zfVb8hp2vX8MOmHyv1HOAdTlUAow1wJjWiyJFXCO3cnwK4Vaqj9xVsuvPAsH5/Ef kTYkKhPPK9Xzgnc9A74r/rsYPge/QIACZNenprufZdHFKlSFD0gEf6e20TxhBEAeZBlyYLf7AgMB AAGjgZQwgZEwEgYDVR0TAQH/BAgwBgEB/wIBADBDBgNVHR8EPDA6MDigNqA0hjJodHRwOi8vY3Js LnRoYXd0ZS5jb20vVGhhd3RlUGVyc29uYWxGcmVlbWFpbENBLmNybDALBgNVHQ8EBAMCAQYwKQYD VR0RBCIwIKQeMBwxGjAYBgNVBAMTEVByaXZhdGVMYWJlbDItMTM4MA0GCSqGSIb3DQEBBQUAA4GB AEiM0VCD6gsuzA2jZqxnD3+vrL7CF6FDlpSdf0whuPg2H6otnzYvwPQcUCCTcDz9reFhYsPZOhl+ hLGZGwDFGguCdJ4lUJRix9sncVcljd2pnDmOjCBPZV+V2vf3h9bGCE6u9uo05RAaWzVNd+NWIXiC 3CEZNd4ksdMdRv9dX2VPMYIDEDCCAwwCAQEwdjBiMQswCQYDVQQGEwJaQTElMCMGA1UEChMcVGhh d3RlIENvbnN1bHRpbmcgKFB0eSkgTHRkLjEsMCoGA1UEAxMjVGhhd3RlIFBlcnNvbmFsIEZyZWVt YWlsIElzc3VpbmcgQ0ECEB7Y7fLHmKoeHTUdbtYrvpAwCQYFKw4DAhoFAKCCAW8wGAYJKoZIhvcN AQkDMQsGCSqGSIb3DQEHATAcBgkqhkiG9w0BCQUxDxcNMDYwMjIxMjE0OTA3WjAjBgkqhkiG9w0B CQQxFgQU17HiyfelFfiSpWXAuFHrzpLWf7wwgYUGCSsGAQQBgjcQBDF4MHYwYjELMAkGA1UEBhMC WkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0 ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBAhAe2O3yx5iqHh01HW7WK76QMIGHBgsqhkiG 9w0BCRACCzF4oHYwYjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQ dHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBAhAe 2O3yx5iqHh01HW7WK76QMA0GCSqGSIb3DQEBAQUABIIBAJzznXz79YFZaV6CBWbN8llNmhto76VS BLTMtM27O0qFAl+gj0pkRRN90DmCcwIBjkwdkR5c0tSyxw+FipJJQc/IC4xsce7CGD1Bv3e6JnVk 5JiSaQQYQNbMGIsJBYWv5datSsROJpL24+uckR9SPn/9m3zwkdlX8aG3l98/E2mHNHy6cRNOZeI7 oln8PuxiitN1gjmZbrwCgmr1lrqPmOQ2VvyajTPQ/sMBS/uBlT5Mk+rJvQ0+iWITBW9XnVoF5D1n tG+JtBtb5oBT8iFibtkBbdabmCKy6neo4NIKR7WkMVQf30kwqr6/+yFQ89VpIVw097IxjaZv7YKQ tJzVBmAAAAAAAAA= --Apple-Mail-130--957409745--