Mailing-List: contact jdo-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jdo-dev@db.apache.org
Message-ID: <2044065687.1138897923811.JavaMail.jira@ajax.apache.org>
Date: Thu, 2 Feb 2006 17:32:03 +0100 (CET)
From: "Craig Russell (JIRA)" <jira@apache.org>
To: jdo-dev@db.apache.org
Subject: [jira] Commented: (JDO-286) Convert unnamed constraints to named
 constraints in company model
In-Reply-To: <1067501000.1138892883170.JavaMail.jira@ajax.apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

    [ http://issues.apache.org/jira/browse/JDO-286?page=comments#action_12364962 ] 

Craig Russell commented on JDO-286:
-----------------------------------

Looks good. A couple of comments.

1. You have some random changes not related to this JIRA issue in your workspace.

2. Could you change tabs to spaces? The indents are wrong for some of the sql, e.g.
+    CONSTRAINT EMPS_DEPARTMENT FOREIGN KEY (DEPARTMENT) 
+	REFERENCES departments (DATASTORE_IDENTITY),
+    CONSTRAINT EMPS_FUNDINGDEPT FOREIGN KEY (FUNDINGDEPT) 
+	REFERENCES departments (DATASTORE_IDENTITY),


> Convert unnamed constraints to named constraints in company model
> -----------------------------------------------------------------
>
>          Key: JDO-286
>          URL: http://issues.apache.org/jira/browse/JDO-286
>      Project: JDO
>         Type: Bug
>   Components: tck20
>     Reporter: Michelle Caisse
>     Assignee: Michelle Caisse
>     Priority: Minor
>  Attachments: constraint.patch
>
> Named constraints can assist in debugging.  Derby constraint numbering is uninformative.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira