db-jdo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Bouschen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JDO-304) Query failure should print the query that failed in addition to the expected and actual results
Date Sat, 11 Feb 2006 21:48:28 GMT
    [ http://issues.apache.org/jira/browse/JDO-304?page=comments#action_12366035 ] 

Michael Bouschen commented on JDO-304:
--------------------------------------

I like the idea of including the JDOQL query string into the error message. The patch QueryTest.patch
changes the signature of methods checkQueryResultWithOrder checkQueryResultWithoutOrder defined
in the query test superclass QueryTest. These methods are protected and a couple of test classes
directly call these methods. These classes fail to compile after applying the patch (I got
56 compile errors). Either we change all the callers or we restore the methods with the old
signature such that we have two overloaded versions of the methods. What do you think?

> Query failure should print the query that failed in addition to the expected and actual
results
> -----------------------------------------------------------------------------------------------
>
>          Key: JDO-304
>          URL: http://issues.apache.org/jira/browse/JDO-304
>      Project: JDO
>         Type: Improvement
>   Components: tck20
>     Versions: JDO 2 beta
>     Reporter: Craig Russell
>     Priority: Minor
>      Fix For: JDO 2 rc1
>  Attachments: QueryTest.patch
>
> The failure message doesn't contain the failing query:
>     [java] There were 2 failures:
>     [java] 1) testNoNavigation(org.apache.jdo.tck.query.result.VariableInResult)junit.framework.AssertionFailedError:
Assertion A14.6.9-3 (VariableInResult) failed: 
>     [java] Wrong query result: 
>     [java] expected: [Project(1, name orange, budget 2500000.99), Project(1, name orange,
budget 2500000.99), Project(1, name orange, budget 2500000.99)]
>     [java] got:      [Project(1, name orange, budget 2500000.99)]

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message