db-jdo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Craig Russell (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JDO-311) Inheritance3 : should check if the JDO implementation supports "javax.jdo.option.mapping.RelationSubclassTable"
Date Tue, 28 Feb 2006 19:19:41 GMT
    [ http://issues.apache.org/jira/browse/JDO-311?page=comments#action_12368158 ] 

Craig Russell commented on JDO-311:
-----------------------------------

This patch looks good; just a couple of comments.

1. I'd suggest adding some more delimiters to:

       StringTokenizer tokenizer = new StringTokenizer(requiredOptions, " ,");

I'd change the delimiters to include semicolon, tab, newline, carriage return:

       StringTokenizer tokenizer = new StringTokenizer(requiredOptions, " ,;\n\r\t");

2. I think there is no need to remove the leading "org.apache.jdo.tck..." from the class name
in the message, so these lines would not be needed.

+                int index = getClass().getName().lastIndexOf('.');
+                String testName = index==-1 ? 
+                        getClass().getName() : getClass().getName().substring(index+1);

But maybe I misunderstand your intent here.

> Inheritance3 : should check if the JDO implementation supports "javax.jdo.option.mapping.RelationSubclassTable"
> ---------------------------------------------------------------------------------------------------------------
>
>          Key: JDO-311
>          URL: http://issues.apache.org/jira/browse/JDO-311
>      Project: JDO
>         Type: Bug
>   Components: tck20
>     Versions: JDO 2 beta
>     Reporter: Andy Jefferson
>     Assignee: Michael Watzek
>      Fix For: JDO 2 final
>  Attachments: JDO-311.patch
>
> The inheritance3 test should check whether PMF.supportedOptions contains "javax.jdo.option.mapping.RelationSubclassTable"
before running the test. JPOX doesn't support this option yet the test still runs (and fails)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message