db-jdo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Bouschen <mbo.t...@spree.de>
Subject Re: [jira] Updated: (JDO-257) Change return type of makePersistent from void to Object
Date Mon, 02 Jan 2006 15:00:20 GMT
Hi Craig,

> Hi Michael,
> 
> Looks good. Just one petty comment.
> 
> Craig
> 
>> Index: src/java/javax/jdo/listener/AttachCallback.java
>> ===================================================================
>> --- src/java/javax/jdo/listener/AttachCallback.java (Revision 360481)
>> +++ src/java/javax/jdo/listener/AttachCallback.java (Arbeitskopie)
>> @@ -32,17 +32,18 @@
>>     
>>      /**
>>       * This method is called during the execution of
>> -     * {@link PersistenceManager#attachCopy} before the copy is made.
>> +     * {@link PersistenceManager#makePersistent} on the detached 
>> parameter
> 
> 
> I'd remove "parameter" since it might be a reached instance not a 
> parameter instance.

thanks for the comment. I removed "parameter". You might want to double 
check the wording in the spec (section 10.6 jdoPreAttach and 
jdoPostAttach), because your remark about "a reached instance" applies 
there too.

Regards Michael

> 
>> +     * instance before the copy is made.
>>       * @since 2.0
>>       */
>>      public void jdoPreAttach();
>>      /**
>>       * This method is called during the execution of
>> -     * {@link PersistenceManager#attachCopy} on the persistent
>> +     * {@link PersistenceManager#makePersistent} on the persistent
>>       * instance after the copy is made.
>>       * @param attached The corresponding (non-attached) instance that was
>> -     * attached in the call to {@link PersistenceManager#attachCopy}.
>> +     * attached in the call to {@link PersistenceManager#makePersistent}.
>>       * @since 2.0
>>       */
>>      public void jdoPostAttach(Object attached);
>> Index: src/java/javax/jdo/listener/AttachLifecycleListener.java
>> ===================================================================
>> --- src/java/javax/jdo/listener/AttachLifecycleListener.java (Revision 
>> 360481)
>> +++ src/java/javax/jdo/listener/AttachLifecycleListener.java 
>> (Arbeitskopie)
>> @@ -33,19 +33,23 @@
>>      extends InstanceLifecycleListener {
>>     
>>      /**
>> -     * This method is called during the execution of
>> -     * {@link PersistenceManager#attachCopy} before the copy is made.
>> -     * It is called before the method {@link AttachCallback#jdoPreAttach}
>> -     * is invoked on the instance to be attached.
>> +     * This method is called before a detached instance is attached, 
>> via the
>> +     * {@link PersistenceManager#makePersistent} method. The source 
>> instance
>> +     * is the detached instance. This method is called before the
>> +     * corresponding {@link AttachCallback#jdoPreAttach} on the detached
>> +     * instance.
>>       * @param event the attach event.
>>       * @since 2.0
>> - */
>> +     */
>>      void preAttach (InstanceLifecycleEvent event);
>>     
>>      /**
>> -     * This method is called during the execution of
>> -     * {@link PersistenceManager#attachCopy} on the persistent
>> -     * instance after the copy is made.
>> +     * This method is called after a detached instance is attached, 
>> via the
>> +     * {@link PersistenceManager#makePersistent} method. The source
>> +     * instance is the corresponding persistent instance in the 
>> cache; the
>> +     * target instance is the detached instance. This method is 
>> called after
>> +     * the corresponding {@link AttachCallback#jdoPostAttach} on the
>> +     * persistent instance.
>>       * @param event the attach event.
>>       * @since 2.0
>>       */
> 
> 
> On Jan 1, 2006, at 10:52 AM, Michael Bouschen (JIRA) wrote:
> 
>>      [ http://issues.apache.org/jira/browse/JDO-257?page=all ]
>>
>> Michael Bouschen updated JDO-257:
>> ---------------------------------
>>
>>     Attachment: attachInterfaces.patch
>>
>> Attached you find a patch (attachInterfaces.patch) for review. It 
>> removes javadoc references to PM.attachCopy which has been removed. 
>>
>>> Change return type of makePersistent from void to Object
>>> --------------------------------------------------------
>>>
>>>          Key: JDO-257
>>>          URL: http://issues.apache.org/jira/browse/JDO-257
>>>      Project: JDO
>>>         Type: New Feature
>>>   Components: api20
>>>     Reporter: Craig Russell
>>>     Assignee: Craig Russell
>>>      Fix For: JDO 2 beta
>>>  Attachments: attachInterfaces.patch, persistencemanager.patch
>>>
>>> The signatures of makePersistent and makePersistentAll are changed to 
>>> return the persistent instances. This change was adopted by the 
>>> expert group 8-Dec-2005.
>>
>>
>> -- 
>> This message is automatically generated by JIRA.
>> -
>> If you think it was sent incorrectly contact one of the administrators:
>>    http://issues.apache.org/jira/secure/Administrators.jspa
>> -
>> For more information on JIRA, see:
>>    http://www.atlassian.com/software/jira
>>
> 
> Craig Russell
> 
> Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
> 
> 408 276-5638 mailto:Craig.Russell@sun.com
> 
> P.S. A good JDO? O, Gasp!
> 
> 


-- 
Michael Bouschen		Tech@Spree Engineering GmbH
mailto:mbo.tech@spree.de	http://www.tech.spree.de/
Tel.:++49/30/235 520-33		Buelowstr. 66			
Fax.:++49/30/2175 2012		D-10783 Berlin			

Mime
View raw message