Mailing-List: contact jdo-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jdo-dev@db.apache.org
Message-ID: <1410625282.1133454331910.JavaMail.jira@ajax.apache.org>
Date: Thu, 1 Dec 2005 17:25:31 +0100 (CET)
From: "Michael Watzek (JIRA)" <jira@apache.org>
To: jdo-dev@db.apache.org
Subject: [jira] Updated: (JDO-147) Remove pm.deletePersistent from query tests
In-Reply-To: <143740100.1127406027981.JavaMail.jira@ajax.apache.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

     [ http://issues.apache.org/jira/browse/JDO-147?page=all ]

Michael Watzek updated JDO-147:
-------------------------------

    Attachment: JDO-147.patch

The attached patch fixes this issue.

Methods QueryTest.cleanupCompanyModel and QueryTest.cleanupDatabase have been removed. Instead, localSetup methods have been introduced in all JDO1 query tests.

All JDO1 query tests (except jdoql.operator tests) have been adapted to make use of the query framework implemented for JDO2 query tests. Thus, JDO1 query tests cases are executed as API queries and as single string queries. Furthermore, this ensures that JDO1 and JDO2 use the same logging infrastructure.

Additionally, methods QueryTest.getCompanyModelInstanceXXX have been removed. Instead, methods QueryTest.getPersistentCompanyModelInstanceXXX and QueryTest.getTransientCompanyModelInstanceXXX have been introduced. The expected result of queries is initialized using QueryTest.getTransientCompanyModelInstanceXXX. Parameters of queries are initialized using QueryTest.getPerisistentCompanyModelInstanceXXX. The same holds true for QueryTest.getMylibInstanceXXX methods.


> Remove pm.deletePersistent from query tests
> -------------------------------------------
>
>          Key: JDO-147
>          URL: http://issues.apache.org/jira/browse/JDO-147
>      Project: JDO
>         Type: Bug
>   Components: tck20
>     Reporter: Michelle Caisse
>     Assignee: Michael Watzek
>  Attachments: JDO-147.patch
>
> The query tests delete the persistent instance that they create at the end of the test using pm.deletePersistent().  Now that we use the new cleanup mechanism (addTearDownClass(Class)), there is no reason to deletie the instance.  Also, the new maven option jdo.tck.cleanupaftertest cannot override this cleanup, so you can never see the database contents for debugging.  Therefore, we should remove the line that deletes the persistent instance.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira