db-jdo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Bouschen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JDO-147) Remove pm.deletePersistent from query tests
Date Fri, 02 Dec 2005 09:48:32 GMT
    [ http://issues.apache.org/jira/browse/JDO-147?page=comments#action_12359134 ] 

Michael Bouschen commented on JDO-147:
--------------------------------------

Looks good! 

Just a minor comment:  please add to the javadoc of QueryTest.makePersistentAll that it starts
its own transaction.

> Remove pm.deletePersistent from query tests
> -------------------------------------------
>
>          Key: JDO-147
>          URL: http://issues.apache.org/jira/browse/JDO-147
>      Project: JDO
>         Type: Bug
>   Components: tck20
>     Reporter: Michelle Caisse
>     Assignee: Michael Watzek
>  Attachments: JDO-147.patch
>
> The query tests delete the persistent instance that they create at the end of the test
using pm.deletePersistent().  Now that we use the new cleanup mechanism (addTearDownClass(Class)),
there is no reason to deletie the instance.  Also, the new maven option jdo.tck.cleanupaftertest
cannot override this cleanup, so you can never see the database contents for debugging.  Therefore,
we should remove the line that deletes the persistent instance.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message