Mailing-List: contact jdo-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jdo-dev@db.apache.org
Received-SPF: pass (asf.osuosl.org: local policy)
Date: Wed, 02 Nov 2005 08:24:45 -0800
From: Craig L Russell <Craig.Russell@Sun.COM>
Subject: Re: Issue 135: Remove attachCopy from PersistenceManager
In-reply-to: <4368DB87.5070109@spree.de>
Sender: Craig.Russell@Sun.COM
To: jdo-dev@db.apache.org
Cc: JDO Expert Group <jdo-experts-ext@Sun.COM>
Message-id: <8C4CB93F-15F5-478F-A0EE-3C52418E26DD@sun.com>
MIME-version: 1.0
Content-type: text/plain; format=flowed; delsp=yes; charset=ISO-8859-1
Content-transfer-encoding: QUOTED-PRINTABLE
References: <B714B5E7-C139-41E3-A247-68F2AFEEFCE3@Sun.COM>
 <4368D9F7.8040409@artnology.com> <4368DB87.5070109@spree.de>

Hi,


On Nov 2, 2005, at 7:30 AM, Michael Bouschen wrote:

> Hi J=F6rg,
>
> good catch! Yes, the examples are meant to use two different =20
> PersistenceManagers pm1 and pm2.
>
> I think JDOHelper.shallowCopy would work for any instance of a =
=20
> persistence capable class, not only for detached instances.
>
The semantics of JDOHelper.shallowCopyAll would be to make an object =
=20
graph suitable for attachment. So there would be a copy made of =20
transient and detached instances but persistent instances would not =
=20
be copied.

Perhaps shallowCopyAll isn't the right name since we don't shallow =
=20
copy persistent instances. Maybe something like copyForAttachment or =
=20
something like it.
>
> Regards Michael

Regards,

Craig
>
>
>> Craig L Russell schrieb:
>>
>>> With this change,  there is no standard way to attach the same =
=20
>>> object  graph to multiple persistence managers. So a method is =
=20
>>> added to  JDOHelper that copies a complete object graph so the =
=20
>>> copies can be  attached to multiple persistence managers.
>>>
>>> Instead of:
>>> Object[ ] attached1 =3D pm.attachCopy(graph);
>>> Object[ ] attached2 =3D pm.attachCopy(graph);
>>>
>>> use:
>>> Object[ ] copies =3D JDOHelper.shallowCopy(graph, false);
>>> Object[ ] attached1 =3D pm.makePersistentAll(copies);
>>> Object[ ] attached2 =3D pm.makePersistentAll(copies);
>>>
>> There is only one and the same persistence manager being used in =
=20
>> these examples, shouldn't it be more like:
>>    Instead of:
>>    Object[ ] attached1 =3D pm1.attachCopy(graph);
>>    Object[ ] attached2 =3D pm2.attachCopy(graph);
>>    use:
>>    Object[ ] copies =3D JDOHelper.shallowCopy(graph, false);
>>    Object[ ] attached1 =3D pm1.makePersistentAll(copies);
>>    Object[ ] attached2 =3D pm2.makePersistentAll(copies);
>> BTW, is JDOHelper.shallowCopy() supposed to work only on a =20
>> detached graph or on any persistence capable object?
>> Regards,
>> J=F6rg
>>
>
>
> --=20
> Michael Bouschen        Tech@Spree Engineering GmbH
> mailto:mbo.tech@spree.de    http://www.tech.spree.de/
> Tel.:++49/30/235 520-33        Buelowstr. 66
> Fax.:++49/30/2175 2012        D-10783 Berlin
>