db-jdo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Bouschen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JDO-159) Implement new JDO 2 query tests cases concerning new supported methods.
Date Thu, 13 Oct 2005 09:35:06 GMT
    [ http://issues.apache.org/jira/browse/JDO-159?page=comments#action_12331973 ] 

Michael Bouschen commented on JDO-159:
--------------------------------------

A few comments.

Class SupportedStringMethods:
- Typo (Map instead of String) in the title: "Supported Map methods" 
- How about using a different expression for the indexOf tests? We could run a Department
query checking its name. There is a Department called 'Development'. This name includes two
'e' which allows us to test whether indexOf with a fromIndex skips the first letters:
  name.indexOf('e') == 1
  name.indexOf('e', 2) == 3
- The array expectedResult is a list of names of result instances and not the result itself,
correct? You might want to add this to the javadoc of the field.

Class SupportedMathMethods:
- Would it make sense to use the pc class PrimitiveTypes for testing the Math methods abs
and sqrt? This would allow calling abs for int and double fields and AFAIK there are instances
with negative field values.  

Class SupportedJDOHelperMethods:
- How about adding another test query that calls JDOHelper.getObjectId in the filter: 
  SELECT FROM Person WHERE JDOHelper.getObjectId(this) == oid PARAMETERS Object oid 

No comments for class SupportedMapMethods.

> Implement new JDO 2 query tests cases concerning new supported methods.
> -----------------------------------------------------------------------
>
>          Key: JDO-159
>          URL: http://issues.apache.org/jira/browse/JDO-159
>      Project: JDO
>         Type: New Feature
>   Components: tck20
>     Reporter: Michael Watzek
>     Assignee: Michael Watzek
>  Attachments: JDO-159.patch
>
>  We need 4 new test classes, one for each of the following assertions: 
> - A14.6.2-46: Supported Map methods.
> - A14.6.2-47: New supported String methods.
> - A14.6.2-48: Supported Math methods.
> - A14.6.2-49: Supported JDOHelper methods.
> Details can be found on Wiki page http://wiki.apache.org/jdo/QueryTests#NewSupportedMethods.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message