Return-Path: Delivered-To: apmail-db-jdo-dev-archive@www.apache.org Received: (qmail 46566 invoked from network); 12 Sep 2005 22:08:32 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 12 Sep 2005 22:08:32 -0000 Received: (qmail 2323 invoked by uid 500); 12 Sep 2005 22:08:32 -0000 Mailing-List: contact jdo-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jdo-dev@db.apache.org Delivered-To: mailing list jdo-dev@db.apache.org Received: (qmail 2310 invoked by uid 99); 12 Sep 2005 22:08:32 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Sep 2005 15:08:32 -0700 X-ASF-Spam-Status: No, hits=0.1 required=10.0 tests=HTML_60_70,HTML_MESSAGE,RCVD_BY_IP,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of karan.malhi@gmail.com designates 64.233.184.194 as permitted sender) Received: from [64.233.184.194] (HELO wproxy.gmail.com) (64.233.184.194) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Sep 2005 15:08:41 -0700 Received: by wproxy.gmail.com with SMTP id i17so1886359wra for ; Mon, 12 Sep 2005 15:08:27 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:in-reply-to:mime-version:content-type:references; b=oGEQD+WrdRnv4mKtfnQo5Efc9wLHbI3UwY/zAtQzDgWcRDMP4eSqF1if/kyOpEQj7pfS68KKh2QnslDhb4u7Gzw5/qBuRun1e+j54h8CpaC1Rp1o/ZkoF7SSkzm0FKtH3KdG4EyZ+b4JSvEj9rn7oFyEFlRRJtFLA7EJf6l9L0M= Received: by 10.54.3.43 with SMTP id 43mr7761wrc; Mon, 12 Sep 2005 15:08:27 -0700 (PDT) Received: by 10.54.135.4 with HTTP; Mon, 12 Sep 2005 15:08:27 -0700 (PDT) Message-ID: Date: Mon, 12 Sep 2005 18:08:27 -0400 From: Karan Malhi Reply-To: karan.malhi@gmail.com To: jdo-dev@db.apache.org Subject: Re: JDO-131 patches for review In-Reply-To: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_14825_20231336.1126562907162" References: <4323D276.8030006@gmail.com> <4324190B.7080604@spree.de> <43244AEE.8010505@gmail.com> <43248D90.4020901@spree.de> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N ------=_Part_14825_20231336.1126562907162 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Hi Michael, I agree. I would go with the longer one too, it is clearer. However, i had= =20 one question, are we naming the properties in camel case? should i name the property jdo.tck.cleanupAfterTest or should it be all=20 lower case (jdo.tck.cleanupaftertest) ? Please let me know if we are=20 following any particular convention in naming properties Thanks On 9/12/05, Craig Russell wrote: >=20 > Hi, > I wonder if the property should indicate that it's cleaning up "after" th= e=20 > test, something like: >=20 > jdo.tck.cleanupafter or jdo.tck.cleanupaftertest >=20 > Craig >=20 > On Sep 11, 2005, at 1:03 PM, Michael Bouschen wrote: >=20 > Hi Karan Singh, >=20 >=20 > Hi Michael, >=20 > Do you think we would need the same property for the iut tests? The patch= =20 > which i submitted earlier does not add the sysproperty for iut tests in= =20 > maven.xml. >=20 >=20 > yes, I think we need the same property for the iut tests, so the goal=20 > doRuntck.iut should add the sysproperty, too. >=20 > Good catch! >=20 > Regards Michael >=20 >=20 >=20 > Michael Bouschen wrote: >=20 >=20 > Hi Karan Singh, >=20 > nice work! >=20 > I would like to propose three small changes: > - All tck property names start with jdo.tck, so how about renaming=20 > cleanup.data to jdo.tck.cleanupdata? > - I propose to specify a default (true) for the new property in JDO_Test.= =20 > We could also call equalsIgnoreCase in the variable initialization, then = it=20 > is tested only once: > protected static boolean cleanupData =3D > System.getProperty("jdo.tck.cleanupdata",=20 > "true").equalsIgnoreCase("true"); > - It looks like your IDE uses tabs for indentation (see the line calling= =20 > equlasIgnoreCase). Using blanks would have the advantage that it looks th= e=20 > same in all the editors and IDEs. >=20 > What do you think? >=20 > Regards Michael >=20 >=20 > Hi, >=20 > I am submitting the patch files for review for JIRA issue 131. >=20 > ------------------------------------------------------------------------= =20 >=20 > Index: C:/ApacheJDO/trunk/tck20/test/java/org/apache/jdo/tck/JDO_Test.jav= a > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- C:/ApacheJDO/trunk/tck20/test/java/org/apache/jdo/tck/JDO_Test.java (= revision=20 > 279926) > +++ C:/ApacheJDO/trunk/tck20/test/java/org/apache/jdo/tck/JDO_Test.java (= working=20 > copy) > @@ -137,6 +137,11 @@ > /** Name of the file contaninig the properties for the PMF. */ > protected static String PMFProperties =3D System.getProperty > ("PMFProperties"); >=20 > + /** String indicating whether to clean up data after tests or not. The= =20 > value can be either > + * "true" or "false". If "false" then test will not clean up data from= =20 > database > + */ > + protected static String cleanupData =3D System.getProperty("cleanup.dat= a > "); > + /** The Properties object for the PersistenceManagerFactory. */ > protected static Properties PMFPropertiesObject; >=20 > @@ -260,7 +265,9 @@ > pmf =3D null; > try { > - localTearDown(); > + if (cleanupData.equalsIgnoreCase("true")) { > + localTearDown(); > + } > } catch (Throwable t) { > setTearDownThrowable("localTearDown", t); >=20 >=20 > ------------------------------------------------------------------------= =20 >=20 > Index: C:/ApacheJDO/trunk/tck20/maven.xml > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- C:/ApacheJDO/trunk/tck20/maven.xml (revision 279926) > +++ C:/ApacheJDO/trunk/tck20/maven.xml (working copy) > @@ -361,6 +361,8 @@ > value=3D"${jdo.tck.exclude}"/> > value=3D"${jdo.tck.log.directory}/${timestamp}"/> > + + value=3D"${cleanup.data}"/> }"/> > > >=20 >=20 > ------------------------------------------------------------------------= =20 >=20 > Index: C:/ApacheJDO/trunk/tck20/project.properties > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- C:/ApacheJDO/trunk/tck20/project.properties (revision 279926) > +++ C:/ApacheJDO/trunk/tck20/project.properties (working copy) > @@ -42,7 +42,8 @@ > maven.junit.dir =3D ${jdo.tck.testdir} > maven.junit.sysproperties =3D PMFProperties > PMFProperties =3D jdori.properties > - > +# Setting this property to false will turn off cleanup of data from=20 > database to inspect database contents after test run > +cleanup.data =3D true > # JDO TCK settings > jdo.tck.dblist=3Dderby > jdo.tck.identitytypes=3Dapplicationidentity datastoreidentity >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20 > --=20 > Michael Bouschen Tech@Spree Engineering GmbH > mailto:mbo.tech@spree.de http://www.tech.spree.de/ > Tel.:++49/30/235 520-33 Buelowstr. 66=20 > Fax.:++49/30/2175 2012 D-10783 Berlin=20 >=20 >=20 >=20 > Craig Russell >=20 > Architect, Sun Java Enterprise System http://java.sun.com/products/jdo >=20 > 408 276-5638 mailto:Craig.Russell@sun.com >=20 > P.S. A good JDO? O, Gasp! >=20 >=20 >=20 --=20 Karan Malhi ------=_Part_14825_20231336.1126562907162--