Return-Path: Delivered-To: apmail-db-jdo-dev-archive@www.apache.org Received: (qmail 93461 invoked from network); 5 Sep 2005 22:59:35 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 5 Sep 2005 22:59:35 -0000 Received: (qmail 87971 invoked by uid 500); 5 Sep 2005 22:59:34 -0000 Mailing-List: contact jdo-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jdo-dev@db.apache.org Delivered-To: mailing list jdo-dev@db.apache.org Received: (qmail 87958 invoked by uid 99); 5 Sep 2005 22:59:34 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Sep 2005 15:59:34 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=HTML_MESSAGE X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [192.18.98.36] (HELO brmea-mail-4.sun.com) (192.18.98.36) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Sep 2005 15:59:47 -0700 Received: from fe2.sun.com ([192.18.108.79]) by brmea-mail-4.sun.com (8.12.10/8.12.9) with ESMTP id j85MxQTW014659 for ; Mon, 5 Sep 2005 16:59:26 -0600 (MDT) Received: from conversion-daemon.fe2.sun.com by fe2.sun.com (Sun Java System Messaging Server 6.1 HotFix 0.02 (built Aug 25 2004)) id <0IMD00D017DCYW00@fe2.sun.com> (original mail from Craig.Russell@Sun.COM) for jdo-dev@db.apache.org; Mon, 05 Sep 2005 16:59:26 -0600 (MDT) Received: from [192.168.0.10] ([24.6.172.77]) by fe2.sun.com (Sun Java System Messaging Server 6.1 HotFix 0.02 (built Aug 25 2004)) with ESMTPSA id <0IMD00ERZ96THOO1@fe2.sun.com> for jdo-dev@db.apache.org; Mon, 05 Sep 2005 16:59:25 -0600 (MDT) Date: Mon, 05 Sep 2005 15:59:16 -0700 From: Craig Russell Subject: Re: Testing persistent interfaces In-reply-to: <431CB432.1030300@spree.de> To: jdo-dev@db.apache.org, JDO Expert Group Message-id: <7670BE66-C5ED-4C8A-8EA3-31E2CEAF1453@Sun.COM> MIME-version: 1.0 X-Mailer: Apple Mail (2.734) Content-type: multipart/signed; protocol="application/pkcs7-signature"; boundary=Apple-Mail-49--522414475; micalg=sha1 References: <431C74A4.30104@spree.de> <2FEA11F4-6C50-494D-B7E4-5C953715A498@Sun.COM> <431CB432.1030300@spree.de> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N --Apple-Mail-49--522414475 Content-Type: multipart/alternative; boundary=Apple-Mail-47--522414787 --Apple-Mail-47--522414787 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8; delsp=yes; format=flowed Hi, Here's the patch for the changes to test data. =EF=BF=BC And I've also added four configurations for the inheritance 1-4 using =20= the companyAllRelationships.xml test data. =EF=BF=BC Some of these throw exceptions due to JPOX not mapping the schema. Erik, Andy, Can you run these configurations and give us some feedback on the =20 errors? "Class "org.apache.jdo.tck.pc.company.Employee" has been =20 specified to use "subclass-table" inheritance strategy yet has at =20 least one field ("hradvisees") that is a Collection/Map. This is not =20 currently supported by JPOX." Thanks, Craig On Sep 5, 2005, at 2:10 PM, Michael Bouschen wrote: > Hi Craig, > > looks good! > > Two minors: > - The patch file misses a newline at the end of the file which =20 > causes problems when applying the patch. Could you please check =20 > whether file companyNoRelationships.xml has a newline at the end? I've added new lines to all the test data files. > - Do we use upper case letters for names of constants? If yes you =20 > might want to change the name of factoryPropertyName and =20 > defaultFactoryClassName in class CompanyFactoryRegistry. Yes. I've changed them to their upper case equivalents. Craig > > Regards Michael > > >> Hi Michael, >> >> Thanks for the comments. A final code review is attached. I'll =20 >> send the xml file updates as a separate review. >> >> ---------------------------------------------------------------------=20= >> --- >> >> >> On Sep 5, 2005, at 9:39 AM, Michael Bouschen wrote: >> >> >>> Hi Craig, >>> >>> I like the idea of using the xml bean factory instance pattern =20 >>> instead of the static bean factory. I was not aware that I can =20 >>> add a bean instance to the CompanyModelReader using an API such =20 >>> as addSingleton instead of defining in xml. This solves the =20 >>> problem of attaching the current pm to the company factory which =20 >>> is then used by the CompanyModelReader when creating pc instances. >>> >>> A few remarks about the patch: >>> - Today CompanyFactoryRegistry.registerFactory takes the name of =20 >>> the company factory class as an argument. This means all the =20 >>> callers need to get the value of the system property =20 >>> jdo.tck.mapping.companyfactory and pass this to the call. Would =20 >>> it make sense to add another method registerFactory taking just =20 >>> the PM: >>> public static final String companyFactoryClassName =3D >>> System.getProperty("jdo.tck.mapping.companyfactory"); >>> >>> public static void registerFactory(PersistenceManager pm) { >>> registerFactory(companyFactoryClassName, pm); >>> } >>> This keeps the handling of the property =20 >>> jdo.tck.mapping.companyfactory local in class =20 >>> CompanyFactoryRegistry. >>> >> >> >> Good. >> >> >>> >>> - Class CompanyModelReader should define a constant for the name =20 >>> of the companyFactory bean in the xml: >>> public static final String COMPANY_FACTORY_BEAN =3D =20 >>> "companyFactory"; >>> It is used in the addSingleton call in method configureFactory. >>> >> >> >> Right. >> >> >>> >>> - The patch includes a changed version of derby.property where =20 >>> you uncommented the special Mac property for derby. I guess you =20 >>> are not going to check in this change, correct? >>> >> >> >> Correct. >> >> >>> >>> Regards Michael >>> >>> >>> >>>> Javadogs, >>>> Please check out the Wiki page http://wiki.apache.org/jdo/=20 >>>> PersistentInterfaces and this patch. >>>> I've tested the companyNoRelationships.xml but haven't updated =20 >>>> the other testdata files, pending a review. The idea is to =20 >>>> replace the testdata xml files with the factory concept so they =20 >>>> can be used by the standard CompletenessTest as well as the =20 >>>> interface test. >>>> Craig >>>> =3D >>>> -------------------------------------------------------------------=20= >>>> ----- >>>> Craig Russell >>>> Architect, Sun Java Enterprise System http://java.sun.com/=20 >>>> products/jdo >>>> 408 276-5638 mailto:Craig.Russell@sun.com >>>> P.S. A good JDO? O, Gasp! >>>> >>>> >>> >>> >>> --=20 >>> Michael Bouschen Tech@Spree Engineering GmbH >>> mailto:mbo.tech@spree.de http://www.tech.spree.de/ >>> Tel.:++49/30/235 520-33 Buelowstr. 66 Fax.:+=20 >>> +49/30/2175 2012 D-10783 Berlin >>> >> >> Craig Russell >> >> Architect, Sun Java Enterprise System http://java.sun.com/products/=20= >> jdo >> >> 408 276-5638 mailto:Craig.Russell@sun.com >> >> P.S. A good JDO? O, Gasp! >> >> >> =3D >> > > > > --=20 > Michael Bouschen Tech@Spree Engineering GmbH > mailto:mbo.tech@spree.de http://www.tech.spree.de/ > Tel.:++49/30/235 520-33 Buelowstr. 66 > Fax.:++49/30/2175 2012 D-10783 Berlin > > Craig Russell Architect, Sun Java Enterprise System http://java.sun.com/products/jdo 408 276-5638 mailto:Craig.Russell@sun.com P.S. A good JDO? O, Gasp! --Apple-Mail-47--522414787 Content-Type: multipart/mixed; boundary=Apple-Mail-48--522414787 --Apple-Mail-48--522414787 Content-Transfer-Encoding: 7bit Content-Type: text/html; charset=US-ASCII Hi,

Here's the patch for the changes to test data.

--Apple-Mail-48--522414787 Content-Transfer-Encoding: 7bit Content-Type: application/octet-stream; x-unix-mode=0644; name="xmldata.patch" Content-Disposition: attachment; filename=xmldata.patch Index: test/testdata/org/apache/jdo/tck/pc/company/companyEmbedded.xml =================================================================== --- test/testdata/org/apache/jdo/tck/pc/company/companyEmbedded.xml (revision 278819) +++ test/testdata/org/apache/jdo/tck/pc/company/companyEmbedded.xml (working copy) @@ -26,24 +26,24 @@ - + 1 Sun Microsystems, Inc. 11/Apr/1952 - + 1 Development - + 2 Human Resources - + 1 emp1First emp1Last @@ -60,7 +60,7 @@ - + 2 emp2First emp2Last @@ -77,7 +77,7 @@ - + 3 emp3First emp3Last @@ -94,7 +94,7 @@ - + 4 emp4First emp4Last @@ -110,7 +110,7 @@ - + 5 emp5First emp5Last @@ -127,7 +127,7 @@ - + 1 Unter den Linden 1 Berlin @@ -135,7 +135,7 @@ 12345 Germany - + 2 Broadway 1 New York @@ -143,7 +143,7 @@ 10000 USA - + 3 Market St. San Francisco @@ -152,41 +152,41 @@ USA - + 1 Carrier1 PPO - + 2 Carrier2 HMO - + 3 Carrier2 HMO - + 4 Carrier2 99.999 - + 1 orange 2500000.99 - + 2 blue 50000.00 - + 3 green 2000.99 Index: test/testdata/org/apache/jdo/tck/pc/company/companyM-MRelationships.xml =================================================================== --- test/testdata/org/apache/jdo/tck/pc/company/companyM-MRelationships.xml (revision 278819) +++ test/testdata/org/apache/jdo/tck/pc/company/companyM-MRelationships.xml (working copy) @@ -23,23 +23,23 @@ - + 1 Sun Microsystems, Inc. 11/Apr/1952 - + 1 Development - + 2 Human Resources - + 1 emp1First emp1Last @@ -59,7 +59,7 @@ - + 2 emp2First emp2Last @@ -75,7 +75,7 @@ - + 3 emp3First emp3Last @@ -91,7 +91,7 @@ - + 4 emp4First emp4Last @@ -110,7 +110,7 @@ - + 5 emp5First emp5Last @@ -130,7 +130,7 @@ - + 1 Unter den Linden 1 Berlin @@ -138,7 +138,7 @@ 12345 Germany - + 2 Broadway 1 New York @@ -146,7 +146,7 @@ 10000 USA - + 3 Market St. San Francisco @@ -155,31 +155,31 @@ USA - + 1 Carrier1 PPO - + 2 Carrier2 HMO - + 3 Carrier2 HMO - + 4 Carrier2 99.999 - + 1 orange 2500000.99 @@ -191,7 +191,7 @@ - + 2 blue 50000.00 @@ -208,7 +208,7 @@ - + 3 green 2000.99 @@ -225,3 +225,4 @@ + Index: test/testdata/org/apache/jdo/tck/pc/company/companyAllRelationships.xml =================================================================== --- test/testdata/org/apache/jdo/tck/pc/company/companyAllRelationships.xml (revision 278819) +++ test/testdata/org/apache/jdo/tck/pc/company/companyAllRelationships.xml (working copy) @@ -12,7 +12,7 @@ - + 1 Sun Microsystems, Inc. 11/Apr/1952 @@ -25,7 +25,7 @@ - + 1 Development @@ -44,7 +44,7 @@ - + 2 Human Resources @@ -63,7 +63,7 @@ - + 1 emp1First emp1Last @@ -98,7 +98,7 @@ - + 2 emp2First emp2Last @@ -136,7 +136,7 @@ - + 3 emp3First emp3Last @@ -167,7 +167,7 @@ - + 4 emp4First emp4Last @@ -201,7 +201,7 @@ - + 5 emp5First emp5Last @@ -243,7 +243,7 @@ - + 1 Unter den Linden 1 Berlin @@ -251,7 +251,7 @@ 12345 Germany - + 2 Broadway 1 New York @@ -259,7 +259,7 @@ 10000 USA - + 3 Market St. San Francisco @@ -268,77 +268,77 @@ USA - + 1 Carrier1 PPO - + 2 Carrier2 HMO - + 3 Carrier3 HMO - + 4 Carrier4 HMO - + 5 Carrier5 HMO - + 11 Carrier1 99.999 - + 12 Carrier2 99.999 - + 13 Carrier3 99.999 - + 14 Carrier4 99.999 - + 15 Carrier5 99.999 - + 1 orange 2500000.99 @@ -350,7 +350,7 @@ - + 2 blue 50000.00 @@ -367,7 +367,7 @@ - + 3 green 2000.99 @@ -384,3 +384,4 @@ + Index: test/testdata/org/apache/jdo/tck/pc/company/companyForQueryTests.xml =================================================================== --- test/testdata/org/apache/jdo/tck/pc/company/companyForQueryTests.xml (revision 278819) +++ test/testdata/org/apache/jdo/tck/pc/company/companyForQueryTests.xml (working copy) @@ -12,7 +12,7 @@ - + 1 Development @@ -24,7 +24,7 @@ - + 1 emp1First emp1Last @@ -42,7 +42,7 @@ - + 2 emp2First emp2Last @@ -59,7 +59,7 @@ - + 3 emp3First emp3Last @@ -77,7 +77,7 @@ - + 1 Unter den Linden 1 Berlin @@ -85,7 +85,7 @@ 12345 Germany - + 2 Broadway 1 New York @@ -93,7 +93,7 @@ 10000 USA - + 3 Market St. San Francisco @@ -102,7 +102,7 @@ USA - + 1 Carrier1 PPO Index: test/testdata/org/apache/jdo/tck/pc/company/company1-MRelationships.xml =================================================================== --- test/testdata/org/apache/jdo/tck/pc/company/company1-MRelationships.xml (revision 278819) +++ test/testdata/org/apache/jdo/tck/pc/company/company1-MRelationships.xml (working copy) @@ -19,7 +19,7 @@ - + 1 Sun Microsystems, Inc. 11/Apr/1952 @@ -31,7 +31,7 @@ - + 1 Development @@ -50,7 +50,7 @@ - + 2 Human Resources @@ -69,7 +69,7 @@ - + 1 emp1First emp1Last @@ -83,7 +83,7 @@ - + 2 emp2First emp2Last @@ -104,7 +104,7 @@ - + 3 emp3First emp3Last @@ -118,7 +118,7 @@ - + 4 emp4First emp4Last @@ -131,7 +131,7 @@ - + 5 emp5First emp5Last @@ -152,7 +152,7 @@ - + 1 Unter den Linden 1 Berlin @@ -160,7 +160,7 @@ 12345 Germany - + 2 Broadway 1 New York @@ -168,7 +168,7 @@ 10000 USA - + 3 Market St. San Francisco @@ -177,43 +177,44 @@ USA - + 1 Carrier1 PPO - + 2 Carrier2 HMO - + 3 Carrier2 HMO - + 4 Carrier2 99.999 - + 1 orange 2500000.99 - + 2 blue 50000.00 - + 3 green 2000.99 + Index: test/testdata/org/apache/jdo/tck/pc/company/companyNoRelationships.xml =================================================================== --- test/testdata/org/apache/jdo/tck/pc/company/companyNoRelationships.xml (revision 278819) +++ test/testdata/org/apache/jdo/tck/pc/company/companyNoRelationships.xml (working copy) @@ -26,23 +26,23 @@ - + 1 Sun Microsystems, Inc. 11/Apr/1952 - + 1 Development - + 2 Human Resources - + 1 emp1First emp1Last @@ -52,7 +52,7 @@ 20000 40 - + 2 emp2First emp2Last @@ -62,7 +62,7 @@ 10000 40 - + 3 emp3First emp3Last @@ -72,7 +72,7 @@ 15000 19 - + 4 emp4First emp4Last @@ -81,7 +81,7 @@ 15/Apr/2001 13000 - + 5 emp5First emp5Last @@ -91,43 +91,44 @@ 45000 - + 1 Carrier1 PPO - + 2 Carrier2 HMO - + 3 Carrier2 HMO - + 4 Carrier2 99.999 - + 1 orange 2500000.99 - + 2 blue 50000.00 - + 3 green 2000.99 + Index: test/testdata/org/apache/jdo/tck/pc/company/company1-1Relationships.xml =================================================================== --- test/testdata/org/apache/jdo/tck/pc/company/company1-1Relationships.xml (revision 278819) +++ test/testdata/org/apache/jdo/tck/pc/company/company1-1Relationships.xml (working copy) @@ -22,23 +22,23 @@ - + 1 Sun Microsystems, Inc. 11/Apr/1952 - + 1 Development - + 2 Human Resources - + 1 emp1First emp1Last @@ -52,7 +52,7 @@ - + 2 emp2First emp2Last @@ -66,7 +66,7 @@ - + 3 emp3First emp3Last @@ -80,7 +80,7 @@ - + 4 emp4First emp4Last @@ -93,7 +93,7 @@ - + 5 emp5First emp5Last @@ -107,7 +107,7 @@ - + 1 Unter den Linden 1 Berlin @@ -115,7 +115,7 @@ 12345 Germany - + 2 Broadway 1 New York @@ -123,7 +123,7 @@ 10000 USA - + 3 Market St. San Francisco @@ -132,89 +132,90 @@ USA - + 1 Carrier1 PPO - + 2 Carrier2 HMO - + 3 Carrier3 HMO - + 4 Carrier4 HMO - + 5 Carrier5 HMO - + 11 Carrier1 99.999 - + 12 Carrier2 99.999 - + 13 Carrier3 99.999 - + 14 Carrier4 99.999 - + 15 Carrier5 99.999 - + 1 orange 2500000.99 - + 2 blue 50000.00 - + 3 green 2000.99 + --Apple-Mail-48--522414787 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=ISO-8859-1

And I've also added four = configurations for the inheritance 1-4 using the = companyAllRelationships.xml test data.=A0

= --Apple-Mail-48--522414787 Content-Transfer-Encoding: 7bit Content-Type: application/octet-stream; x-unix-mode=0644; name="inheritAll.patch" Content-Disposition: attachment; filename=inheritAll.patch Index: test/conf/inheritance1AllRelationships.conf =================================================================== --- test/conf/inheritance1AllRelationships.conf (revision 0) +++ test/conf/inheritance1AllRelationships.conf (revision 0) @@ -0,0 +1,7 @@ +jdo.tck.description = Completeness test with inheritance mapping 1: \ +Separate table for each class in the inheritance hierarchy. \ +Each table contains columns for the declared fields. \ +Inheritance strategy: new-table for all classes. +jdo.tck.classes = org.apache.jdo.tck.mapping.CompletenessTest +jdo.tck.testdata = org/apache/jdo/tck/pc/company/companyAllRelationships.xml +jdo.tck.mapping = 1 Index: test/conf/inheritance2AllRelationships.conf =================================================================== --- test/conf/inheritance2AllRelationships.conf (revision 0) +++ test/conf/inheritance2AllRelationships.conf (revision 0) @@ -0,0 +1,14 @@ +jdo.tck.description = Completeness test with inheritance mapping 2: \ +Separate table for each class in the inheritance hierarchy. \ +No tables for abstract classes. \ +Each table contains columns for all fields. \ +Managers, mentors, hradvisors, and employees of the month \ +are fulltime employees. \ +Only fulltime employees can have insurances, can be project members, \ +and can be project reviewers. \ +Separate phone number type tables for persons, fulltime employees, \ +and parttime employees. \ +Inheritance strategy: new-table for all classes. +jdo.tck.classes = org.apache.jdo.tck.mapping.CompletenessTest +jdo.tck.testdata = org/apache/jdo/tck/pc/company/companyAllRelationships.xml +jdo.tck.mapping = 2 Index: test/conf/inheritance3AllRelationships.conf =================================================================== --- test/conf/inheritance3AllRelationships.conf (revision 0) +++ test/conf/inheritance3AllRelationships.conf (revision 0) @@ -0,0 +1,9 @@ +jdo.tck.description = Completeness test with inheritance mapping 3: \ +Person has inheritance strategy "new-table". \ +Employee has inheritance strategy "subclass-table". \ +PartTimeEmployee and FullTimeEmployee has inheritance strategy "new-table". \ +Insurance has inheritance strategy "subclass-table". \ +MedicalInsurance and DentalInsurance have inheritance strategy "new-table". +jdo.tck.classes = org.apache.jdo.tck.mapping.CompletenessTest +jdo.tck.testdata = org/apache/jdo/tck/pc/company/companyAllRelationships.xml +jdo.tck.mapping = 3 Index: test/conf/inheritance4AllRelationships.conf =================================================================== --- test/conf/inheritance4AllRelationships.conf (revision 0) +++ test/conf/inheritance4AllRelationships.conf (revision 0) @@ -0,0 +1,7 @@ +jdo.tck.description = Completeness test with inheritance mapping 4: \ +Person, Employee, and Insurance have inheritance strategy "new-table". \ +PartTimeEmployee, FullTimeEmployee, MedicalInsurance, and DentalInsurance \ +have inheritance strategy "superclass-table". +jdo.tck.classes = org.apache.jdo.tck.mapping.CompletenessTest +jdo.tck.testdata = org/apache/jdo/tck/pc/company/companyAllRelationships.xml +jdo.tck.mapping = 4 --Apple-Mail-48--522414787 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=ISO-8859-1

Some of these throw = exceptions due to JPOX not mapping the schema.

Erik, Andy,=A0

Can you run these = configurations and give us some feedback on the errors? "Class = "org.apache.jdo.tck.pc.company.Employee" has been specified to use = "subclass-table" inheritance strategy yet has at least one field = ("hradvisees") that is a Collection/Map. This is not currently supported = by JPOX."

Thanks,

Craig

On Sep 5, 2005, at 2:10 PM, Michael Bouschen wrote:

Hi Craig,

looks good!

Two = minors:
- The patch file misses a = newline at the end of the file which causes problems when applying the = patch. Could you please check whether file companyNoRelationships.xml = has a newline at the end?

I've added new lines to all the = test data files.

- Do we use upper case letters for names of = constants? If yes you might want to change the name of = factoryPropertyName and defaultFactoryClassName in class = CompanyFactoryRegistry.

Yes. I've changed them to their = upper case equivalents.

Craig

Regards Michael


Hi = Michael,

Thanks for the comments. A final code review is = attached. I'll send the xml file updates as a separate review.



On Sep = 5, 2005, at 9:39 AM, Michael Bouschen wrote:


Hi Craig,

I like = the idea of using the xml bean factory instance pattern instead of the = static bean factory. I was not aware that I can add a bean instance to = the CompanyModelReader using an API such as addSingleton instead of = defining in xml. This solves the problem of attaching the current pm to = the company factory which is then used by the CompanyModelReader when = creating pc instances.
A few remarks about the = patch:
- Today = CompanyFactoryRegistry.registerFactory takes the name of the company = factory class as an argument. This means all the callers need to get the = value of the system property jdo.tck.mapping.companyfactory and pass = this to the call. Would it make sense to add another method = registerFactory taking just the PM:
=A0 =A0 public static final = String companyFactoryClassName =3D
=A0 =A0 =A0 =A0 = System.getProperty("jdo.tck.mapping.companyfactory");

=A0 =A0 public static void = registerFactory(PersistenceManager pm) {
=A0 =A0 =A0 =A0 = registerFactory(companyFactoryClassName, pm);
=A0 =A0 = }
This keeps the handling of the = property jdo.tck.mapping.companyfactory local in class = CompanyFactoryRegistry.



Good.



- Class CompanyModelReader should define a constant = for the name of the companyFactory bean in the xml:
=A0 =A0 = public static final String COMPANY_FACTORY_BEAN =3D = "companyFactory";
It is used in the addSingleton = call in method configureFactory.




=

- The patch includes a changed = version of derby.property where you uncommented the special Mac property = for derby. I guess you are not going to check in this change, = correct?



Correct.



Regards = Michael



Javadogs,
Please check out the Wiki page http://wiki.apach= e.org/jdo/PersistentInterfaces and this patch.
I've tested the companyNoRelationships.xml but = haven't updated the other testdata files, pending a review. The idea is = to replace the testdata xml files with the factory concept so they can = be used by the standard CompletenessTest as well as the interface = test.
Craig
=3D
Craig Russell
http://java.sun.com/products/jdo=
408 276-5638 mailto:Craig.Russell@sun.com
P.S. A good JDO? O, Gasp!




--=A0
Michael = Bouschen=A0 =A0 =A0 =A0 = Tech@Spree Engineering GmbH
mailto:mbo.tech@spree.de=A0 =A0 = http://www.tech.spree.de/
=A0 =A0 =A0= =A0 Buelowstr. 66=A0 =A0 =A0= =A0 =A0 =A0 Fax.:++49/30/2175 2012=A0 =A0 =A0 =A0 D-10783 Berlin = =A0 =A0 =A0 =A0 =A0 =A0
=

Craig Russell

Architect, Sun Java Enterprise = System http://java.sun.com/products/jdo=

408 276-5638 mailto:Craig.Russell@sun.com

P.S. A = good JDO? O, Gasp!

=3D




--=A0
Michael = Bouschen=A0 =A0 =A0 =A0 Tech@Spree = Engineering GmbH
mailto:mbo.tech@spree.de=A0 = =A0 http://www.tech.spree.de/
=A0 =A0 =A0 =A0 Buelowstr. = 66 =A0 =A0 =A0 =A0 =A0 = =A0
Fax.:++49/30/2175 2012=A0 = =A0 =A0 =A0 D-10783 Berlin =A0 = =A0 =A0 =A0 =A0 =A0



Craig Russell

Architect, Sun Java = Enterprise System http://java.sun.com/products/jdo=

408 = 276-5638 mailto:Craig.Russell@sun.com

P.S. A = good JDO? O, Gasp!


= --Apple-Mail-48--522414787-- --Apple-Mail-47--522414787-- --Apple-Mail-49--522414475 Content-Transfer-Encoding: base64 Content-Type: application/pkcs7-signature; name=smime.p7s Content-Disposition: attachment; filename=smime.p7s MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIGHjCCAtcw ggJAoAMCAQICAw3FWTANBgkqhkiG9w0BAQQFADBiMQswCQYDVQQGEwJaQTElMCMGA1UEChMcVGhh d3RlIENvbnN1bHRpbmcgKFB0eSkgTHRkLjEsMCoGA1UEAxMjVGhhd3RlIFBlcnNvbmFsIEZyZWVt YWlsIElzc3VpbmcgQ0EwHhcNMDUwMTEwMDA0MTA5WhcNMDYwMTEwMDA0MTA5WjBHMR8wHQYDVQQD ExZUaGF3dGUgRnJlZW1haWwgTWVtYmVyMSQwIgYJKoZIhvcNAQkBFhVDcmFpZy5SdXNzZWxsQFN1 bi5DT00wggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQDti7ZE4rO6oXKbLM02AG9WY55t udmBVL53fb3V3X5S1kvcJOk1NEMIYT/T7Ww+/hE955zvHT29+mIoNe8AW/yj1WUH8uGG2HxhwCHI UQTHmN/ioVJgjwUaYbtNMKbL/NRpnL0QWewdMJS+6IFzFyX7ADFW5cJ+UWNLvNeWAQtN0mtLildn vdOgh50i8YPvACNkCHoomGjXx0azcXbe1X3c5AgRI6e2CZe5k2lRFQFUMqkjdoMtQPoNqJ1BxH9l i4cnabl8mcTwHHl44hrvb8ThqwRf2pfJh2vVuwmgK6z4IWjOk4RQM+0ODsRdq67mBdimJYmPMK1p RMBHzrUsfKxNAgMBAAGjMjAwMCAGA1UdEQQZMBeBFUNyYWlnLlJ1c3NlbGxAU3VuLkNPTTAMBgNV HRMBAf8EAjAAMA0GCSqGSIb3DQEBBAUAA4GBAIj86LzxCHedStDLMEeqHLy+UFG7zIRHfChSIV42 +MvXicydXEBh8v0Ry1V2d/lY4jS78G5yW5R9fKt1U5nlRBCOVzdhomvSolnNRIT71wPVVDrAIVlA YpXKxSmVBq7+4hV+3ZLHDeq3qZnNmiJR0sTEUD16xZX1RJs9dRYPCHoRMIIDPzCCAqigAwIBAgIB DTANBgkqhkiG9w0BAQUFADCB0TELMAkGA1UEBhMCWkExFTATBgNVBAgTDFdlc3Rlcm4gQ2FwZTES MBAGA1UEBxMJQ2FwZSBUb3duMRowGAYDVQQKExFUaGF3dGUgQ29uc3VsdGluZzEoMCYGA1UECxMf Q2VydGlmaWNhdGlvbiBTZXJ2aWNlcyBEaXZpc2lvbjEkMCIGA1UEAxMbVGhhd3RlIFBlcnNvbmFs IEZyZWVtYWlsIENBMSswKQYJKoZIhvcNAQkBFhxwZXJzb25hbC1mcmVlbWFpbEB0aGF3dGUuY29t MB4XDTAzMDcxNzAwMDAwMFoXDTEzMDcxNjIzNTk1OVowYjELMAkGA1UEBhMCWkExJTAjBgNVBAoT HFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBG cmVlbWFpbCBJc3N1aW5nIENBMIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDEpjxVc1X7TrnK mVoeaMB1BHCd3+n/ox7svc31W/Iadr1/DDph8r9RzgHU5VAKMNcCY1osiRVwjt3J8CuFWqo/cVbL rzwLB+fxH5E2JCoTzyvV84J3PQO+K/67GD4Hv0CAAmTXp6a7n2XRxSpUhQ9IBH+nttE8YQRAHmQZ cmC3+wIDAQABo4GUMIGRMBIGA1UdEwEB/wQIMAYBAf8CAQAwQwYDVR0fBDwwOjA4oDagNIYyaHR0 cDovL2NybC50aGF3dGUuY29tL1RoYXd0ZVBlcnNvbmFsRnJlZW1haWxDQS5jcmwwCwYDVR0PBAQD AgEGMCkGA1UdEQQiMCCkHjAcMRowGAYDVQQDExFQcml2YXRlTGFiZWwyLTEzODANBgkqhkiG9w0B AQUFAAOBgQBIjNFQg+oLLswNo2asZw9/r6y+whehQ5aUnX9MIbj4Nh+qLZ82L8D0HFAgk3A8/a3h YWLD2ToZfoSxmRsAxRoLgnSeJVCUYsfbJ3FXJY3dqZw5jowgT2Vfldr394fWxghOrvbqNOUQGls1 TXfjViF4gtwhGTXeJLHTHUb/XV9lTzGCAucwggLjAgEBMGkwYjELMAkGA1UEBhMCWkExJTAjBgNV BAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25h bCBGcmVlbWFpbCBJc3N1aW5nIENBAgMNxVkwCQYFKw4DAhoFAKCCAVMwGAYJKoZIhvcNAQkDMQsG CSqGSIb3DQEHATAcBgkqhkiG9w0BCQUxDxcNMDUwOTA1MjI1OTE3WjAjBgkqhkiG9w0BCQQxFgQU KV+45N+3EsQKxoPqtmUvPoISNr4weAYJKwYBBAGCNxAEMWswaTBiMQswCQYDVQQGEwJaQTElMCMG A1UEChMcVGhhd3RlIENvbnN1bHRpbmcgKFB0eSkgTHRkLjEsMCoGA1UEAxMjVGhhd3RlIFBlcnNv bmFsIEZyZWVtYWlsIElzc3VpbmcgQ0ECAw3FWTB6BgsqhkiG9w0BCRACCzFroGkwYjELMAkGA1UE BhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1Ro YXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBAgMNxVkwDQYJKoZIhvcNAQEBBQAEggEA CKDq2Z5mcV5hlxKqABjpfdfESKO4JZPsC+S8H8XCnz80mixswx5YSqcLJ5caGSeLUsKg3OqF4/H4 pb8xijehivZaAI87buX0ca6PLlcSTt03dDIv1ivI2UnXzmq7Xlecw5he9wAArlgGmYfMuyj5dJr1 gkSXqinsJvKU2RE8q22W8syP84KP3cxkMrlTUvv6xKEoOu84jNaJyiEESxCTF2vP+A8jIhcswnxh zdAr/8TQSDWEywGTkZv51x+/WHY+XCYoY4hp3xHu+UYEeT3TvbLPBX9pS6sXOtNeB027vUaZlYRR bLZtvjk2V6CHjEeKZtoi8mBUO7VT3Ku+U2os5AAAAAAAAA== --Apple-Mail-49--522414475--