db-jdo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Craig Russell <Craig.Russ...@Sun.COM>
Subject Re: JDO-135
Date Wed, 14 Sep 2005 01:05:43 GMT
Hi Karan,

Patch looks good. I've checked it in.

Thanks!

Craig

On Sep 13, 2005, at 5:22 PM, karan malhi wrote:

> Hi Craig,
>
> I have attached the patches for this issue
>
> Craig Russell wrote:
>
>
>> Hi Karan,
>>
>> I just filed a bug that you might take a look at, JDO-135.
>>
>> This is the only issue that I know of compiling JDO under JDK 5.
>>
>> Craig
>>
>> Craig Russell
>>
>> Architect, Sun Java Enterprise System http://java.sun.com/products/ 
>> jdo
>>
>> 408 276-5638 mailto:Craig.Russell@sun.com
>>
>> P.S. A good JDO? O, Gasp!
>>
>>
>>
>
> -- 
> Karan Singh
>
> Index: src/java/org/apache/jdo/impl/pm/PersistenceManagerImpl.java
> ===================================================================
> --- src/java/org/apache/jdo/impl/pm/PersistenceManagerImpl.java     
> (revision 280719)
> +++ src/java/org/apache/jdo/impl/pm/PersistenceManagerImpl.java     
> (working copy)
> @@ -1576,10 +1576,10 @@
>          Object obj = null;
>
>          try {
> -            Constructor constr = newType.getConstructor(null);
> +            Constructor constr = newType.getConstructor((Class[]) 
> null);
>
>              if (constr != null) {
> -                obj = constr.newInstance(null);
> +                obj = constr.newInstance((Object[])null);
>              }
>          } catch (Exception e) {
>              throw new JDOUserException(msg.msg(
> Index: test/java/org/apache/jdo/tck/enhancement/EnhancerTest.java
> ===================================================================
> --- test/java/org/apache/jdo/tck/enhancement/EnhancerTest.java     
> (revision 280719)
> +++ test/java/org/apache/jdo/tck/enhancement/EnhancerTest.java     
> (working copy)
> @@ -71,14 +71,14 @@
>           */
>          Properties classesToTest = getProperties("enhancement- 
> test.properties"); //NOI18N
>
> -        Enumeration enum = classesToTest.propertyNames();
> +        Enumeration enumeration = classesToTest.propertyNames();
>          int numberOfPackages = 0;
>
>          /** Each key is a package name; the value is a list of  
> class names to test.
>           */
> -        while (enum.hasMoreElements()) {
> +        while (enumeration.hasMoreElements()) {
>              ++numberOfPackages;
> -            String packageName = (String) enum.nextElement();
> +            String packageName = (String) enumeration.nextElement();
>              if (debug) logger.debug("EnhancerTest Package: " +  
> packageName);
>              String classNames = (String) classesToTest.get 
> (packageName);
>              if (debug) logger.debug("EnhancerTest Classes: " +  
> classNames);
>

Craig Russell
Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
408 276-5638 mailto:Craig.Russell@sun.com
P.S. A good JDO? O, Gasp!


Mime
View raw message