db-jdo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Bouschen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JDO-140) Add get/setRollbackOnly tests
Date Sat, 24 Sep 2005 18:13:28 GMT
    [ http://issues.apache.org/jira/browse/JDO-140?page=comments#action_12330391 ] 

Michael Bouschen commented on JDO-140:

I have one comment about GetRollbackOnlyReturnsFalseUntilSet:

The assertion text of A13.4.5-2 has been changed in the current version o fthe spec: "When
a transaction is not active, and after a transaction is begun, getRollbackOnly will return
false. Once setRollbackOnly has been called, it will return true until commit or rollback
is called."

The test case implementation already covers the new version of the assertion text. I just
propose to adapt the assertion text in the javadoc of the test case and in the spreadsheet.

> Add get/setRollbackOnly tests
> -----------------------------
>          Key: JDO-140
>          URL: http://issues.apache.org/jira/browse/JDO-140
>      Project: JDO
>         Type: Test
>   Components: tck20
>  Environment: TCK
>     Reporter: Craig Russell
>     Assignee: Craig Russell
>  Attachments: jdo140patch.txt
> There are two test classes for get/setRollbackOnly.
> One test class transactions.AfterSetRollbackOnlyCommitFails tests assertion A13.4.5-1

> Once a transaction has been marked for rollback via setRollbackOnly, the commit method
will always fail with JDOFatalDataStoreException. 
> The strategy is to begin a transaction, set rollback only, and commit. The expected behavior
is to catch an exception.
> The second test class transactions.GetRollbackOnlyReturnsFalseUntilSet tests assertion
> After a transaction is begun, getRollbackOnly will return false until set commit or rollback
is called.
> The strategy is to begin a transaction, test that getRollbackOnly is false, setRollbackOnly,
and test that getRollbackOnly is true.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
For more information on JIRA, see:

View raw message