Return-Path: Delivered-To: apmail-db-jdo-dev-archive@www.apache.org Received: (qmail 85724 invoked from network); 12 Aug 2005 18:33:13 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 12 Aug 2005 18:33:13 -0000 Received: (qmail 81356 invoked by uid 500); 12 Aug 2005 18:33:13 -0000 Mailing-List: contact jdo-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jdo-dev@db.apache.org Delivered-To: mailing list jdo-dev@db.apache.org Received: (qmail 81342 invoked by uid 99); 12 Aug 2005 18:33:13 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Aug 2005 11:33:13 -0700 X-ASF-Spam-Status: No, hits=0.5 required=10.0 tests=HTML_MESSAGE,UPPERCASE_75_100 X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [192.18.98.34] (HELO brmea-mail-3.sun.com) (192.18.98.34) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Aug 2005 11:33:33 -0700 Received: from fe2.sun.com ([192.18.108.79]) by brmea-mail-3.sun.com (8.12.10/8.12.9) with ESMTP id j7CIX4vU014300 for ; Fri, 12 Aug 2005 12:33:04 -0600 (MDT) Received: from conversion-daemon.fe2.sun.com by fe2.sun.com (Sun Java System Messaging Server 6.1 HotFix 0.02 (built Aug 25 2004)) id <0IL400E01FHUEP00@fe2.sun.com> (original mail from Craig.Russell@Sun.COM) for jdo-dev@db.apache.org; Fri, 12 Aug 2005 12:33:04 -0600 (MDT) Received: from [129.144.88.147] by fe2.sun.com (Sun Java System Messaging Server 6.1 HotFix 0.02 (built Aug 25 2004)) with ESMTPSA id <0IL400EFVGV3HF70@fe2.sun.com> for jdo-dev@db.apache.org; Fri, 12 Aug 2005 12:33:03 -0600 (MDT) Date: Fri, 12 Aug 2005 11:33:07 -0700 From: Craig Russell Subject: Re: TestCollectionCollections [JIRA-105] In-reply-to: <312C10D4-E16A-4B2E-BFB1-9F3243912372@Sun.COM> To: jdo-dev@db.apache.org Message-id: <286484DC-2FAB-45F9-81CE-6473B69E2A0F@Sun.COM> MIME-version: 1.0 X-Mailer: Apple Mail (2.733) Content-type: multipart/alternative; boundary="Boundary_(ID_SVD9y9h4ZEmKv3geM9y9Ww)" References: <200508121335.12879.andy@jpox.org> <42FC9B12.6000305@spree.de> <200508121402.59903.andy@jpox.org> <42FCA7EA.4030004@spree.de> <42FCB6E4.4060209@spree.de> <312C10D4-E16A-4B2E-BFB1-9F3243912372@Sun.COM> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N --Boundary_(ID_SVD9y9h4ZEmKv3geM9y9Ww) Content-type: text/plain; format=flowed; delsp=yes; charset=US-ASCII Content-transfer-encoding: 7BIT Hi Michael, Please hold off any changes. Michelle is going to be working on the schema and orm files based on our discussion at the TCK conference call. So Michelle will update the schema and orm to match. Thanks, Craig On Aug 12, 2005, at 11:27 AM, Craig Russell wrote: > Hi Michael, > > This patch failed to apply. There were some changes to the schema > since your patch. > > Craig > > On Aug 12, 2005, at 7:49 AM, Michael Watzek wrote: > > >> Hi, >> >> please find the patch fixing the mismatch between ORM metadata and >> schema wrt classes "CollectionCollections", >> "ArrayListCollections", and "TreeMapStringKeyCollections". >> >> Note, that the tests "TestCollectionCollections" etc. still fail. >> That's why I filed a new issue (JDO-119). I changed the status to >> resolved. >> >> Regards, >> Michael >> >> >>> Hi Andy, >>> >>> >>>> Hi Michael, >>>> >>>> >>>> >>>> >>>>> you are right: The ORM metadata does not match the schema. A >>>>> while ago, >>>>> I have fixed the same issue in classes "HashXXX", "ListXXX", >>>>> "MapXXX" >>>>> etc. Obviously, I have overlooked the issue in class >>>>> "CollectionCollections". I'll fix this and I'll also check classes >>>>> "ArrayXXX". >>>>> >>>>> >>>> >>>> >>>> >>>> Thanks. It's only CollectionCollections that has this problem - >>>> I've already checked! >>>> >>>> >>> Actually, ArrayCollections is correct but ArrayListCollections >>> has the same issue. And there are two leftovers in >>> TreeMapStringKeyCollections. I'll send a patch today. >>> Regards, >>> Michael >>> >>> >>>> >>>> Once this issue is fixed then all of the HashXXX, ListXXX, >>>> CollectionXXX, MapXXX, ArrayListXXX will need a fix adding for >>>> JDO-106 (I've commented the JIRA for that one with what the >>>> problem is there). >>>> >>>> >>>> >>>> >> >> >> -- >> ------------------------------------------------------------------- >> Michael Watzek Tech@Spree Engineering GmbH >> mailto:mwa.tech@spree.de Buelowstr. 66 >> Tel.: ++49/30/235 520 36 10783 Berlin - Germany >> Fax.: ++49/30/217 520 12 http://www.spree.de/ >> ------------------------------------------------------------------- >> Index: test/sql/derby/datastoreidentity/schema.sql >> =================================================================== >> --- test/sql/derby/datastoreidentity/schema.sql (revision 232227) >> +++ test/sql/derby/datastoreidentity/schema.sql (working copy) >> @@ -2869,37 +2869,37 @@ >> CREATE TABLE COLLECTION_OF_SIMPLE_CLASS3 >> ( >> IDENTIFIER INTEGER REFERENCES COLLECTION_COLLECTIONS NOT NULL, >> - SIMPINTERFREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL >> + SIMPCLSREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL >> ); >> >> CREATE TABLE COLLECTION_OF_SIMPLE_CLASS4 >> ( >> IDENTIFIER INTEGER REFERENCES COLLECTION_COLLECTIONS NOT NULL, >> - SIMPINTERFREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL >> + SIMPCLSREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL >> ); >> >> CREATE TABLE COLLECTION_OF_SIMPLE_CLASS5 >> ( >> IDENTIFIER INTEGER REFERENCES COLLECTION_COLLECTIONS NOT NULL, >> - SIMPINTERFREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL >> + SIMPCLSREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL >> ); >> >> CREATE TABLE COLLECTION_OF_SIMPLE_INTERFACE6 >> ( >> IDENTIFIER INTEGER REFERENCES COLLECTION_COLLECTIONS NOT NULL, >> - SIMPINTERFREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL >> + SIMPINTREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL >> ); >> >> CREATE TABLE COLLECTION_OF_SIMPLE_INTERFACE7 >> ( >> IDENTIFIER INTEGER REFERENCES COLLECTION_COLLECTIONS NOT NULL, >> - SIMPINTERFREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL >> + SIMPINTREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL >> ); >> >> CREATE TABLE COLLECTION_OF_SIMPLE_INTERFACE8 >> ( >> IDENTIFIER INTEGER REFERENCES COLLECTION_COLLECTIONS NOT NULL, >> - SIMPINTERFREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL >> + SIMPINTREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL >> ); >> >> CREATE TABLE COLLECTION_OF_STRING9 >> @@ -3315,42 +3315,42 @@ >> CREATE TABLE ARRAYLIST_OF_SIMPLE_CLASS3 >> ( >> IDENTIFIER INTEGER REFERENCES ARRAYLIST_COLLECTIONS NOT NULL, >> - SIMPINTERFREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL, >> + SIMPCLSREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL, >> INDEX INTEGER NOT NULL >> ); >> >> CREATE TABLE ARRAYLIST_OF_SIMPLE_CLASS4 >> ( >> IDENTIFIER INTEGER REFERENCES ARRAYLIST_COLLECTIONS NOT NULL, >> - SIMPINTERFREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL, >> + SIMPCLSREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL, >> INDEX INTEGER NOT NULL >> ); >> >> CREATE TABLE ARRAYLIST_OF_SIMPLE_CLASS5 >> ( >> IDENTIFIER INTEGER REFERENCES ARRAYLIST_COLLECTIONS NOT NULL, >> - SIMPINTERFREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL, >> + SIMPCLSREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL, >> INDEX INTEGER NOT NULL >> ); >> >> CREATE TABLE ARRAYLIST_OF_SIMPLE_INTERFACE6 >> ( >> IDENTIFIER INTEGER REFERENCES ARRAYLIST_COLLECTIONS NOT NULL, >> - SIMPINTERFREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL, >> + SIMPINTREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL, >> INDEX INTEGER NOT NULL >> ); >> >> CREATE TABLE ARRAYLIST_OF_SIMPLE_INTERFACE7 >> ( >> IDENTIFIER INTEGER REFERENCES ARRAYLIST_COLLECTIONS NOT NULL, >> - SIMPINTERFREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL, >> + SIMPINTREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL, >> INDEX INTEGER NOT NULL >> ); >> >> CREATE TABLE ARRAYLIST_OF_SIMPLE_INTERFACE8 >> ( >> IDENTIFIER INTEGER REFERENCES ARRAYLIST_COLLECTIONS NOT NULL, >> - SIMPINTERFREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL, >> + SIMPINTREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL, >> INDEX INTEGER NOT NULL >> ); >> >> @@ -6881,7 +6881,7 @@ >> ( >> IDENTIFIER INTEGER REFERENCES TREEMAPSTRINGKEY_COLLECTIONS >> NOT NULL, >> KEYVAL VARCHAR(100) NOT NULL, >> - SIMPINTERFREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL, >> + SIMPINTREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL, >> INDEX INTEGER NOT NULL >> ); >> >> @@ -6889,7 +6889,7 @@ >> ( >> IDENTIFIER INTEGER REFERENCES TREEMAPSTRINGKEY_COLLECTIONS >> NOT NULL, >> KEYVAL VARCHAR(100) NOT NULL, >> - SIMPINTERFREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL, >> + SIMPINTREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL, >> INDEX INTEGER NOT NULL >> ); >> >> Index: test/sql/derby/applicationidentity/schema.sql >> =================================================================== >> --- test/sql/derby/applicationidentity/schema.sql (revision >> 232227) >> +++ test/sql/derby/applicationidentity/schema.sql (working copy) >> @@ -2893,37 +2893,37 @@ >> CREATE TABLE COLLECTION_OF_SIMPLE_CLASS3 >> ( >> IDENTIFIER INTEGER REFERENCES COLLECTION_COLLECTIONS NOT NULL, >> - SIMPINTERFREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL >> + SIMPCLSREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL >> ); >> >> CREATE TABLE COLLECTION_OF_SIMPLE_CLASS4 >> ( >> IDENTIFIER INTEGER REFERENCES COLLECTION_COLLECTIONS NOT NULL, >> - SIMPINTERFREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL >> + SIMPCLSREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL >> ); >> >> CREATE TABLE COLLECTION_OF_SIMPLE_CLASS5 >> ( >> IDENTIFIER INTEGER REFERENCES COLLECTION_COLLECTIONS NOT NULL, >> - SIMPINTERFREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL >> + SIMPCLSREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL >> ); >> >> CREATE TABLE COLLECTION_OF_SIMPLE_INTERFACE6 >> ( >> IDENTIFIER INTEGER REFERENCES COLLECTION_COLLECTIONS NOT NULL, >> - SIMPINTERFREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL >> + SIMPINTREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL >> ); >> >> CREATE TABLE COLLECTION_OF_SIMPLE_INTERFACE7 >> ( >> IDENTIFIER INTEGER REFERENCES COLLECTION_COLLECTIONS NOT NULL, >> - SIMPINTERFREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL >> + SIMPINTREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL >> ); >> >> CREATE TABLE COLLECTION_OF_SIMPLE_INTERFACE8 >> ( >> IDENTIFIER INTEGER REFERENCES COLLECTION_COLLECTIONS NOT NULL, >> - SIMPINTERFREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL >> + SIMPINTREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL >> ); >> >> CREATE TABLE COLLECTION_OF_STRING9 >> @@ -3337,42 +3337,42 @@ >> CREATE TABLE ARRAYLIST_OF_SIMPLE_CLASS3 >> ( >> IDENTIFIER INTEGER REFERENCES ARRAYLIST_COLLECTIONS NOT NULL, >> - SIMPINTERFREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL, >> + SIMPCLSREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL, >> INDEX INTEGER NOT NULL >> ); >> >> CREATE TABLE ARRAYLIST_OF_SIMPLE_CLASS4 >> ( >> IDENTIFIER INTEGER REFERENCES ARRAYLIST_COLLECTIONS NOT NULL, >> - SIMPINTERFREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL, >> + SIMPCLSREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL, >> INDEX INTEGER NOT NULL >> ); >> >> CREATE TABLE ARRAYLIST_OF_SIMPLE_CLASS5 >> ( >> IDENTIFIER INTEGER REFERENCES ARRAYLIST_COLLECTIONS NOT NULL, >> - SIMPINTERFREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL, >> + SIMPCLSREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL, >> INDEX INTEGER NOT NULL >> ); >> >> CREATE TABLE ARRAYLIST_OF_SIMPLE_INTERFACE6 >> ( >> IDENTIFIER INTEGER REFERENCES ARRAYLIST_COLLECTIONS NOT NULL, >> - SIMPINTERFREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL, >> + SIMPINTREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL, >> INDEX INTEGER NOT NULL >> ); >> >> CREATE TABLE ARRAYLIST_OF_SIMPLE_INTERFACE7 >> ( >> IDENTIFIER INTEGER REFERENCES ARRAYLIST_COLLECTIONS NOT NULL, >> - SIMPINTERFREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL, >> + SIMPINTREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL, >> INDEX INTEGER NOT NULL >> ); >> >> CREATE TABLE ARRAYLIST_OF_SIMPLE_INTERFACE8 >> ( >> IDENTIFIER INTEGER REFERENCES ARRAYLIST_COLLECTIONS NOT NULL, >> - SIMPINTERFREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL, >> + SIMPINTREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL, >> INDEX INTEGER NOT NULL >> ); >> >> @@ -6890,7 +6890,7 @@ >> ( >> IDENTIFIER INTEGER REFERENCES TREEMAPSTRINGKEY_COLLECTIONS >> NOT NULL, >> KEYVAL VARCHAR(100) NOT NULL, >> - SIMPINTERFREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL, >> + SIMPINTREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL, >> INDEX INTEGER NOT NULL >> ); >> >> @@ -6898,7 +6898,7 @@ >> ( >> IDENTIFIER INTEGER REFERENCES TREEMAPSTRINGKEY_COLLECTIONS >> NOT NULL, >> KEYVAL VARCHAR(100) NOT NULL, >> - SIMPINTERFREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL, >> + SIMPINTREF BIGINT REFERENCES SIMPLE_CLASS NOT NULL, >> INDEX INTEGER NOT NULL >> ); >> >> >> > > Craig Russell > Architect, Sun Java Enterprise System http://java.sun.com/products/jdo > 408 276-5638 mailto:Craig.Russell@sun.com > P.S. A good JDO? O, Gasp! > > Craig Russell Architect, Sun Java Enterprise System http://java.sun.com/products/jdo 408 276-5638 mailto:Craig.Russell@sun.com P.S. A good JDO? O, Gasp! --Boundary_(ID_SVD9y9h4ZEmKv3geM9y9Ww)--