db-jdo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Craig Russell <Craig.Russ...@Sun.COM>
Subject Re: TestFieldsOfObject patch
Date Sat, 20 Aug 2005 23:25:48 GMT
Hi Michelle,

The test from JDO 1.0 would probably not pass most non-object  
database JDO implementations. I'm disappointed that no one (many  
claimed to have passed the JDO 1.0 TCK) complained about this test.

The changes you suggest are fine with me.

Craig

On Aug 20, 2005, at 8:58 AM, Michelle Caisse wrote:

> Any objections?
>
> -- Michelle
> Index: test/java/org/apache/jdo/tck/models/fieldtypes/ 
> TestFieldsOfObject.java
> ===================================================================
> --- test/java/org/apache/jdo/tck/models/fieldtypes/ 
> TestFieldsOfObject.java    (revision 231272)
> +++ test/java/org/apache/jdo/tck/models/fieldtypes/ 
> TestFieldsOfObject.java    (working copy)
> @@ -21,6 +21,7 @@
>
>  import org.apache.jdo.tck.JDO_Test;
>  import org.apache.jdo.tck.pc.fieldtypes.FieldsOfObject;
> +import org.apache.jdo.tck.pc.fieldtypes.SimpleClass;
>  import org.apache.jdo.tck.util.BatchTestRunner;
>
>  /**
> @@ -77,8 +78,8 @@
>          Transaction tx = pm.currentTransaction();
>          try {
>              int i, n;
> -            Object firstValue = new String("Hello");
> -            Object secondValue = new Integer("420");
> +            Object firstValue = new SimpleClass(1, "Hello");
> +            Object secondValue = new SimpleClass(333, "420");
>              tx.begin();
>              FieldsOfObject pi = new FieldsOfObject();
>              pi.identifier = 1;
>

Craig Russell
Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
408 276-5638 mailto:Craig.Russell@sun.com
P.S. A good JDO? O, Gasp!


Mime
View raw message