Return-Path: Delivered-To: apmail-db-jdo-dev-archive@www.apache.org Received: (qmail 54562 invoked from network); 25 Jul 2005 16:05:59 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 25 Jul 2005 16:05:59 -0000 Received: (qmail 30385 invoked by uid 500); 25 Jul 2005 16:05:58 -0000 Mailing-List: contact jdo-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jdo-dev@db.apache.org Delivered-To: mailing list jdo-dev@db.apache.org Received: (qmail 30362 invoked by uid 99); 25 Jul 2005 16:05:58 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Jul 2005 09:05:58 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=HTML_MESSAGE X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [192.18.98.34] (HELO brmea-mail-3.sun.com) (192.18.98.34) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Jul 2005 09:05:51 -0700 Received: from fe3.sun.com (fe3.Sun.COM [192.18.108.80] (may be forged)) by brmea-mail-3.sun.com (8.12.10/8.12.9) with ESMTP id j6PG5uvU024835; Mon, 25 Jul 2005 10:05:56 -0600 (MDT) Received: from conversion-daemon.fe3.sun.com by fe3.sun.com (Sun Java System Messaging Server 6.1 HotFix 0.02 (built Aug 25 2004)) id <0IK600K01XU7HW00@fe3.sun.com> (original mail from Craig.Russell@Sun.COM) ; Mon, 25 Jul 2005 10:05:56 -0600 (MDT) Received: from [129.145.133.145] by fe3.sun.com (Sun Java System Messaging Server 6.1 HotFix 0.02 (built Aug 25 2004)) with ESMTPSA id <0IK600M77Y1VBTB2@fe3.sun.com>; Mon, 25 Jul 2005 10:05:56 -0600 (MDT) Date: Mon, 25 Jul 2005 09:05:56 -0700 From: Craig Russell Subject: Re: svn commit: r224397 - in /incubator/jdo/trunk/tck20/test/sql/derby: applicationidentity/schema.sql datastoreidentity/schema.sql In-reply-to: <42E4BCD4.8020307@spree.de> To: jdo-dev@db.apache.org, jdo-commits@db.apache.org Message-id: MIME-version: 1.0 X-Mailer: Apple Mail (2.733) Content-type: multipart/signed; protocol="application/pkcs7-signature"; boundary=Apple-Mail-23-118953512; micalg=sha1 References: <20050722205726.10287.qmail@minotaur.apache.org> <42E4BCD4.8020307@spree.de> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N --Apple-Mail-23-118953512 Content-Type: multipart/alternative; boundary=Apple-Mail-22-118952377 --Apple-Mail-22-118952377 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Hi Michael, The change was deliberate. Notice that there were two column types for char and Character, and Michelle and I changed the CHAR(1) to INTEGER instead of the other way 'round. For portability, INTEGER is better, as one the AllTypes data includes the entire range of CHAR values from 0..65535. Even though Derby can handle this with a CHAR(1) it will be better to have a more portable type. For other tests, where there are a limited set of possible values, we chose CHAR(1) as we think this is portable to any database. The philosophy is that we would like to have as little change as possible among the database mapping and schema, and only where there is a real incompatibility have to change. Craig On Jul 25, 2005, at 3:20 AM, Michael Watzek wrote: > Hi Craig, > > I noticed that you changed the type of column ALLTYPES.CHARACTERVAL > from > CHAR(1) to INTEGER. Did you check in this change accidently or > intentionally? In the latter case, I propose to change the type of > other CHAR(1) columns also (except for those which are mapped by > boolean fields): > > - PrimitiveTypes.charNotNull > - PrimitiveTypes.charNull > > Note, that the type of these columns is CHAR which defaults to CHAR > (1). > > Regards, > Michael > > clr@apache.org wrote: > >> Author: clr >> Date: Fri Jul 22 13:57:22 2005 >> New Revision: 224397 >> URL: http://svn.apache.org/viewcvs?rev=224397&view=rev >> Log: >> change type of char column to INTEGER to accommodate 65535 >> Modified: >> incubator/jdo/trunk/tck20/test/sql/derby/applicationidentity/ >> schema.sql >> incubator/jdo/trunk/tck20/test/sql/derby/datastoreidentity/ >> schema.sql >> Modified: incubator/jdo/trunk/tck20/test/sql/derby/ >> applicationidentity/schema.sql >> URL: http://svn.apache.org/viewcvs/incubator/jdo/trunk/tck20/test/ >> sql/derby/applicationidentity/schema.sql? >> rev=224397&r1=224396&r2=224397&view=diff >> ===================================================================== >> ========= >> --- incubator/jdo/trunk/tck20/test/sql/derby/applicationidentity/ >> schema.sql (original) >> +++ incubator/jdo/trunk/tck20/test/sql/derby/applicationidentity/ >> schema.sql Fri Jul 22 13:57:22 2005 >> @@ -868,7 +868,7 @@ >> PRIMITIVESHORT SMALLINT, >> BOOLEANVAL CHAR(1) CHECK (BOOLEANVAL IN ('Y','N')), >> BYTEVAL SMALLINT, >> - CHARACTERVAL CHAR(1), >> + CHARACTERVAL INTEGER, >> DOUBLEVAL DOUBLE, >> FLOATVAL FLOAT, >> INTEGERVAL INTEGER, >> Modified: incubator/jdo/trunk/tck20/test/sql/derby/ >> datastoreidentity/schema.sql >> URL: http://svn.apache.org/viewcvs/incubator/jdo/trunk/tck20/test/ >> sql/derby/datastoreidentity/schema.sql? >> rev=224397&r1=224396&r2=224397&view=diff >> ===================================================================== >> ========= >> --- incubator/jdo/trunk/tck20/test/sql/derby/datastoreidentity/ >> schema.sql (original) >> +++ incubator/jdo/trunk/tck20/test/sql/derby/datastoreidentity/ >> schema.sql Fri Jul 22 13:57:22 2005 >> @@ -817,7 +817,7 @@ >> PRIMITIVESHORT SMALLINT, >> BOOLEANVAL CHAR(1)CHECK (BOOLEANVAL IN ('Y','N')), >> BYTEVAL SMALLINT, >> - CHARACTERVAL CHAR(1), >> + CHARACTERVAL INTEGER, >> DOUBLEVAL DOUBLE, >> FLOATVAL FLOAT, >> INTEGERVAL INTEGER, >> > > > -- > ------------------------------------------------------------------- > Michael Watzek Tech@Spree Engineering GmbH > mailto:mwa.tech@spree.de Buelowstr. 66 > Tel.: ++49/30/235 520 36 10783 Berlin - Germany > Fax.: ++49/30/217 520 12 http://www.spree.de/ > ------------------------------------------------------------------- > > Craig Russell Architect, Sun Java Enterprise System http://java.sun.com/products/jdo 408 276-5638 mailto:Craig.Russell@sun.com P.S. A good JDO? O, Gasp! --Apple-Mail-22-118952377 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=ISO-8859-1 Hi Michael,

The change was deliberate. = Notice that there were two column types for char and Character, and = Michelle and I changed the CHAR(1) to INTEGER instead of the other way = 'round.

For = portability, INTEGER is better, as one the AllTypes data includes the = entire range of CHAR values from 0..65535. Even though Derby can handle = this with a CHAR(1) it will be better to have a more portable = type.

For = other tests, where there are a limited set of possible values, we chose = CHAR(1) as we think this is portable to any database.=A0

The philosophy is that we = would like to have as little change as possible among the database = mapping and schema, and only where there is a real incompatibility have = to change.

Craig

On Jul 25, 2005, at 3:20 AM, Michael Watzek wrote:

Hi Craig,

I noticed that you changed the = type of column ALLTYPES.CHARACTERVAL from
CHAR(1) = to INTEGER. Did you check in this change accidently or
intentionally? In the latter case, I propose to = change the type of other CHAR(1) columns also (except for those which = are mapped by boolean fields):

- = PrimitiveTypes.charNotNull
- = PrimitiveTypes.charNull

Note, that the type of these = columns is CHAR which defaults to CHAR(1).

Michael

=
Author: = clr
Date: Fri Jul 22 13:57:22 = 2005
New Revision: 224397
Log:
change type = of char column to INTEGER to accommodate 65535
Modified:
=A0 =A0 = incubator/jdo/trunk/tck20/test/sql/derby/applicationidentity/schema= .sql
=A0 =A0 = incubator/jdo/trunk/tck20/test/sql/derby/datastoreidentity/schema.s= ql
Modified: = incubator/jdo/trunk/tck20/test/sql/derby/applicationidentity/schema.sql
--- = incubator/jdo/trunk/tck20/test/sql/derby/applicationidentity/schema.sql = (original)
+++ = incubator/jdo/trunk/tck20/test/sql/derby/applicationidentity/schema.sql = Fri Jul 22 13:57:22 2005
@@ -868,7 = +868,7 @@
=A0=A0 =A0 PRIMITIVESHORT = SMALLINT,
=A0=A0 =A0 BOOLEANVAL CHAR(1) = CHECK (BOOLEANVAL IN ('Y','N')),
=A0=A0 =A0 BYTEVAL = SMALLINT,
-=A0 =A0 CHARACTERVAL = CHAR(1),
+=A0 =A0 CHARACTERVAL = INTEGER,
=A0=A0 =A0 DOUBLEVAL = DOUBLE,
=A0=A0 =A0 FLOATVAL = FLOAT,
=A0=A0 =A0 INTEGERVAL = INTEGER,
Modified: = incubator/jdo/trunk/tck20/test/sql/derby/datastoreidentity/schema.sql
--- = incubator/jdo/trunk/tck20/test/sql/derby/datastoreidentity/schema.sql = (original)
+++ = incubator/jdo/trunk/tck20/test/sql/derby/datastoreidentity/schema.sql = Fri Jul 22 13:57:22 2005
@@ -817,7 = +817,7 @@
=A0=A0 =A0 PRIMITIVESHORT = SMALLINT,
=A0=A0 =A0 BOOLEANVAL = CHAR(1)CHECK (BOOLEANVAL IN ('Y','N')),
=A0=A0 =A0 BYTEVAL = SMALLINT,
-=A0 =A0 CHARACTERVAL = CHAR(1),
+=A0 =A0 CHARACTERVAL = INTEGER,
=A0=A0 =A0 DOUBLEVAL = DOUBLE,
=A0=A0 =A0 FLOATVAL = FLOAT,
=A0=A0 =A0 INTEGERVAL = INTEGER,



--=A0
Michael Watzek=A0= =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 Tech@Spree Engineering = GmbH
mailto:mwa.tech@spree.de=A0 =A0 =A0 =A0 Buelowstr. = 66
Tel.:=A0 = ++49/30/235 520 36 =A0 =A0 = =A0 10783 Berlin - Germany
Fax.:=A0 ++49/30/217 520 12 =A0 =A0 =A0 http://www.spree.de/



Craig Russell

Architect, Sun Java = Enterprise System http://java.sun.com/products/jdo=

408 = 276-5638 mailto:Craig.Russell@sun.com

P.S. A = good JDO? O, Gasp!


= --Apple-Mail-22-118952377-- --Apple-Mail-23-118953512 Content-Transfer-Encoding: base64 Content-Type: application/pkcs7-signature; name=smime.p7s Content-Disposition: attachment; filename=smime.p7s MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIGHjCCAtcw ggJAoAMCAQICAw3FWTANBgkqhkiG9w0BAQQFADBiMQswCQYDVQQGEwJaQTElMCMGA1UEChMcVGhh d3RlIENvbnN1bHRpbmcgKFB0eSkgTHRkLjEsMCoGA1UEAxMjVGhhd3RlIFBlcnNvbmFsIEZyZWVt YWlsIElzc3VpbmcgQ0EwHhcNMDUwMTEwMDA0MTA5WhcNMDYwMTEwMDA0MTA5WjBHMR8wHQYDVQQD ExZUaGF3dGUgRnJlZW1haWwgTWVtYmVyMSQwIgYJKoZIhvcNAQkBFhVDcmFpZy5SdXNzZWxsQFN1 bi5DT00wggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQDti7ZE4rO6oXKbLM02AG9WY55t udmBVL53fb3V3X5S1kvcJOk1NEMIYT/T7Ww+/hE955zvHT29+mIoNe8AW/yj1WUH8uGG2HxhwCHI UQTHmN/ioVJgjwUaYbtNMKbL/NRpnL0QWewdMJS+6IFzFyX7ADFW5cJ+UWNLvNeWAQtN0mtLildn vdOgh50i8YPvACNkCHoomGjXx0azcXbe1X3c5AgRI6e2CZe5k2lRFQFUMqkjdoMtQPoNqJ1BxH9l i4cnabl8mcTwHHl44hrvb8ThqwRf2pfJh2vVuwmgK6z4IWjOk4RQM+0ODsRdq67mBdimJYmPMK1p RMBHzrUsfKxNAgMBAAGjMjAwMCAGA1UdEQQZMBeBFUNyYWlnLlJ1c3NlbGxAU3VuLkNPTTAMBgNV HRMBAf8EAjAAMA0GCSqGSIb3DQEBBAUAA4GBAIj86LzxCHedStDLMEeqHLy+UFG7zIRHfChSIV42 +MvXicydXEBh8v0Ry1V2d/lY4jS78G5yW5R9fKt1U5nlRBCOVzdhomvSolnNRIT71wPVVDrAIVlA YpXKxSmVBq7+4hV+3ZLHDeq3qZnNmiJR0sTEUD16xZX1RJs9dRYPCHoRMIIDPzCCAqigAwIBAgIB DTANBgkqhkiG9w0BAQUFADCB0TELMAkGA1UEBhMCWkExFTATBgNVBAgTDFdlc3Rlcm4gQ2FwZTES MBAGA1UEBxMJQ2FwZSBUb3duMRowGAYDVQQKExFUaGF3dGUgQ29uc3VsdGluZzEoMCYGA1UECxMf Q2VydGlmaWNhdGlvbiBTZXJ2aWNlcyBEaXZpc2lvbjEkMCIGA1UEAxMbVGhhd3RlIFBlcnNvbmFs IEZyZWVtYWlsIENBMSswKQYJKoZIhvcNAQkBFhxwZXJzb25hbC1mcmVlbWFpbEB0aGF3dGUuY29t MB4XDTAzMDcxNzAwMDAwMFoXDTEzMDcxNjIzNTk1OVowYjELMAkGA1UEBhMCWkExJTAjBgNVBAoT HFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBG cmVlbWFpbCBJc3N1aW5nIENBMIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDEpjxVc1X7TrnK mVoeaMB1BHCd3+n/ox7svc31W/Iadr1/DDph8r9RzgHU5VAKMNcCY1osiRVwjt3J8CuFWqo/cVbL rzwLB+fxH5E2JCoTzyvV84J3PQO+K/67GD4Hv0CAAmTXp6a7n2XRxSpUhQ9IBH+nttE8YQRAHmQZ cmC3+wIDAQABo4GUMIGRMBIGA1UdEwEB/wQIMAYBAf8CAQAwQwYDVR0fBDwwOjA4oDagNIYyaHR0 cDovL2NybC50aGF3dGUuY29tL1RoYXd0ZVBlcnNvbmFsRnJlZW1haWxDQS5jcmwwCwYDVR0PBAQD AgEGMCkGA1UdEQQiMCCkHjAcMRowGAYDVQQDExFQcml2YXRlTGFiZWwyLTEzODANBgkqhkiG9w0B AQUFAAOBgQBIjNFQg+oLLswNo2asZw9/r6y+whehQ5aUnX9MIbj4Nh+qLZ82L8D0HFAgk3A8/a3h YWLD2ToZfoSxmRsAxRoLgnSeJVCUYsfbJ3FXJY3dqZw5jowgT2Vfldr394fWxghOrvbqNOUQGls1 TXfjViF4gtwhGTXeJLHTHUb/XV9lTzGCAucwggLjAgEBMGkwYjELMAkGA1UEBhMCWkExJTAjBgNV BAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25h bCBGcmVlbWFpbCBJc3N1aW5nIENBAgMNxVkwCQYFKw4DAhoFAKCCAVMwGAYJKoZIhvcNAQkDMQsG CSqGSIb3DQEHATAcBgkqhkiG9w0BCQUxDxcNMDUwNzI1MTYwNTU3WjAjBgkqhkiG9w0BCQQxFgQU A05bqmN5uINYTxcwFOqAEvWy780weAYJKwYBBAGCNxAEMWswaTBiMQswCQYDVQQGEwJaQTElMCMG A1UEChMcVGhhd3RlIENvbnN1bHRpbmcgKFB0eSkgTHRkLjEsMCoGA1UEAxMjVGhhd3RlIFBlcnNv bmFsIEZyZWVtYWlsIElzc3VpbmcgQ0ECAw3FWTB6BgsqhkiG9w0BCRACCzFroGkwYjELMAkGA1UE BhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1Ro YXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBAgMNxVkwDQYJKoZIhvcNAQEBBQAEggEA CV8LsYlIJBR7DTaCJEeELE0mpI+w1+fKtShDcF8fYsgqXFzf4cnAxtNMNxdDr7is7/V6ALgzlRPH cKLfqklIiY1Tnzu/qaJ//fpZFJiX73EC2L8vgJFcIPFiyoNZeuBs840eLpNpuljj4T9AKFg0QQXf WXB8Y7XC/+Meycn6lA5rAq77Dk6/Js4jqSFDlbsedYj4UOzgonYZXK8BveyaDOgXxDs8/o+8w9rD Q1QnAUxOz/TRcDvH2cL4WeCKIL17XzfUQfM7YrPUY2ujrD2j679t0LkJ33gTJfoPpyIXv7btyCph Q0ssy2tEh9BjlyOh8ft17Jr9iSKwzUCYzdRUtAAAAAAAAA== --Apple-Mail-23-118953512--