db-jdo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Craig Russell <Craig.Russ...@Sun.COM>
Subject Re: Changes for review
Date Tue, 05 Jul 2005 21:11:05 GMT
Hi Michael,

On Jul 4, 2005, at 9:53 AM, Michael Bouschen wrote:

> Hi Craig,
>
> the changes look good! Two remarks:
> - I noticed you kept the JDO1 version of method newObjectIdInstance  
> taking a String. This is to support backward compatibility with  
> JDO1, correct? If yes, I propose to add a note to the javadoc  
> saying that this method is sort of deprecated. The String method  
> could delegate to the Object method.

I've deprecated the String method and added a note to the effect: see  
other method.

> - Typo: the param javadoc on line 187 uses 'str' instead of 'obj'  
> as the parameter name of the parameter.

One of two bad javadocs, both fixed.

Thanks,

Craig

>
> Regards Michael
>
>

Craig Russell
Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
408 276-5638 mailto:Craig.Russell@sun.com
P.S. A good JDO? O, Gasp!


Mime
View raw message