db-jdo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Craig Russell <Craig.Russ...@Sun.COM>
Subject Re: API20 changes
Date Thu, 07 Jul 2005 22:08:30 GMT
Hi Michael,

Thanks for the review.

On Jul 7, 2005, at 11:57 AM, Michael Bouschen wrote:

> Hi Craig,
>
> looks good!
>
> Some comments:
> - ObjectIdentity:
> The class calls JDOImplHelper.getInstance() and stores the result  
> in an instance variable. I propose to make the instance variable be  
> static. Furthermore, do we need a doPrivileged around the call  
> JDOImplHelper.getInstance, since it requires JDOPermission 
> ("getMetadata")?

Yes, and yes. I haven't run the tests with a security manager, but it  
will be needed then.

> - Bundle.properties
> Please add a newline at the end of the file.

Done.

Thanks,

Craig
>
> Regards Michael
>
>
>> Hi,
>>
>> This is still a work in progress, pending inclusion of the  
>> JDONullIdentityFIeldException. But the ObjectIdentity class is  
>> mostly done.
>>
>> Craig
>>
>
>
> -- 
> Michael Bouschen        Tech@Spree Engineering GmbH
> mailto:mbo.tech@spree.de    http://www.tech.spree.de/
> Tel.:++49/30/235 520-33        Buelowstr. 66
> Fax.:++49/30/2175 2012        D-10783 Berlin
>
>

Craig Russell
Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
408 276-5638 mailto:Craig.Russell@sun.com
P.S. A good JDO? O, Gasp!


Mime
View raw message