db-jdo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Watzek <mwa.t...@spree.de>
Subject Re: svn commit: r224397 - in /incubator/jdo/trunk/tck20/test/sql/derby: applicationidentity/schema.sql datastoreidentity/schema.sql
Date Mon, 25 Jul 2005 10:20:04 GMT
Hi Craig,

I noticed that you changed the type of column ALLTYPES.CHARACTERVAL from
CHAR(1) to INTEGER. Did you check in this change accidently or
intentionally? In the latter case, I propose to change the type of other 
CHAR(1) columns also (except for those which are mapped by boolean fields):

- PrimitiveTypes.charNotNull
- PrimitiveTypes.charNull

Note, that the type of these columns is CHAR which defaults to CHAR(1).

Regards,
Michael

clr@apache.org wrote:
> Author: clr
> Date: Fri Jul 22 13:57:22 2005
> New Revision: 224397
> 
> URL: http://svn.apache.org/viewcvs?rev=224397&view=rev
> Log:
> change type of char column to INTEGER to accommodate 65535
> 
> Modified:
>     incubator/jdo/trunk/tck20/test/sql/derby/applicationidentity/schema.sql
>     incubator/jdo/trunk/tck20/test/sql/derby/datastoreidentity/schema.sql
> 
> Modified: incubator/jdo/trunk/tck20/test/sql/derby/applicationidentity/schema.sql
> URL: http://svn.apache.org/viewcvs/incubator/jdo/trunk/tck20/test/sql/derby/applicationidentity/schema.sql?rev=224397&r1=224396&r2=224397&view=diff
> ==============================================================================
> --- incubator/jdo/trunk/tck20/test/sql/derby/applicationidentity/schema.sql (original)
> +++ incubator/jdo/trunk/tck20/test/sql/derby/applicationidentity/schema.sql Fri Jul 22
13:57:22 2005
> @@ -868,7 +868,7 @@
>      PRIMITIVESHORT SMALLINT,
>      BOOLEANVAL CHAR(1) CHECK (BOOLEANVAL IN ('Y','N')),
>      BYTEVAL SMALLINT,
> -    CHARACTERVAL CHAR(1),
> +    CHARACTERVAL INTEGER,
>      DOUBLEVAL DOUBLE,
>      FLOATVAL FLOAT,
>      INTEGERVAL INTEGER,
> 
> Modified: incubator/jdo/trunk/tck20/test/sql/derby/datastoreidentity/schema.sql
> URL: http://svn.apache.org/viewcvs/incubator/jdo/trunk/tck20/test/sql/derby/datastoreidentity/schema.sql?rev=224397&r1=224396&r2=224397&view=diff
> ==============================================================================
> --- incubator/jdo/trunk/tck20/test/sql/derby/datastoreidentity/schema.sql (original)
> +++ incubator/jdo/trunk/tck20/test/sql/derby/datastoreidentity/schema.sql Fri Jul 22
13:57:22 2005
> @@ -817,7 +817,7 @@
>      PRIMITIVESHORT SMALLINT,
>      BOOLEANVAL CHAR(1)CHECK (BOOLEANVAL IN ('Y','N')),
>      BYTEVAL SMALLINT,
> -    CHARACTERVAL CHAR(1),
> +    CHARACTERVAL INTEGER,
>      DOUBLEVAL DOUBLE,
>      FLOATVAL FLOAT,
>      INTEGERVAL INTEGER,
> 


-- 
-------------------------------------------------------------------
Michael Watzek                  Tech@Spree Engineering GmbH
mailto:mwa.tech@spree.de        Buelowstr. 66
Tel.:  ++49/30/235 520 36       10783 Berlin - Germany
Fax.:  ++49/30/217 520 12       http://www.spree.de/
-------------------------------------------------------------------


Mime
View raw message