db-jdo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Bouschen <mbo.t...@spree.de>
Subject Re: API20 changes
Date Thu, 07 Jul 2005 18:57:46 GMT
Hi Craig,

looks good!

Some comments:
- ObjectIdentity:
The class calls JDOImplHelper.getInstance() and stores the result in an 
instance variable. I propose to make the instance variable be static. 
Furthermore, do we need a doPrivileged around the call 
JDOImplHelper.getInstance, since it requires JDOPermission("getMetadata")?
- Bundle.properties
Please add a newline at the end of the file.

Regards Michael

> Hi,
>
> This is still a work in progress, pending inclusion of the 
> JDONullIdentityFIeldException. But the ObjectIdentity class is mostly 
> done.
>
> Craig


-- 
Michael Bouschen		Tech@Spree Engineering GmbH
mailto:mbo.tech@spree.de	http://www.tech.spree.de/
Tel.:++49/30/235 520-33		Buelowstr. 66			
Fax.:++49/30/2175 2012		D-10783 Berlin			


Mime
View raw message