Return-Path: Delivered-To: apmail-db-jdo-dev-archive@www.apache.org Received: (qmail 88551 invoked from network); 23 Jun 2005 16:30:20 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 23 Jun 2005 16:30:20 -0000 Received: (qmail 13926 invoked by uid 500); 23 Jun 2005 16:30:19 -0000 Mailing-List: contact jdo-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jdo-dev@db.apache.org Delivered-To: mailing list jdo-dev@db.apache.org Received: (qmail 13913 invoked by uid 99); 23 Jun 2005 16:30:19 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Jun 2005 09:30:19 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=HTML_MESSAGE X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [192.18.98.34] (HELO brmea-mail-3.sun.com) (192.18.98.34) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Jun 2005 09:30:20 -0700 Received: from fe1.sun.com ([192.18.108.78]) by brmea-mail-3.sun.com (8.12.10/8.12.9) with ESMTP id j5NGUGw4029063 for ; Thu, 23 Jun 2005 10:30:16 -0600 (MDT) Received: from conversion-daemon.fe1.sun.com by fe1.sun.com (Sun Java System Messaging Server 6.1 HotFix 0.02 (built Aug 25 2004)) id <0IIJ00901O0H2O00@fe1.sun.com> (original mail from Craig.Russell@Sun.COM) for jdo-dev@db.apache.org; Thu, 23 Jun 2005 10:30:16 -0600 (MDT) Received: from [10.0.0.100] ([65.14.21.57]) by fe1.sun.com (Sun Java System Messaging Server 6.1 HotFix 0.02 (built Aug 25 2004)) with ESMTPSA id <0IIJ00CYQPUDEMG6@fe1.sun.com>; Thu, 23 Jun 2005 10:30:16 -0600 (MDT) Date: Thu, 23 Jun 2005 09:30:15 -0700 From: Craig Russell Subject: Re: TestRunner remarks In-reply-to: <42BAE4D7.9050806@spree.de> To: jdo-dev@db.apache.org Cc: Michelle Caisse , Michael Bouschen Message-id: MIME-version: 1.0 X-Mailer: Apple Mail (2.730) Content-type: multipart/signed; protocol="application/pkcs7-signature"; boundary=Apple-Mail-188--496903600; micalg=sha1 References: <42B73803.2030909@spree.de> <42B8E982.7040304@sun.com> <42B99C60.1070600@spree.de> <42B9A0FF.6010703@sun.com> <42BADB68.8050106@spree.de> <42BAE4D7.9050806@spree.de> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N --Apple-Mail-188--496903600 Content-Type: multipart/alternative; boundary=Apple-Mail-187--496904729 --Apple-Mail-187--496904729 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Hi, Ok, then maybe we can prefix the log file names with database-app/ dsid, e.g. derby-app-freeble-2005-06-17.log Naming conventions for "freeble" open for discussion... Craig On Jun 23, 2005, at 9:35 AM, Michael Watzek wrote: > Hi Craig, > > >> Hi, >> I hadn't thought of the multiple log file issue. For what it's >> worth, I'd prefer one log file for each configuration (app/ >> datastore id; database) and not one log file for completeness/all >> test cases. We have in mind that there would be many completeness/ >> all test cases configs, so it will be difficult to sort them all out. >> > A new log file is created for each TCK run. Each configuration > starts a new TCK run. Additionally, each identity type and each > database starts a new TCK run. So, if you run "runtck.jdori" > currently, then you get 4 log files: > > - Completeness test for application identity on derby > - Completeness test for datastore identity on derby > - All tests for application identity on derby > - All tests test for datastore identity on derby > > Regards, > Michael > >> Craig >> On Jun 23, 2005, at 8:55 AM, Michael Watzek wrote: >> >>> Hi Michelle, >>> >>> >>> >>>>> Afterwards I ran "maven runtck.jdori". This runs 2 >>>>> configurations - one for the completeness and one for all test >>>>> cases. As a result, 4 log files are written to target/logs - 2 >>>>> for application identity, 2 for datastore identity. The all >>>>> test TCK runs produced the expected amount of errors/failures - >>>>> though, they did not take as much time as expected. Both runs >>>>> perform about 7-8 times faster on my system - that's great :-)! >>>>> What have you changed? >>>>> >>>>> >>>> Wow, that IS great! It seemed a lot faster on my system too, >>>> but I wasn't paying much attention to performance. I have no >>>> idea what the difference is :-\ I will try to investigate >>>> before I check in. >>>> >>>> >>> I'm also curious about the performance boost, so I spent some >>> time in investigating - without success: >>> >>> I only get the performance boost with your patch. A clean >>> workspace without your patch performs 7-8 times slower. I applied >>> two changes of your patch to a clean workspace just to see if >>> this makes a difference: >>> >>> jdori.properties: >>> -org.jpox.validateTables=false # default = true >>> +org.jpox.validateTables=false >>> >>> logging.properties: >>> -log4j.category.JPOX.General=INFO, A1 >>> +log4j.category.JPOX.General=DEBUG, A1 >>> >>> Both changes do not give better performance. So, I ran out of >>> ideas. Hopefully, you have more luck in investigation. >>> >>> >>> >>>>> - Can we include the configuration name and the identity type >>>>> in the log file name? Currently, it's hard to find the right >>>>> file if you are interested in only one file. >>>>> >>>>> >>>> This is a good idea. I definitely would like to get more >>>> information into the log file or file name. Can you tell me >>>> where the log file name is created? >>>> >>>> >>> Class "BatchTestRunner" has a static inner class >>> "ConsoleFileOutput" defining a static String "fileNamePrefix": >>> >>> private static String fileNamePrefix = "TCKLog-"; >>> >>> I suggest to append the value of a system property which contains >>> the configuration name and the identity type. >>> >>> Regards, >>> Michael >>> -- >>> ------------------------------------------------------------------- >>> Michael Watzek Tech@Spree Engineering GmbH >>> mailto:mwa.tech@spree.de Buelowstr. 66 >>> Tel.: ++49/30/235 520 36 10783 Berlin - Germany >>> Fax.: ++49/30/217 520 12 http://www.spree.de/ >>> ------------------------------------------------------------------- >>> >>> >> Craig Russell >> Architect, Sun Java Enterprise System http://java.sun.com/products/ >> jdo >> 408 276-5638 mailto:Craig.Russell@sun.com >> P.S. A good JDO? O, Gasp! >> > > > -- > ------------------------------------------------------------------- > Michael Watzek Tech@Spree Engineering GmbH > mailto:mwa.tech@spree.de Buelowstr. 66 > Tel.: ++49/30/235 520 36 10783 Berlin - Germany > Fax.: ++49/30/217 520 12 http://www.spree.de/ > ------------------------------------------------------------------- > Craig Russell Architect, Sun Java Enterprise System http://java.sun.com/products/jdo 408 276-5638 mailto:Craig.Russell@sun.com P.S. A good JDO? O, Gasp! --Apple-Mail-187--496904729 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=ISO-8859-1 Hi,

Ok, then maybe we can = prefix the log file names with database-app/dsid, e.g.

derby-app-freeble-2005-06-17.= log

Naming = conventions for "freeble" open for discussion...

Craig

On Jun 23, 2005, at 9:35 AM, Michael Watzek wrote:

Hi Craig,


I hadn't thought of the multiple = log file issue. For what it's worth, I'd prefer one log file for each = configuration (app/datastore id; database) and not one log file for = completeness/all test cases. We have in mind that there would be many = completeness/all test cases configs, so it will be difficult to sort = them all out.

A new log = file is created for each TCK run. Each configuration starts a new TCK = run. Additionally, each identity type and each database starts a new TCK = run. So, if you run "runtck.jdori" currently, then you get 4 log = files:

- Completeness test for application identity on = derby
- Completeness test for = datastore identity on derby
- All tests = for application identity on derby
- All tests = test for datastore identity on derby

Regards,
Michael

Craig
On Jun 23, = 2005, at 8:55 AM, Michael Watzek wrote:

Hi Michelle,



Afterwards I ran "maven = runtck.jdori". This runs 2 configurations - one for the completeness and = one for all test cases. As a result, 4 log files are written to = target/logs - 2 for application identity, 2 for datastore identity. The = all test TCK runs produced the expected amount of errors/failures - = though, they did not take as much time as expected. Both runs perform = about 7-8 times faster on my system - that's great :-)! What have you = changed?

=
Wow, that IS great!=A0 It seemed a lot faster on my = system too, but I wasn't paying much attention to performance.=A0 I have no idea what the = difference is :-\=A0 I will = try to investigate before I check in.


I'm also = curious about the performance boost, so I spent some time in = investigating - without success:

I only get the performance boost = with your patch. A clean workspace without your patch performs 7-8 times = slower. I applied two changes of your patch to a clean workspace just to = see if this makes a difference:

jdori.properties:
-org.jpox.validateTables=3Dfalse=A0 # default =3D true
+org.jpox.validateTables=3Dfalse


Both changes = do not give better performance. So, I ran out of ideas. Hopefully, you = have more luck in investigation.


=
- Can we include the configuration name and the = identity type in the log file name? Currently, it's hard to find the = right file if you are interested in only one file.


This is a good idea.=A0 I definitely would like to = get more information into the log file or file name.=A0 Can you tell me where the log = file name is created?
Class = "BatchTestRunner" has a static inner class "ConsoleFileOutput" defining = a static String "fileNamePrefix":

private static String = fileNamePrefix =3D "TCKLog-";

I suggest to append the value of = a system property which contains the configuration name and the identity = type.

Regards,
--=A0
Michael Watzek=A0= =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 Tech@Spree Engineering = GmbH
mailto:mwa.tech@spree.de=A0 =A0 =A0 =A0 Buelowstr. = 66
Tel.:=A0 = ++49/30/235 520 36 =A0 =A0 = =A0 10783 Berlin - Germany
Fax.:=A0 ++49/30/217 520 12 =A0 =A0 =A0 http://www.spree.de/


Craig Russell
Architect, = Sun Java Enterprise System http://java.sun.com/products/jdo=
408 276-5638 mailto:Craig.Russell@sun.com
P.S. A good JDO? O, Gasp!
=


--=A0
Michael Watzek=A0= =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 Tech@Spree Engineering = GmbH
mailto:mwa.tech@spree.de=A0 =A0 =A0 =A0 Buelowstr. = 66
Tel.:=A0 = ++49/30/235 520 36 =A0 =A0 = =A0 10783 Berlin - Germany
Fax.:=A0 ++49/30/217 520 12 =A0 =A0 =A0 http://www.spree.de/

=

Craig Russell

Architect, Sun Java = Enterprise System http://java.sun.com/products/jdo=

408 = 276-5638 mailto:Craig.Russell@sun.com

P.S. A = good JDO? O, Gasp!


= --Apple-Mail-187--496904729-- --Apple-Mail-188--496903600 Content-Transfer-Encoding: base64 Content-Type: application/pkcs7-signature; name=smime.p7s Content-Disposition: attachment; filename=smime.p7s MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIGHjCCAtcw ggJAoAMCAQICAw3FWTANBgkqhkiG9w0BAQQFADBiMQswCQYDVQQGEwJaQTElMCMGA1UEChMcVGhh d3RlIENvbnN1bHRpbmcgKFB0eSkgTHRkLjEsMCoGA1UEAxMjVGhhd3RlIFBlcnNvbmFsIEZyZWVt YWlsIElzc3VpbmcgQ0EwHhcNMDUwMTEwMDA0MTA5WhcNMDYwMTEwMDA0MTA5WjBHMR8wHQYDVQQD ExZUaGF3dGUgRnJlZW1haWwgTWVtYmVyMSQwIgYJKoZIhvcNAQkBFhVDcmFpZy5SdXNzZWxsQFN1 bi5DT00wggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQDti7ZE4rO6oXKbLM02AG9WY55t udmBVL53fb3V3X5S1kvcJOk1NEMIYT/T7Ww+/hE955zvHT29+mIoNe8AW/yj1WUH8uGG2HxhwCHI UQTHmN/ioVJgjwUaYbtNMKbL/NRpnL0QWewdMJS+6IFzFyX7ADFW5cJ+UWNLvNeWAQtN0mtLildn vdOgh50i8YPvACNkCHoomGjXx0azcXbe1X3c5AgRI6e2CZe5k2lRFQFUMqkjdoMtQPoNqJ1BxH9l i4cnabl8mcTwHHl44hrvb8ThqwRf2pfJh2vVuwmgK6z4IWjOk4RQM+0ODsRdq67mBdimJYmPMK1p RMBHzrUsfKxNAgMBAAGjMjAwMCAGA1UdEQQZMBeBFUNyYWlnLlJ1c3NlbGxAU3VuLkNPTTAMBgNV HRMBAf8EAjAAMA0GCSqGSIb3DQEBBAUAA4GBAIj86LzxCHedStDLMEeqHLy+UFG7zIRHfChSIV42 +MvXicydXEBh8v0Ry1V2d/lY4jS78G5yW5R9fKt1U5nlRBCOVzdhomvSolnNRIT71wPVVDrAIVlA YpXKxSmVBq7+4hV+3ZLHDeq3qZnNmiJR0sTEUD16xZX1RJs9dRYPCHoRMIIDPzCCAqigAwIBAgIB DTANBgkqhkiG9w0BAQUFADCB0TELMAkGA1UEBhMCWkExFTATBgNVBAgTDFdlc3Rlcm4gQ2FwZTES MBAGA1UEBxMJQ2FwZSBUb3duMRowGAYDVQQKExFUaGF3dGUgQ29uc3VsdGluZzEoMCYGA1UECxMf Q2VydGlmaWNhdGlvbiBTZXJ2aWNlcyBEaXZpc2lvbjEkMCIGA1UEAxMbVGhhd3RlIFBlcnNvbmFs IEZyZWVtYWlsIENBMSswKQYJKoZIhvcNAQkBFhxwZXJzb25hbC1mcmVlbWFpbEB0aGF3dGUuY29t MB4XDTAzMDcxNzAwMDAwMFoXDTEzMDcxNjIzNTk1OVowYjELMAkGA1UEBhMCWkExJTAjBgNVBAoT HFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBG cmVlbWFpbCBJc3N1aW5nIENBMIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDEpjxVc1X7TrnK mVoeaMB1BHCd3+n/ox7svc31W/Iadr1/DDph8r9RzgHU5VAKMNcCY1osiRVwjt3J8CuFWqo/cVbL rzwLB+fxH5E2JCoTzyvV84J3PQO+K/67GD4Hv0CAAmTXp6a7n2XRxSpUhQ9IBH+nttE8YQRAHmQZ cmC3+wIDAQABo4GUMIGRMBIGA1UdEwEB/wQIMAYBAf8CAQAwQwYDVR0fBDwwOjA4oDagNIYyaHR0 cDovL2NybC50aGF3dGUuY29tL1RoYXd0ZVBlcnNvbmFsRnJlZW1haWxDQS5jcmwwCwYDVR0PBAQD AgEGMCkGA1UdEQQiMCCkHjAcMRowGAYDVQQDExFQcml2YXRlTGFiZWwyLTEzODANBgkqhkiG9w0B AQUFAAOBgQBIjNFQg+oLLswNo2asZw9/r6y+whehQ5aUnX9MIbj4Nh+qLZ82L8D0HFAgk3A8/a3h YWLD2ToZfoSxmRsAxRoLgnSeJVCUYsfbJ3FXJY3dqZw5jowgT2Vfldr394fWxghOrvbqNOUQGls1 TXfjViF4gtwhGTXeJLHTHUb/XV9lTzGCAucwggLjAgEBMGkwYjELMAkGA1UEBhMCWkExJTAjBgNV BAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25h bCBGcmVlbWFpbCBJc3N1aW5nIENBAgMNxVkwCQYFKw4DAhoFAKCCAVMwGAYJKoZIhvcNAQkDMQsG CSqGSIb3DQEHATAcBgkqhkiG9w0BCQUxDxcNMDUwNjIzMTYzMDE3WjAjBgkqhkiG9w0BCQQxFgQU DKzH+VHOUQi4LpOKwO0mdCww7HUweAYJKwYBBAGCNxAEMWswaTBiMQswCQYDVQQGEwJaQTElMCMG A1UEChMcVGhhd3RlIENvbnN1bHRpbmcgKFB0eSkgTHRkLjEsMCoGA1UEAxMjVGhhd3RlIFBlcnNv bmFsIEZyZWVtYWlsIElzc3VpbmcgQ0ECAw3FWTB6BgsqhkiG9w0BCRACCzFroGkwYjELMAkGA1UE BhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1Ro YXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBAgMNxVkwDQYJKoZIhvcNAQEBBQAEggEA uYWsj6kghxpDSqoaw1X28B+QkHebxyP735n07I1ee4Q0obx1VN9DfS2G6XWrQBTuDD6SxlEAEUva 4rz55oyJt6YJ+rGZODFWxiYWnJk/DqJLS4PNsGZPR71pE0ElCSjbdo/52LooeQgpdkIm9RAq8n3K Oyl0723scR/ArIZ+596ZZcLpnwTdv5UdhkBFgVR0n1H/8Q2MwNEk3FfxAY7GijgVNunQEiIhXvWf svFq5WhJt9V2QCKupqmueuNH9/UKGNNNgdBRQDFoo5m8H/rlPdBnP31p+ltErcYdo9WM1abf4Hyc NCNXBj+04doXEMGWVsNUUV+bl4ZcYm76eqK9XgAAAAAAAA== --Apple-Mail-188--496903600--