db-jdo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Craig Russell <Craig.Russ...@Sun.COM>
Subject Re: TestRunner remarks
Date Sat, 25 Jun 2005 16:29:16 GMT
On second thought, it's probably better to put the timestamp first,  
so a sorted directory will have the latest results close together.

Craig

On Jun 23, 2005, at 9:30 AM, Craig Russell wrote:

> Hi,
>
> Ok, then maybe we can prefix the log file names with database-app/ 
> dsid, e.g.
>
> derby-app-freeble-2005-06-17.log
>
> Naming conventions for "freeble" open for discussion...
>
> Craig
>
> On Jun 23, 2005, at 9:35 AM, Michael Watzek wrote:
>
>> Hi Craig,
>>
>>
>>> Hi,
>>> I hadn't thought of the multiple log file issue. For what it's  
>>> worth, I'd prefer one log file for each configuration (app/ 
>>> datastore id; database) and not one log file for completeness/all  
>>> test cases. We have in mind that there would be many completeness/ 
>>> all test cases configs, so it will be difficult to sort them all  
>>> out.
>>>
>> A new log file is created for each TCK run. Each configuration  
>> starts a new TCK run. Additionally, each identity type and each  
>> database starts a new TCK run. So, if you run "runtck.jdori"  
>> currently, then you get 4 log files:
>>
>> - Completeness test for application identity on derby
>> - Completeness test for datastore identity on derby
>> - All tests for application identity on derby
>> - All tests test for datastore identity on derby
>>
>> Regards,
>> Michael
>>
>>> Craig
>>> On Jun 23, 2005, at 8:55 AM, Michael Watzek wrote:
>>>
>>>> Hi Michelle,
>>>>
>>>>
>>>>
>>>>>> Afterwards I ran "maven runtck.jdori". This runs 2  
>>>>>> configurations - one for the completeness and one for all test  
>>>>>> cases. As a result, 4 log files are written to target/logs - 2  
>>>>>> for application identity, 2 for datastore identity. The all  
>>>>>> test TCK runs produced the expected amount of errors/failures  
>>>>>> - though, they did not take as much time as expected. Both  
>>>>>> runs perform about 7-8 times faster on my system - that's  
>>>>>> great :-)! What have you changed?
>>>>>>
>>>>>>
>>>>> Wow, that IS great!  It seemed a lot faster on my system too,  
>>>>> but I wasn't paying much attention to performance.  I have no  
>>>>> idea what the difference is :-\  I will try to investigate  
>>>>> before I check in.
>>>>>
>>>>>
>>>> I'm also curious about the performance boost, so I spent some  
>>>> time in investigating - without success:
>>>>
>>>> I only get the performance boost with your patch. A clean  
>>>> workspace without your patch performs 7-8 times slower. I  
>>>> applied two changes of your patch to a clean workspace just to  
>>>> see if this makes a difference:
>>>>
>>>> jdori.properties:
>>>> -org.jpox.validateTables=false  # default = true
>>>> +org.jpox.validateTables=false
>>>>
>>>> logging.properties:
>>>> -log4j.category.JPOX.General=INFO, A1
>>>> +log4j.category.JPOX.General=DEBUG, A1
>>>>
>>>> Both changes do not give better performance. So, I ran out of  
>>>> ideas. Hopefully, you have more luck in investigation.
>>>>
>>>>
>>>>
>>>>>> - Can we include the configuration name and the identity type  
>>>>>> in the log file name? Currently, it's hard to find the right  
>>>>>> file if you are interested in only one file.
>>>>>>
>>>>>>
>>>>> This is a good idea.  I definitely would like to get more  
>>>>> information into the log file or file name.  Can you tell me  
>>>>> where the log file name is created?
>>>>>
>>>>>
>>>> Class "BatchTestRunner" has a static inner class  
>>>> "ConsoleFileOutput" defining a static String "fileNamePrefix":
>>>>
>>>> private static String fileNamePrefix = "TCKLog-";
>>>>
>>>> I suggest to append the value of a system property which  
>>>> contains the configuration name and the identity type.
>>>>
>>>> Regards,
>>>> Michael
>>>> -- 
>>>> -------------------------------------------------------------------
>>>> Michael Watzek                  Tech@Spree Engineering GmbH
>>>> mailto:mwa.tech@spree.de        Buelowstr. 66
>>>> Tel.:  ++49/30/235 520 36       10783 Berlin - Germany
>>>> Fax.:  ++49/30/217 520 12       http://www.spree.de/
>>>> -------------------------------------------------------------------
>>>>
>>>>
>>> Craig Russell
>>> Architect, Sun Java Enterprise System http://java.sun.com/ 
>>> products/jdo
>>> 408 276-5638 mailto:Craig.Russell@sun.com
>>> P.S. A good JDO? O, Gasp!
>>>
>>
>>
>> -- 
>> -------------------------------------------------------------------
>> Michael Watzek                  Tech@Spree Engineering GmbH
>> mailto:mwa.tech@spree.de        Buelowstr. 66
>> Tel.:  ++49/30/235 520 36       10783 Berlin - Germany
>> Fax.:  ++49/30/217 520 12       http://www.spree.de/
>> -------------------------------------------------------------------
>>
>
> Craig Russell
> Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
> 408 276-5638 mailto:Craig.Russell@sun.com
> P.S. A good JDO? O, Gasp!
>

Craig Russell
Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
408 276-5638 mailto:Craig.Russell@sun.com
P.S. A good JDO? O, Gasp!


Mime
View raw message