db-jdo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Craig Russell <Craig.Russ...@Sun.COM>
Subject Re: JDO-58
Date Tue, 31 May 2005 18:00:24 GMT
Hi Michael,

Sounds good.

Craig

On May 31, 2005, at 10:37 AM, Michael Watzek wrote:

> Hi,
>
> there are 5 tests (AfterCloseGetPMThrowsException, 
> AfterCloseSetMethodsThrowException, Close, 
> CloseFailsIfTransactionActive, 
> CloseWithoutPermissionThrowsSecurityException) that call "getPMF()" 
> and "pmf.close()" in their "testXXX" methods , but they do not nullify 
> field "pmf". All of those tests fail in "localTearDown": 
> "localTearDown" calls "getPMF()" which returns field "pmf" if it is 
> not null. For this reason, "getPMF()" returnes a closed PMF in those 
> tests.
>
> The proposal for a fix is to add a check before "localTearDown" is 
> called:
>
> if (pmf!=null && pmf.isClosed())
>     pmf = null;
>
> Regards,
> Michael
> -- 
> -------------------------------------------------------------------
> Michael Watzek                  Tech@Spree Engineering GmbH
> mailto:mwa.tech@spree.de        Buelowstr. 66
> Tel.:  ++49/30/235 520 36       10783 Berlin - Germany
> Fax.:  ++49/30/217 520 12       http://www.spree.de/
> -------------------------------------------------------------------
>
Craig Russell
Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
408 276-5638 mailto:Craig.Russell@sun.com
P.S. A good JDO? O, Gasp!

Mime
View raw message