db-jdo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Watzek <mwa.t...@spree.de>
Subject JDO-58
Date Tue, 31 May 2005 17:37:09 GMT
Hi,

there are 5 tests (AfterCloseGetPMThrowsException, 
AfterCloseSetMethodsThrowException, Close, 
CloseFailsIfTransactionActive, 
CloseWithoutPermissionThrowsSecurityException) that call "getPMF()" and 
"pmf.close()" in their "testXXX" methods , but they do not nullify field 
"pmf". All of those tests fail in "localTearDown": "localTearDown" calls 
"getPMF()" which returns field "pmf" if it is not null. For this reason, 
"getPMF()" returnes a closed PMF in those tests.

The proposal for a fix is to add a check before "localTearDown" is called:

if (pmf!=null && pmf.isClosed())
     pmf = null;

Regards,
Michael
-- 
-------------------------------------------------------------------
Michael Watzek                  Tech@Spree Engineering GmbH
mailto:mwa.tech@spree.de        Buelowstr. 66
Tel.:  ++49/30/235 520 36       10783 Berlin - Germany
Fax.:  ++49/30/217 520 12       http://www.spree.de/
-------------------------------------------------------------------

Mime
View raw message