Return-Path: 
 <jdo-commits-return-2287-apmail-db-jdo-commits-archive=www.apache.org@db.apache.org>
Delivered-To: apmail-db-jdo-commits-archive@www.apache.org
Received: (qmail 38294 invoked from network); 16 Feb 2008 00:29:33 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 16 Feb 2008 00:29:33 -0000
Received: (qmail 83724 invoked by uid 500); 16 Feb 2008 00:29:27 -0000
Mailing-List: contact jdo-commits-help@db.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:jdo-commits-help@db.apache.org>
List-Unsubscribe: <mailto:jdo-commits-unsubscribe@db.apache.org>
List-Post: <mailto:jdo-commits@db.apache.org>
List-Id: <jdo-commits.db.apache.org>
Reply-To: jdo-dev@db.apache.org
Delivered-To: mailing list jdo-commits@db.apache.org
Received: (qmail 83713 invoked by uid 99); 16 Feb 2008 00:29:27 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Feb 2008 16:29:27 -0800
X-ASF-Spam-Status: No, hits=-2000.0 required=10.0
	tests=ALL_TRUSTED
X-Spam-Check-By: apache.org
Received: from [140.211.11.3] (HELO eris.apache.org) (140.211.11.3)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 16 Feb 2008 00:29:03 +0000
Received: by eris.apache.org (Postfix, from userid 65534)
	id 5A03B1A9832; Fri, 15 Feb 2008 16:29:12 -0800 (PST)
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: svn commit: r628214 - in /db/jdo/trunk/tck2: maven.xml
 src/java/org/apache/jdo/tck/api/persistencemanagerfactory/config/Jdoconfig.java
Date: Sat, 16 Feb 2008 00:29:12 -0000
To: jdo-commits@db.apache.org
From: mcaisse@apache.org
X-Mailer: svnmailer-1.0.8
Message-Id: <20080216002912.5A03B1A9832@eris.apache.org>
X-Virus-Checked: Checked by ClamAV on apache.org

Author: mcaisse
Date: Fri Feb 15 16:29:11 2008
New Revision: 628214

URL: http://svn.apache.org/viewvc?rev=628214&view=rev
Log:
JDO-576 Added comments to test, check-in maven.xml, missing from previous check-in

Modified:
    db/jdo/trunk/tck2/maven.xml
    db/jdo/trunk/tck2/src/java/org/apache/jdo/tck/api/persistencemanagerfactory/config/Jdoconfig.java

Modified: db/jdo/trunk/tck2/maven.xml
URL: http://svn.apache.org/viewvc/db/jdo/trunk/tck2/maven.xml?rev=628214&r1=628213&r2=628214&view=diff
==============================================================================
--- db/jdo/trunk/tck2/maven.xml (original)
+++ db/jdo/trunk/tck2/maven.xml Fri Feb 15 16:29:11 2008
@@ -475,6 +475,8 @@
                          value="${jdo.tck.cleanupaftertest}"/>
             <sysproperty key="jdo.tck.requiredOptions"
                          value="${jdo.tck.requiredOptions}"/>
+            <sysproperty key="jdo.tck.schemaname"
+                         value="${schemaname}"/>
             <sysproperty key="jdo.tck.mapping.companyfactory"
                          value="${jdo.tck.mapping.companyfactory}"/>
             <sysproperty key="jdo.tck.closePMFAfterEachTest"

Modified: db/jdo/trunk/tck2/src/java/org/apache/jdo/tck/api/persistencemanagerfactory/config/Jdoconfig.java
URL: http://svn.apache.org/viewvc/db/jdo/trunk/tck2/src/java/org/apache/jdo/tck/api/persistencemanagerfactory/config/Jdoconfig.java?rev=628214&r1=628213&r2=628214&view=diff
==============================================================================
--- db/jdo/trunk/tck2/src/java/org/apache/jdo/tck/api/persistencemanagerfactory/config/Jdoconfig.java (original)
+++ db/jdo/trunk/tck2/src/java/org/apache/jdo/tck/api/persistencemanagerfactory/config/Jdoconfig.java Fri Feb 15 16:29:11 2008
@@ -27,11 +27,11 @@
 
 /**
  *<B>Title:</B>Close of PersistenceManagerFactory  
- *<BR>
+ *<BR/>
  *<B>Keywords:</B> persistencemanagerfactory, jdoconfig.xml
- *<BR>
+ *<BR/>
  *<B>Assertion IDs:</B> A11.1.2-1
- *<BR>
+ *<BR/>
  *<B>Assertion Description: </B>
  * Users can access a PersistenceManagerFactory by creating a jdoconfig.xml file
  * and making it available on the class path as META-INF/jdoconfig.xml.
@@ -63,12 +63,17 @@
      * @see JDO_Test#localSetUp()
      */
     protected void localSetUp() {
+        /* Instance can be persisted ONLY if javax.jdo.mapping.Schema
+         *   is overriden with 
+         *   JDOHelper.getPersistenceManagerFactory(Map overrides, ...).
+         *   The value depends on identity type so can only be known at runtime.
+         */
         if (isTestToBePerformed()) {
             overrides.put("javax.jdo.mapping.Schema", schemaname);
         }
     }
 
-    /** */
+    /** */ 
     public void testGetPMFNoArgs() {
         pmf = JDOHelper.getPersistenceManagerFactory();
         checkIsOpen(ANONYMOUS_PMF_NAME);
@@ -156,7 +161,11 @@
         pmf = null;
     }
 
-    /** */
+    /** 
+     * Checks if instance can be persisted. Can be used if
+     *    javax.jdo.mapping.Schema is overriden with the correct value
+     *    with JDOHelper.getPersistenceManagerFactory(Map overrides, ...).
+     */
     public void checkPersistent(String name) {
         assertEquals("Incorrect PMF name", pmf.getName(), name);