Return-Path: Delivered-To: apmail-db-jdo-commits-archive@www.apache.org Received: (qmail 48192 invoked from network); 27 Mar 2006 22:17:05 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 27 Mar 2006 22:17:05 -0000 Received: (qmail 90814 invoked by uid 500); 27 Mar 2006 22:17:04 -0000 Mailing-List: contact jdo-commits-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jdo-dev@db.apache.org Delivered-To: mailing list jdo-commits@db.apache.org Received: (qmail 90802 invoked by uid 99); 27 Mar 2006 22:17:04 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Mar 2006 14:17:04 -0800 X-ASF-Spam-Status: No, hits=-9.4 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [209.237.227.194] (HELO minotaur.apache.org) (209.237.227.194) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 27 Mar 2006 14:17:03 -0800 Received: (qmail 48116 invoked by uid 65534); 27 Mar 2006 22:16:43 -0000 Message-ID: <20060327221643.48115.qmail@minotaur.apache.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r389307 - /db/jdo/trunk/tck20/src/java/org/apache/jdo/tck/api/persistencemanagerfactory/Close.java Date: Mon, 27 Mar 2006 22:16:43 -0000 To: jdo-commits@db.apache.org From: mzaun@apache.org X-Mailer: svnmailer-1.0.7 X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Author: mzaun Date: Mon Mar 27 14:16:41 2006 New Revision: 389307 URL: http://svn.apache.org/viewcvs?rev=389307&view=rev Log: JDO-189 - Extended test for PMF.isClosed() Modified: db/jdo/trunk/tck20/src/java/org/apache/jdo/tck/api/persistencemanagerfactory/Close.java Modified: db/jdo/trunk/tck20/src/java/org/apache/jdo/tck/api/persistencemanagerfactory/Close.java URL: http://svn.apache.org/viewcvs/db/jdo/trunk/tck20/src/java/org/apache/jdo/tck/api/persistencemanagerfactory/Close.java?rev=389307&r1=389306&r2=389307&view=diff ============================================================================== --- db/jdo/trunk/tck20/src/java/org/apache/jdo/tck/api/persistencemanagerfactory/Close.java (original) +++ db/jdo/trunk/tck20/src/java/org/apache/jdo/tck/api/persistencemanagerfactory/Close.java Mon Mar 27 14:16:41 2006 @@ -27,10 +27,12 @@ *
*Keywords: persistencemanagerfactory *
- *Assertion IDs: A11.4-2 + *Assertion IDs: A11.4-2, A11.4-10 *
*Assertion Description: * PersistenceManagerFactory.close() closes this PersistenceManagerFactory. + *Assertion Description: + * PersistenceManagerFactory.isClosed(); Return true if this PersistenceManagerFactory is closed; and false otherwise. */ @@ -38,8 +40,8 @@ /** */ private static final String ASSERTION_FAILED = - "Assertions A11.4-2 (Close) failed: "; - + "Assertions A11.4-2 (Close), A11.4-10 (isClosed) failed: "; + /** * The main is called when the class * is directly executed from the command line. @@ -52,8 +54,31 @@ /** */ public void test() { pmf = getPMF(); - pmf.close(); - //check that pmf is really closed by trying to get a getPersistenceManager + + // check pmf.isClosed() before and after pmf.close() + try { + if (pmf.isClosed()) { + fail(ASSERTION_FAILED, + "PMF.isClosed() returned true on an open pmf"); + } + + pmf.close(); + + if (!pmf.isClosed()) { + fail(ASSERTION_FAILED, + "PMF.isClosed() returned false on a closed pmf"); + } + } catch (JDOUserException ex) { + // unexpected exception + fail(ASSERTION_FAILED, + "Unexpected exception at pmf.close()/isClosed(): " + ex); + } catch (JDOFatalUserException ex) { + // unexpected exception + fail(ASSERTION_FAILED, + "Unexpected exception at pmf.close()/isClosed(): " + ex); + } + + // trying to get a getPersistenceManager should result in a exception try { pm = pmf.getPersistenceManager(); fail(ASSERTION_FAILED, @@ -69,5 +94,8 @@ "Wrong exception thrown from getPersistenceManager after close.\n" + "Expected JDOUserException, got JDOFatalUserException."); } + + // have next invocation of getPMF() get a new pmf + pmf = null; } }