Return-Path: Delivered-To: apmail-db-jdo-commits-archive@www.apache.org Received: (qmail 52977 invoked from network); 15 Jul 2005 19:32:52 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 15 Jul 2005 19:32:52 -0000 Received: (qmail 31295 invoked by uid 500); 15 Jul 2005 19:32:52 -0000 Mailing-List: contact jdo-commits-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jdo-dev@db.apache.org Delivered-To: mailing list jdo-commits@db.apache.org Received: (qmail 31281 invoked by uid 99); 15 Jul 2005 19:32:52 -0000 X-ASF-Spam-Status: No, hits=-9.8 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [209.237.227.194] (HELO minotaur.apache.org) (209.237.227.194) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 15 Jul 2005 12:32:40 -0700 Received: (qmail 52806 invoked by uid 65534); 15 Jul 2005 19:32:38 -0000 Message-ID: <20050715193238.52805.qmail@minotaur.apache.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r219236 - /incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/models/fieldtypes/TestFieldsOfObject.java Date: Fri, 15 Jul 2005 19:32:38 -0000 To: jdo-commits@db.apache.org From: clr@apache.org X-Mailer: svnmailer-1.0.2 X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Author: clr Date: Fri Jul 15 12:32:36 2005 New Revision: 219236 URL: http://svn.apache.org/viewcvs?rev=219236&view=rev Log: JDO-85 provide more information on failure for debugging Modified: incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/models/fieldtypes/TestFieldsOfObject.java Modified: incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/models/fieldtypes/TestFieldsOfObject.java URL: http://svn.apache.org/viewcvs/incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/models/fieldtypes/TestFieldsOfObject.java?rev=219236&r1=219235&r2=219236&view=diff ============================================================================== --- incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/models/fieldtypes/TestFieldsOfObject.java (original) +++ incubator/jdo/trunk/tck20/test/java/org/apache/jdo/tck/models/fieldtypes/TestFieldsOfObject.java Fri Jul 15 12:32:36 2005 @@ -126,15 +126,31 @@ int i; FieldsOfObject pi = (FieldsOfObject) pm.getObjectById(oid, true); int n = pi.getLength(); + StringBuffer buffer = new StringBuffer(); for( i = 0; i < n; ++i){ if( !FieldsOfObject.isPersistent[i] ) continue; Object val = pi.get(i); + if (val == null) { + buffer.append("Field "); + buffer.append(FieldsOfObject.fieldSpecs[i]); + buffer.append(" is null. Expected "); + buffer.append(startValue.toString()); + buffer.append(".\n"); + continue; + } if(!val.equals(startValue) ){ - fail(ASSERTION_FAILED, - "Incorrect value for " + FieldsOfObject.fieldSpecs[i] + - ", expected value " + startValue.toString() + - ", value is " + val.toString()); + buffer.append("Field "); + buffer.append(FieldsOfObject.fieldSpecs[i]); + buffer.append(" has wrong value: expected "); + buffer.append(startValue.toString()); + buffer.append(" actual "); + buffer.append(val.toString()); + buffer.append(".\n"); } + } + if (buffer.length() > 0) { + fail(ASSERTION_FAILED, + buffer.toString()); } } }