db-derby-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel John Debrunner <...@apache.org>
Subject Re: Generate Always and SQLIntegrityConstraintViolationException
Date Tue, 22 Jan 2008 15:42:49 GMT
Dyre.Tjeldvoll@Sun.COM wrote:

> I'm currently running the tests with the following patch which seems to
> fix the repro:
> 
> Index: java/engine/org/apache/derby/impl/sql/execute/RowResultSet.java
> ===================================================================
> --- java/engine/org/apache/derby/impl/sql/execute/RowResultSet.java     (revision 614214)
> +++ java/engine/org/apache/derby/impl/sql/execute/RowResultSet.java     (working copy)
> @@ -183,6 +183,7 @@
>                         if (SanityManager.DEBUG)
>                                 SanityManager.DEBUG("CloseRepeatInfo","Close of RowResultSet
repeated");
>  
> +        cachedRow = null;
>                 closeTime += getElapsedMillis(beginTime);
>         }
> 
> 
> If the tests pass, I'm ready to attach it to a Jira issue.

That just defeats the purpose of cachedRow, which is the ability to 
re-use the same result across multiple executions (opens).

I think the real bug is that canCacheRow is being passed in as true for 
the row of (default) when it should be false if the default column 
definition does not translate to a constant over time. With a default of 
CURRENT TIMESTAMP does the same problem occur?

Dan.


Mime
View raw message