db-derby-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rajesh Kartha <kar...@Source-Zone.Org>
Subject Re: [PATCH] creating Derby plug-in for Eclipse
Date Fri, 10 Dec 2004 20:59:14 GMT
Hello,

I have
- updated the comments in the .java file
- changed the version entry in plugin.xml to be consistent with the 
Derby builds: example - 10.1.0.0 (111546M)

Following is the svn diff and also please find attached the modified 
DerbyEclipsePlugin.java file. Let me know, if there any further
changes are needed, else please update the codeline.

CHANGES:
------------------
svn diff:
-----------
Index: build.xml
===================================================================
--- build.xml   (revision 111546)
+++ build.xml   (working copy)
@@ -591,6 +591,45 @@
   </target>

 <!-- 
=================================================================== -->
+<!-- Eclipse Plugin                                                     -->
+<!-- 
=================================================================== -->
+  <target name="plugin" depends= "buildjars">
+       <echo message="Begining Derby Eclipse plugin build"/>
+       <property name="plugin.tmp.dir" value ="plugintmp"/>
+       <mkdir dir="${derby.jar.dir}/${plugin.tmp.dir}"/>
+
+       <java classname="org.apache.derbyBuild.eclipse.DerbyEclipsePlugin">
+               <arg value="${derby.jar.dir}/${plugin.tmp.dir}"/>
+               <classpath>
+                       <pathelement path="${out.dir}"/>
+               </classpath>
+       </java>
+
+       <property 
file="${derby.jar.dir}/${plugin.tmp.dir}/plugintmp.properties"/>
+       <echo message="Derby Eclipse plugin build: 
${plugin.derby.version.build.number}"/>
+
+       <property name="plugin.dir" value ="plugins"/>
+       <property name="plugin.core.dir" value 
="${plugin.derby.core}_${plugin.derby.version}"/>
+
+       <mkdir 
dir="${derby.jar.dir}/${plugin.tmp.dir}/${plugin.dir}/${plugin.core.dir}"/>
+
+       <copy 
todir="${derby.jar.dir}/${plugin.tmp.dir}/${plugin.dir}/${plugin.core.dir}">
+               <fileset dir="${derby.jar.dir}" includes="derby*.jar" 
excludes="derbyLocale*.jar"/>
+       </copy>
+       <copy 
todir="${derby.jar.dir}/${plugin.tmp.dir}/${plugin.dir}/${plugin.core.dir}">
+               <fileset dir="${derby.jar.dir}/${plugin.tmp.dir}" 
includes="plugin*.xml"/>
+       </copy>
+
+       <delete 
file="${derby.jar.dir}/${plugin.tmp.dir}/plugintmp.properties"/>
+       <delete file="${derby.jar.dir}/${plugin.tmp.dir}/plugin.xml"/>
+
+       <!-- ZIP to create the final Derby plug-in -->
+
+       <zip 
zipfile="${derby.jar.dir}/${plugin.derby.core.zipfile}_${plugin.derby.version}.zip" 
compress="true" basedir="${d
erby.jar.dir}/${plugin.tmp.dir}"/>
+       <delete dir="${derby.jar.dir}/${plugin.tmp.dir}"/>
+  </target>
+
+<!-- 
=================================================================== -->
 <!--                               Jar 
targets                           -->
 <!-- 
=================================================================== -->

Regards,
Rajesh


=======================================End of 
mail==========================================================
Rajesh Kartha wrote:

> Hello,
>
> Comments:
>
> 1) I  agree to adding the comments to the  Javadoc comment section of 
> the DerbyEclipsePlugin, so they can be referred later.
> 2) Yes, the <maint> is the 'interim', which Andrew referred to - the 
> third element. The full build version is included in the plugin.xml file,
>    which the users can quote while communicating. It will show up in 
> Help - About Eclipse Platform - Plug-in Details of Eclipse.
> 3)  The version of  10.1.0.0_v<build number> was based on the plugin  
> versioning scheme used by Eclipse. You can read more about it at:
>
>      
> http://dev.eclipse.org/viewcvs/index.cgi/platform-core-home/documents/plugin-versioning.html?rev=HEAD

>
>
>    Eitherway, I tried using the normal Derby versioning (example: 
> 10.1.0.0 (111298M) ) in the plugin.xml, which worked fine.  So we can go
>    with the Derby versioning if  everyone feels that is the right 
> approach.
> 4) I would also like to propose the name 'Apache Derby Core Plug-in 
> for Eclipse' instead of just  'Apache Derby Core Plug-in' for this 
> plugin.
>
> Please do let me know and I will update the DerbyEclipsePlugin.java 
> file accordingly to reflect the above and send it to the list for review.
>
>
> Regards,
> Rajesh
>
> Daniel John Debrunner wrote:
>
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Rajesh Kartha wrote:
>>
>>
>>  
>>
>>> - the package name for the Derby plug-in will be:
>>> org.apache.derby.core_<major>.<minor>.<maint> (example:
>>> org.apache.derby.core_10.1.0).
>>>  This is based on the naming convention used normally for Eclipse
>>> plug-ins.
>>> - the plugin.xml file will show the correct version of the Derby build
>>> present in the package with the appropriate build number
>>>  (shows up under Help  - About Eclipse Platform - Plug-in Details)
>>> example: 10.1.0.0_v111184
>>> - the zip file created for the DerbyEclipse will have the name:
>>> derby_core_plugin_<major>.<minor>.<maint>.zip (example:
>>> derby_core_plugin_10.1.0.zip)
>>> - the current packaging includes derby.jar, derbynet.jar and
>>> derbytools.jar. The locale jars for Derby are not included yet, any
>>> suggestions ?
>>>   
>>
>>
>> I hate to be a pain, but the comments above would be very useful in the
>> class Javadoc comment of DerbyEclipsePlugin, rather than just in the
>> list archive.
>>
>> Questions
>>
>>  
>>
>>> org.apache.derby.core_<major>.<minor>.<maint>
>>>   
>>
>>
>> By <maint> do you mean that it will match the third element of the four
>> part Derby version, which I called 'fixpack' and Andrew called 'interim'
>> in these e-mails.
>>
>> http://nagoya.apache.org/eyebrowse/ReadMsg?listName=derby-dev@db.apache.org&msgNo=73

>>
>> http://nagoya.apache.org/eyebrowse/ReadMsg?listName=derby-dev@db.apache.org&msgNo=603

>>
>>
>>
>>  
>>
>>> example: 10.1.0.0_v111184
>>>   
>>
>>
>> May be picky, but that version string doesn't match the format of the
>> Derby version string, why add the 'v'?
>>
>>
>> Dan.
>> -----BEGIN PGP SIGNATURE-----
>> Version: GnuPG v1.2.5 (MingW32)
>> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
>>
>> iD8DBQFBtxSdIv0S4qsbfuQRAtBNAJ9GLz7jHJKhpe+cBy4J9KzE+vaoegCfXKgN
>> kU/IrUc0WwoAVRexpv5z5cM=
>> =Ht71
>> -----END PGP SIGNATURE-----
>>
>>  
>>
>


Mime
View raw message